fix: await main bundle generation - #3198
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking/build behavior changes
locale.json.Problem
The final
build(configFactory(...))call was not awaited. Type copying and locale manifest generation could start while the main bundle was still pending, and the command's async workflow could finish without observing a rejected Rollup promise.Fix
Await the main bundle build, matching the already-sequential locale and plugin builds.
A regression test holds the mocked Rollup promise open and verifies that locale manifest generation cannot begin until the main bundle resolves.
Verification
npm test— 94 suites, 795 tests passednpm run lintNODE_OPTIONS=--openssl-legacy-provider npm run buildgit diff --check