Skip to content

Add prefix to allow sending as literal text to Xbox #166736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tr4nt0r wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −3
Open

Add prefix to allow sending as literal text to Xbox #166736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a241514
Add prefix to allow sending as literal text to Xbox
tr4nt0r Mar 28, 2026
c1d2d8a
Merge branch 'dev' into xbox_send_literal_text
tr4nt0r Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/xbox/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,6 @@ async def async_send_command(self, command: Iterable[str], **kwargs: Any) -> Non
)
else:
await self.client.smartglass.insert_text(
self._console.id, single_command
self._console.id, single_command.removeprefix("text:")
)
Comment thread
tr4nt0r marked this conversation as resolved.
Comment thread
tr4nt0r marked this conversation as resolved.
await asyncio.sleep(delay)
7 changes: 5 additions & 2 deletions tests/components/xbox/test_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,13 @@ async def test_send_command(
call.assert_called_once_with("HIJKLMN")


@pytest.mark.parametrize(("text", "expected"), [("Hello", "Hello"), ("text:A", "A")])
async def test_send_text(
hass: HomeAssistant,
xbox_live_client: AsyncMock,
config_entry: MockConfigEntry,
text: str,
expected: str,
) -> None:
"""Test remote send text."""

Expand All @@ -160,12 +163,12 @@ async def test_send_text(
await hass.services.async_call(
REMOTE_DOMAIN,
SERVICE_SEND_COMMAND,
{ATTR_COMMAND: "Hello", ATTR_DELAY_SECS: 0},
{ATTR_COMMAND: text, ATTR_DELAY_SECS: 0},
target={ATTR_ENTITY_ID: "remote.xone"},
blocking=True,
)

xbox_live_client.smartglass.insert_text.assert_called_once_with("HIJKLMN", "Hello")
xbox_live_client.smartglass.insert_text.assert_called_once_with("HIJKLMN", expected)


async def test_turn_on(
Expand Down
Loading