Add prefix to allow sending as literal text to Xbox#166736
Conversation
|
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
Adds an escape prefix to the Xbox remote.send_command handling so users can force text insertion when the provided string would otherwise be interpreted as a known button/command.
Changes:
- Strip a
text:prefix before sending text via Smartglassinsert_text. - Extend the Xbox remote tests to validate the new prefix behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/components/xbox/remote.py |
Implements text: prefix stripping when falling back to text insertion. |
tests/components/xbox/test_remote.py |
Adds parametrized test coverage for the new prefixed-literal text behavior. |
joostlek
left a comment
There was a problem hiding this comment.
Meh, I am a bit against doing it like this, rather have a service action for this instead
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Adds a prefix to the remote platform to allow sending text as literal instead of a command in case the text matches a command.
Type of change
Additional information
text:prefix documentation to Xbox home-assistant.io#44360Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: