Skip to content

Add prefix to allow sending as literal text to Xbox#166736

Open
tr4nt0r wants to merge 2 commits into
home-assistant:devfrom
tr4nt0r:xbox_send_literal_text
Open

Add prefix to allow sending as literal text to Xbox#166736
tr4nt0r wants to merge 2 commits into
home-assistant:devfrom
tr4nt0r:xbox_send_literal_text

Conversation

@tr4nt0r
Copy link
Copy Markdown
Contributor

@tr4nt0r tr4nt0r commented Mar 28, 2026

Proposed change

Adds a prefix to the remote platform to allow sending text as literal instead of a command in case the text matches a command.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@tr4nt0r tr4nt0r requested a review from hunterjm as a code owner March 28, 2026 10:43
Copilot AI review requested due to automatic review settings March 28, 2026 10:43
@home-assistant home-assistant Bot added cla-signed has-tests integration: xbox new-feature small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage labels Mar 28, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (xbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an escape prefix to the Xbox remote.send_command handling so users can force text insertion when the provided string would otherwise be interpreted as a known button/command.

Changes:

  • Strip a text: prefix before sending text via Smartglass insert_text.
  • Extend the Xbox remote tests to validate the new prefix behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/xbox/remote.py Implements text: prefix stripping when falling back to text insertion.
tests/components/xbox/test_remote.py Adds parametrized test coverage for the new prefixed-literal text behavior.

Comment thread homeassistant/components/xbox/remote.py
Comment thread homeassistant/components/xbox/remote.py
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, I am a bit against doing it like this, rather have a service action for this instead

@issue-triage-workflows
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants