Skip to content

✨ say.tone: hand the listening chime to the desktop companion - #52

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
companion-tone
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
companion-tone

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Refs hivecommons/quorum-companion#12

Quorum side of the companion listening chime (design: hivecommons/quorum-companion#12).

  • CompanionAdapter.tone() marks one tone pending; the next GET /companion/outbox answers tone:true once (otherwise tone:false).
  • played:true only while the companion is connected: it fetched its outbox within QUORUM_COMPANION_CONNECTED_MS (default 5000). Otherwise played:false, so hive never counts a chime nobody can hear.
  • A second tone while one waits to be fetched is dropped (one chime); a tone not fetched within QUORUM_COMPANION_TONE_TTL_MS (default 4000) expires, so a late chime never plays. Never throws.
  • The companion never speaks (say is still platform_unavailable), so there is no line in progress to collide with.
  • docs/contract.md and README: the companion is no longer "no tone"; the outbox shape gains tone; the two new env vars.

Tests (fake clock, no audio): dropped before the companion is connected, delivered once, second tone dropped while pending, dropped after the companion stopped polling, stale tone expires and does not block the next, never plays for a meeting that left; end to end over MCP say.tone and /companion/outbox.

No version bump and no tag: 0.6.0 stays untagged for the operator.

🤖 Generated with Claude Code

The companion adapter now implements tone(): it marks one tone pending and the next
/companion/outbox fetch answers tone:true once. played is true only while the companion is
connected (it fetched its outbox within QUORUM_COMPANION_CONNECTED_MS, default 5000); a second
tone while one waits is dropped, and a tone nobody fetched within QUORUM_COMPANION_TONE_TTL_MS
(default 4000) expires so a late chime never plays. Never throws.

Refs hivecommons/quorum-companion#12

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive
hivecommons-hive Bot merged commit 10032e1 into main Nov 18, 2026
7 of 8 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the companion-tone branch November 18, 2026 19:53
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#5235a7f61` sha256:51b6c3e7165e6be6be83fb141b606c5798a11a9ad4823c0af0c0e202823b3ccc — download from the dashboard or `hivectl review evidence #52`.

merged by Hive trusted-author auto-merge: author clubanderson holds role owner and GitHub permission admin on repo; CI green at 35a7f61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes lgtm Approved by a Hive merger/owner for auto-merge on green CI size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant