Repository navigation
✨ say.tone: hand the listening chime to the desktop companion - #52
Merged
Merged
Conversation
The companion adapter now implements tone(): it marks one tone pending and the next /companion/outbox fetch answers tone:true once. played is true only while the companion is connected (it fetched its outbox within QUORUM_COMPANION_CONNECTED_MS, default 5000); a second tone while one waits is dropped, and a tone nobody fetched within QUORUM_COMPANION_TONE_TTL_MS (default 4000) expires so a late chime never plays. Never throws. Refs hivecommons/quorum-companion#12 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#5235a7f61` sha256:51b6c3e7165e6be6be83fb141b606c5798a11a9ad4823c0af0c0e202823b3ccc — download from the dashboard or `hivectl review evidence #52`.merged by Hive trusted-author auto-merge: author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs hivecommons/quorum-companion#12
Quorum side of the companion listening chime (design: hivecommons/quorum-companion#12).
CompanionAdapter.tone()marks one tone pending; the nextGET /companion/outboxanswerstone:trueonce (otherwisetone:false).played:trueonly while the companion is connected: it fetched its outbox withinQUORUM_COMPANION_CONNECTED_MS(default 5000). Otherwiseplayed:false, so hive never counts a chime nobody can hear.QUORUM_COMPANION_TONE_TTL_MS(default 4000) expires, so a late chime never plays. Never throws.sayis stillplatform_unavailable), so there is no line in progress to collide with.docs/contract.mdand README: the companion is no longer "no tone"; the outbox shape gainstone; the two new env vars.Tests (fake clock, no audio): dropped before the companion is connected, delivered once, second tone dropped while pending, dropped after the companion stopped polling, stale tone expires and does not block the next, never plays for a meeting that left; end to end over MCP
say.toneand/companion/outbox.No version bump and no tag: 0.6.0 stays untagged for the operator.
🤖 Generated with Claude Code