Skip to content

✨ meetings: pass Betty's listening chime to the desktop companion - #19116

Merged
kubestellar-prow[bot] merged 1 commit into
v5from
companion-listening-tone
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 1 commit into
v5from
companion-listening-tone

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Refs hivecommons/quorum-companion#12

Hive side of the companion listening chime (design in hivecommons/quorum-companion#12; quorum side: hivecommons/quorum#52).

  • Client.CompanionOutbox now returns a CompanionPage (lines, next_seq, tone). An older Quorum without tone reads as false, so this is safe before the quorum change ships.
  • GET /api/companion/meetings/{id}/replies gains tone (true once when the window should play the chime now).
  • The live session's tone gate (toneAllowed) skips the meeting voice check for companion meetings only: a companion meeting never has voice in the call, and the chime plays on the host's own computer. meetings.listening_tone, meetings.voice_on_address, the speech and cross-talk checks still apply.
  • Docs: src/docs/meetings.md (Desktop companion, replies route, meetings.listening_tone). Changelog fragment added.

Tests: tone passed through once by CompanionReplies, client decodes tone, companion tone allowed with the meeting's voice off and refused with voice_on_address off.

v5 only. No pin bump, no release.

🤖 Generated with Claude Code

The companion replies route carries tone (Quorum's /companion/outbox tone flag, true once per
say.tone while the companion is polling), and the live session's tone gate skips the meeting voice
check for companion meetings: the companion plays the chime on the host's own computer, never into
the call. meetings.listening_tone and meetings.voice_on_address still apply.

Refs hivecommons/quorum-companion#12

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19101 ✨ Hub: send the confirmation reply for mail sent to a hive with DKIM, behind the signing key (off by default) same files src/docs/meetings.md

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 3b8cbcd into v5 Nov 18, 2026
104 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the companion-listening-tone branch November 18, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant