Repository navigation
✨ meetings: pass Betty's listening chime to the desktop companion - #19116
Merged
Merged
Conversation
The companion replies route carries tone (Quorum's /companion/outbox tone flag, true once per say.tone while the companion is polling), and the live session's tone gate skips the meeting voice check for companion meetings: the companion plays the chime on the host's own computer, never into the call. meetings.listening_tone and meetings.voice_on_address still apply. Refs hivecommons/quorum-companion#12 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs hivecommons/quorum-companion#12
Hive side of the companion listening chime (design in hivecommons/quorum-companion#12; quorum side: hivecommons/quorum#52).
Client.CompanionOutboxnow returns aCompanionPage(lines, next_seq, tone). An older Quorum withouttonereads as false, so this is safe before the quorum change ships.GET /api/companion/meetings/{id}/repliesgainstone(true once when the window should play the chime now).toneAllowed) skips the meeting voice check for companion meetings only: a companion meeting never has voice in the call, and the chime plays on the host's own computer.meetings.listening_tone,meetings.voice_on_address, the speech and cross-talk checks still apply.src/docs/meetings.md(Desktop companion, replies route,meetings.listening_tone). Changelog fragment added.Tests: tone passed through once by
CompanionReplies, client decodestone, companion tone allowed with the meeting's voice off and refused withvoice_on_addressoff.v5 only. No pin bump, no release.
🤖 Generated with Claude Code