Repository navigation
π attribution: find the trailer when footer lines follow it - #19366
Merged
hivecommons-hive[bot] merged 2 commits intoNov 20, 2026
Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons-hive[bot] merged 2 commits into
Conversation
ParseAttributionTrailer took the trailer only when it was the last non-blank line before the identity footer, so a Refs/Closes/Fixes line, an HTML marker or a "Generated with" line below it dropped the PR from PRs by model, Most effective models and the rework/cost figures (112 of 707 trailer-carrying projectbluefin PRs). Those footer lines, and one identity footer that is no longer last, are now skipped; any other line after the trailer still means no trailer. rewriteRefsIssueLinkToClosing now inserts its issue-link-fixed marker above the trailer instead of appending it below. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#19366d80d578` sha256:6485b4ed37e449d2caf24fa89a76eeab04710a7f55c9b400377a672096fd6487 β download from the dashboard or `hivectl review evidence #19366`.merged by Hive trusted-author auto-merge: author |
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governor "PRs by model", Operations "Most effective models" and the rework and cost figures find a PR's model from its attribution trailer (
-- hive: agent=β¦ backend=β¦ model=β¦). The parser only accepted the trailer when it was the last non-blank line before the identity footer, so any line below it dropped the PR from every count.On projectbluefin that drops 112 of 707 trailer-carrying PRs (16%). The lines found below the trailer were
Refs #N(46), the hive's own<!-- hive:issue-link-fixed -->(22),Closes #N(14),π€ Generated with [Claude Code](β¦)(11),Fixes #N(2) and free prose (~17). Examples: projectbluefin/utah-packages#949, utah-packages#1014, projectbluefin/website#1040.What changes
Refs,Closes,Fixes,Resolves,Part ofand the other GitHub closing keywords, any case,#N,owner/repo#Nor an issue URL), with an optional note after a dash, colon or parenthesis (Refs #503 β remaining: β¦);π€ Generated with β¦line;Fixes #Nwas appended below.Fixes the flaky test in #7is prose, not a footer line. If there are two trailers, the last one wins, as before.Refs #NtoFixes #Nnow puts its<!-- hive:issue-link-fixed -->marker above the trailer, not below it. A body with no trailer gets exactly the same output as today.Every reader goes through
ParseAttributionTrailer, so the write-back and blocked-depends-on checks that use it for "is this a hive PR" also see these PRs as hive-attributed now. That's intended: they are hive PRs. No new way to forge it: a trailer as the last line already counted.Not in this PR
pr_rework) still stops atSigned-off-by:/Co-Authored-By:. Unchanged on purpose.Fixes #Nat the very end of a PR body (EnsureIssueStagePRLink,LinkContributorPRToIssue). The parser now tolerates that, so they are left alone; their tests assert the exact output.Tests
π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1