Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkβ
Resolved: no conflicting open PRs or same-file overlaps remain against |
|
@kellyaa this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
#19366 landed the trailer-past-footer-lines fix this PR carried, so the parser and marker-insertion changes are dropped in favour of the upstream implementation. What remains are regression cases upstream does not cover: an unclosed HTML comment, a language-tagged code fence and a keyword inside prose after the trailer still hide it, and a mixed Closes/marker/Generated with/Refs tail before the identity footer parses with CRLF line endings. Fixes #19364 Hive-Run: #19364 Hive-Plan: issue-19364 Hive-Spec: issue-19364#acceptance-criteria Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: kellyaa <kellyaa@users.noreply.github.com>
ee3be93 to
29d6fdf
Compare
Fixes #19364
What
#19366 landed on
v6while this PR was open. It fixes the same bug:ParseAttributionTrailernow reads the trailer past Refs/Closes/Fixes lines, HTML markers andπ€ Generated withlines, andrewriteRefsIssueLinkToClosingputs its marker above the trailer. The two branches conflicted, so on rebase I dropped this PR's parser and repair changes and its changelog fragment, and kept the upstream implementation as-is.This PR now only adds regression cases that the upstream tests don't cover, in
src/pkg/github/attribution_footer_lines_extra_test.go:<!--comment, a code fence with a language tag (```text) wrapping aRefsline, and a closing keyword in the middle of a sentenceCloses, the issue-link marker,Generated with,Refs) followed by the identity footer, with CRLF line endings, still parses as attributedTests
go test ./pkg/github/ -run 'Attribution|RewriteRefs'passes locally on the rebased head. CI decides the rest.π€ Generated with Claude Code
-- hive: backend=claude model=claude-opus-5-5