Skip to content

🌱 attribution: extra footer-line regression cases for the trailer parser - #19367

Open
kellyaa wants to merge 1 commit into
v6from
fix/19364-trailer-footer-lines
Open

kellyaa wants to merge 1 commit into
v6from
fix/19364-trailer-footer-lines

Conversation

@kellyaa

@kellyaa kellyaa commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #19364

What

#19366 landed on v6 while this PR was open. It fixes the same bug: ParseAttributionTrailer now reads the trailer past Refs/Closes/Fixes lines, HTML markers and πŸ€– Generated with lines, and rewriteRefsIssueLinkToClosing puts its marker above the trailer. The two branches conflicted, so on rebase I dropped this PR's parser and repair changes and its changelog fragment, and kept the upstream implementation as-is.

This PR now only adds regression cases that the upstream tests don't cover, in src/pkg/github/attribution_footer_lines_extra_test.go:

  • each of these after the trailer still means "no trailer": an unclosed <!-- comment, a code fence with a language tag (```text) wrapping a Refs line, and a closing keyword in the middle of a sentence
  • a mixed tail (Closes, the issue-link marker, Generated with, Refs) followed by the identity footer, with CRLF line endings, still parses as attributed

Tests

go test ./pkg/github/ -run 'Attribution|RewriteRefs' passes locally on the rebased head. CI decides the rest.

πŸ€– Generated with Claude Code

-- hive: backend=claude model=claude-opus-5-5

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 20, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

βœ… Resolved: no conflicting open PRs or same-file overlaps remain against v6.

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 20, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@kellyaa this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 20, 2026
#19366 landed the trailer-past-footer-lines fix this PR carried, so the
parser and marker-insertion changes are dropped in favour of the upstream
implementation. What remains are regression cases upstream does not cover:
an unclosed HTML comment, a language-tagged code fence and a keyword inside
prose after the trailer still hide it, and a mixed Closes/marker/Generated
with/Refs tail before the identity footer parses with CRLF line endings.

Fixes #19364

Hive-Run: #19364
Hive-Plan: issue-19364
Hive-Spec: issue-19364#acceptance-criteria
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: kellyaa <kellyaa@users.noreply.github.com>
@kellyaa
kellyaa force-pushed the fix/19364-trailer-footer-lines branch from ee3be93 to 29d6fdf Compare November 20, 2026 04:35
@kubestellar-prow kubestellar-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2026
@kellyaa kellyaa changed the title πŸ› Keep PR attribution when footer lines follow the hive trailer 🌱 attribution: extra footer-line regression cases for the trailer parser Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› [v6] PR attribution: a PR drops out of "PRs by model" when any line follows the hive trailer

1 participant