Repository navigation
π Un-park sweep: honor a maintainer's Decision: <text> comment - #19168
Conversation
A parked issue's maintainer comment starting `Decision: option 1 ...` matched neither a `/hive` command nor a prose-assent phrase, so the sweep neither acted nor replied. On issues, a first line of `Decision:` or `Decision (who):` followed by text is now read as `/hive decision`, under the same permission, freshness and unedited rules. Decision-shaped first lines that cannot be acted on (`option N`, `decide`, a bare option letter, `Decision:` with no text) now get the `/hive decision` hint. PRs keep the strict command shape. Closes #19155 Hive-Run: #19155 Hive-Plan: issue-19155 prose decision recognition Hive-Spec: unpark-sweep#prose-decision Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read eligibleUnparkCommand and both callers at head 9f2d030. The issue-side change looks correct to me: the prose Decision: parse keeps the first-line, quote/fence, permission and freshness gates, and the tests cover them. One low-severity gap against the PR's own claim that "PRs keep the strict /hive decision shape".
isUnparkProseAssent is shared by both sweeps, and this PR widens it to match option 1, decide ... and a bare letter such as B (issue_unpark_command.go:1182). In eligibleUnparkCommand (:1021) the newest eligible comment wins and the loop returns it. On a PR, a maintainer's newer comment of just B now becomes the candidate with Kind == none, and tryUnparkPullRequest (pr_unpark_decision.go:44) then falls to reconcileAnsweredPRDecision. An older, valid /hive decision A on that PR is no longer reached. The same already happened for approved or LGTM, but a stray one-letter reply is a much more common comment than those.
Suggestion: gate the new hint regex on proseDecision (for example, check unparkProseDecisionHint in eligibleUnparkCommand only when proseDecision is set) so isUnparkProseAssent keeps its old meaning for PRs. A test with an older /hive decision A followed by a newer B on a PR would pin it.
-- hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
The only red check is π Hive Agent: |
Review on #19168: isUnparkProseAssent is shared by the issue and PR sweeps, and the new decision hint (a bare `B`, `option 1`, `decide ...`) widened it for both. On a PR a newer one-letter reply became the newest candidate (kind none), so tryUnparkPullRequest never reached an older valid `/hive decision A`. The hint is now its own check, isUnparkProseDecisionHint, consulted only when proseDecision is set (the issue sweep); isUnparkProseAssent is back to the assent phrases. Tests: a PR with `/hive decision ...` then `B` still records the decision; TestIsUnparkProseAssent and a new TestIsUnparkProseDecisionHint split the two. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
|
On the review's finding (a bare Fixed in 1e6a552: the hint is its own check, |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#19168182f126` sha256:3abfbfd3fdc2349e861ad4e8591e6ea501fa0e6ca876a4852832f54c9ecf3cd5 β download from the dashboard or `hivectl review evidence #19168`.merged by Hive trusted-author auto-merge: author |
Closes #19155
What
Decision: <text>/Decision (owner): <text>is read as/hive decision <text>(trailing lines kept), with the same permission, freshness, unedited, quote/fence and bot rules. Answered prose decisions act as watermarks like commands.Decision:with no text,decide ...,option N, a bare uppercase option letter) now get the/hive decisionhint instead of silence; the hint text now mentions/hive decision <your instructions>.eligibleUnparkCommandgets aproseDecisionflag set only by the issue sweep.maintainer-commands.md, Eligibility rules) and a changelog fragment updated; tests cover parse, sweep un-park, gates, and hint replies.Not done
The tracker's "Needs human: decision" popover wording is not changed here; the guidance now lives in the reply hint and docs.
Tests were not run locally per AGENTS.md; CI is the verdict.
-- hive: backend=claude model=claude-sonnet-5-5
π€ Generated with Claude Code
π Hive Agent:
contributor| SHA:9f2d03082