Skip to content

πŸ› Un-park sweep: honor a maintainer's Decision: <text> comment - #19168

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
fix/unpark-decision-prose-19155
Nov 19, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
fix/unpark-decision-prose-19155

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Closes #19155

What

  • On issues, a first line of Decision: <text> / Decision (owner): <text> is read as /hive decision <text> (trailing lines kept), with the same permission, freshness, unedited, quote/fence and bot rules. Answered prose decisions act as watermarks like commands.
  • Decision-shaped first lines that cannot be acted on (Decision: with no text, decide ..., option N, a bare uppercase option letter) now get the /hive decision hint instead of silence; the hint text now mentions /hive decision <your instructions>.
  • PRs are unchanged: eligibleUnparkCommand gets a proseDecision flag set only by the issue sweep.
  • Docs (maintainer-commands.md, Eligibility rules) and a changelog fragment updated; tests cover parse, sweep un-park, gates, and hint replies.

Not done

The tracker's "Needs human: decision" popover wording is not changed here; the guidance now lives in the reply hint and docs.

Tests were not run locally per AGENTS.md; CI is the verdict.

-- hive: backend=claude model=claude-sonnet-5-5
πŸ€– Generated with Claude Code


🐝 Hive Agent: contributor | SHA: 9f2d03082

A parked issue's maintainer comment starting `Decision: option 1 ...`
matched neither a `/hive` command nor a prose-assent phrase, so the
sweep neither acted nor replied. On issues, a first line of `Decision:`
or `Decision (who):` followed by text is now read as `/hive decision`,
under the same permission, freshness and unedited rules. Decision-shaped
first lines that cannot be acted on (`option N`, `decide`, a bare option
letter, `Decision:` with no text) now get the `/hive decision` hint.
PRs keep the strict command shape.

Closes #19155

Hive-Run: #19155
Hive-Plan: issue-19155 prose decision recognition
Hive-Spec: unpark-sweep#prose-decision
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17512 πŸ› fix(github): recognise the hive's own unpark replies when it posts as an unconfigured login same files src/pkg/github/issue_unpark_command.go
src/pkg/github/issue_unpark_command_test.go

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read eligibleUnparkCommand and both callers at head 9f2d030. The issue-side change looks correct to me: the prose Decision: parse keeps the first-line, quote/fence, permission and freshness gates, and the tests cover them. One low-severity gap against the PR's own claim that "PRs keep the strict /hive decision shape".

isUnparkProseAssent is shared by both sweeps, and this PR widens it to match option 1, decide ... and a bare letter such as B (issue_unpark_command.go:1182). In eligibleUnparkCommand (:1021) the newest eligible comment wins and the loop returns it. On a PR, a maintainer's newer comment of just B now becomes the candidate with Kind == none, and tryUnparkPullRequest (pr_unpark_decision.go:44) then falls to reconcileAnsweredPRDecision. An older, valid /hive decision A on that PR is no longer reached. The same already happened for approved or LGTM, but a stray one-letter reply is a much more common comment than those.

Suggestion: gate the new hint regex on proseDecision (for example, check unparkProseDecisionHint in eligibleUnparkCommand only when proseDecision is set) so isUnparkProseAssent keeps its old meaning for PRs. A test with an older /hive decision A followed by a newer B on a PR would pin it.

-- hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.327

@Danathar
Danathar marked this pull request as draft November 18, 2026 23:19
@kubestellar-prow kubestellar-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The only red check is native-queue-policy (run 44419817441). It fails because this PR is a draft: "#19168 is a draft; not eligible for admission (PR state, not a CI failure)". All other checks are green and there is no code fix to push. I did not mark the PR ready, since it also carries do-not-merge/work-in-progress. Marking it ready for review will re-run the check.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

Review on #19168: isUnparkProseAssent is shared by the issue and PR
sweeps, and the new decision hint (a bare `B`, `option 1`, `decide ...`)
widened it for both. On a PR a newer one-letter reply became the newest
candidate (kind none), so tryUnparkPullRequest never reached an older
valid `/hive decision A`.

The hint is now its own check, isUnparkProseDecisionHint, consulted only
when proseDecision is set (the issue sweep); isUnparkProseAssent is back
to the assent phrases. Tests: a PR with `/hive decision ...` then `B`
still records the decision; TestIsUnparkProseAssent and a new
TestIsUnparkProseDecisionHint split the two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
@Danathar

Copy link
Copy Markdown
Contributor Author

On the review's finding (a bare B on a PR hiding an older /hive decision): verified at 9f2d030. The PR sweep calls eligibleUnparkCommand(..., proseDecision=false), and the widened isUnparkProseAssent let a newer one-letter reply become the newest candidate (kind none), so tryUnparkPullRequest went to reconcileAnsweredPRDecision and never reached the older decision.

Fixed in 1e6a552: the hint is its own check, isUnparkProseDecisionHint, consulted only when proseDecision is set (the issue sweep), and isUnparkProseAssent is back to the assent phrases. New test TestSweepIssueUnparkCommandsPRBareLetterDoesNotHideDecision (/hive decision … then B on a PR still records the decision), and TestIsUnparkProseAssent / TestIsUnparkProseDecisionHint split the two. The issue-side hint replies are unchanged.

@Danathar
Danathar marked this pull request as ready for review November 18, 2026 23:29
@kubestellar-prow kubestellar-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit f77363c into v5 Nov 19, 2026
87 of 88 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/unpark-decision-prose-19155 branch November 19, 2026 00:00
@hivecommons-hive

hivecommons-hive Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#19168182f126` sha256:3abfbfd3fdc2349e861ad4e8591e6ea501fa0e6ca876a4852832f54c9ecf3cd5 β€” download from the dashboard or `hivectl review evidence #19168`.

merged by Hive trusted-author auto-merge: author Danathar holds role owner and GitHub permission maintain on repo; CI green at 182f126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Un-park sweep silently ignores a maintainer's plain "Decision: option N" comment on a parked issue

1 participant