Repository navigation
Conversation
…as an unconfigured login The un-park sweep only believes a hive:unpark-reply / hive:label-approval marker when the comment's author is one of the hive's own accounts (markerAuthorTrusted, #11313). An App installed under its own slug with no github.app_slug set falls back to the public default slug, so the hive's real <slug>[bot] login was never among those accounts: every sweep saw the command as unanswered and replied again. A live tuna-os hive posted 320+ identical replies on each of four issues (40-58 a day) this way. Record the author GitHub returns when the client creates an un-park reply, notice or label-approval comment. That author is by definition the account the token posts as, so isHiveAccount now matches it through the existing cachedSelfLogin check. A marker pasted by any other account still does not count. Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap check✅ Resolved: no conflicting open PRs or same-file overlaps remain against |
Mutation testing (advisory)No surviving mutants in changed files (or the run hit its time budget before reporting any). Advisory only; this job never blocks the PR (#17349). |
…ct (#18281) native-queue-policy went red on #17512, #18273, #18275 and #18278 and the scanner filed it as one shared-CI incident (#18280). The gate was right every time: #17512 is a draft carrying do-not-merge/work-in-progress, #18273 and #18275 have probot DCO action_required, and #18278 has changelog-fragment-guard failure. The defect was the surface. A red provider was thrown as a bare `Error('DCO: action_required')` and printed as "Unhandled error" with a stack trace, which reads like a broken workflow. evidenceForHead and assertProwDCO now throw a ProviderVerdict naming the provider, its conclusion, the head, and that this is a per-PR verdict and not a shared CI incident. The evidence-wait step reports it with a job summary and core.setFailed instead of rethrowing. The conclusion stays failure: this is a required check. Hive-Run: #18280 Hive-Plan: shared-ci incident triage Hive-Spec: native-queue-policy#provider-verdict Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
Hi @hanthor, checking in on this one. It has been a draft since Nov 10 with no updates since. Are you still planning to finish it? If so, mark it ready for review when it's done and we'll get it through. If it's no longer needed (for example if a later change already covers the unpark-reply case), please close it. If we don't hear back in about a week we'll close it so the queue stays clean, and you're welcome to reopen anytime. Thanks! |
|
hive recommends: close #17512 as superseded: #11313 was already fixed by merged PR #11711 (096c5c7); owner to confirm Rationale: issue #11313 is closed and merged PR #11711 (096c5c7) closed it, so #17512 has nothing left to deliver; it is closed as superseded, not adopted (#15289); a person pushed it themselves, so the hive asks them to close it. Hive decided: Recommended only; a person confirms. Decided by the hive at @clubanderson's request as the owner's delegate under the owner-delegate policy (rule |
Brings the branch up to date with v5 (1095 commits). No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
e7eb4eb to
75eda2f
Compare
Summary
/hivecommand on every sweep when the hive posts as a GitHub login its configured identity doesn't name.answeredUnparkCommentIDscounts ahive:unpark-replymarker only whenmarkerAuthorTrustedaccepts the comment's author.github.app_slugset, falls back toDefaultGitHubAppSlug(hivecommons-hive). Because the identity names that slug,knowsOwnAccounts()is true.<slug>[bot]login is never in the identity, and an App installation token cannot callGET /user, so each sweep sees its own reply as untrusted, treats the command as unanswered and replies again.learnSelfLoginrecords the author GitHub returns when the client creates an un-park reply, a notice or a label-approval comment. That author is the account the token posts as.isHiveAccountalready acceptscachedSelfLogin(), so the hive's own markers count from the next sweep on.GET /userreturns.Evidence from a live hive (tuna-os)
The hive's own replies all carry the same marker,
id=6582313529, which points at the one maintainer comment it keeps answering:The flood stopped at 2026-11-09 16:13 UTC only because the issues were un-parked by hand on 11-10; the code path is unchanged on
v5.On v6 the repeated reply is the
project.ai_authorrefusal (renderUnparkAIAuthorRefusal). The trust check that loops is the same on v5, where/hive helpshows it (see test).Related issues
Refs #11313
Not superseded by #11711: that PR (096c5c7, merged 10-13) is already in this branch's original 11-10 base, and the loop above ran on top of it. It added label-driven approval; it does not teach the hive a login its identity doesn't name.
Testing
TestSweepIssueUnparkCommandsAnswersOnceWhenPostingAsUnconfiguredLogin:postAuthor) different from the configuredAppLogin; the test runs three sweeps.v5:command 11 answered 3 times over 3 sweeps, want once. Passes with the fix.go test ./pkg/github/... -count=1,go build ./...,go vet ./pkg/github/andgofmtwere clean.v5into the branch (no conflicts):gofmt -landcheck-changelog-fragment.share clean; CI is the verdict for the Go tests.Limits
github.app_slugto the App's real slug avoids it; reading the slug fromGET /appat boot would close it in code.CreateIssueComment(claim ledger, scanner notes, not-agent-work notes) don't teach the login yet. Danathar will follow up with that as a separate v5 PR after this one merges, so this PR's commits stay hanthor's for the squash sign-off check.postUnparkReply,CreateIssueCommentand trust check, so the fix should reach v6 throughv6-topup.Contributor checklist
changelog.d/fixed-unpark-reply-own-login.mdv5Fix and evidence by hanthor; brought up to date with
v5(a merge commit, no conflicts) by Danathar.🤖 Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1