Repository navigation
🐛 Load pinned reviewer rules on keyword-less kicks and open a new review-rules channel without a restart - #19095
Conversation
…iew-rules channel without a restart A kick with no issues or no extractable keywords returned before the knowledge primer ran, so pinned rules never reached it. The scheduler now still calls the primer when it has pinned entries, which returns only those; ranked knowledge still needs keywords. When the review-rules channel does not exist at boot, the primer now registers it by path, opens it on the first kick after the sweep creates it, and connects it to the knowledge API then, so rules captured after boot are primed and listed without a restart. The docs now say so. Fixes #19094 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Mutation testinggremlins found 3 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
ℹ️ 2 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #19094
Follow-up to #19086.
Keyword-less kicks
The scheduler's kick priming returned before the knowledge primer ran when a kick had no issues or no extractable keywords, so pinned reviewer rules never reached those kicks. It now still calls the primer when the primer has pinned entries;
PrimeForKickwith no query returns only the pinned entries whose scope admits the kick. Ranked knowledge is unchanged: it still needs keywords, and a primer with nothing pinned stays silent exactly as before.New channel without a restart
The
review-ruleschannel was connected and pinned only at boot, and only when it or its parent directory existed. On a host without a vaults directory the sweep creates the channel on its first capture, and its rules then waited for a restart. Now boot registers the channel with the primer by path (Primer.AddPinnedDir). The primer opens the directory on the first kick after it appears and calls a hook once, which connects it to the knowledge API so the dashboard lists it too. Boot still never creates a vaults directory the host does not have. The doc now describes this behavior.Tests
qualityagent gets its pinned rule and no ranked fact. The developer agent gets nothing, and a primer with nothing pinned primes nothing.🤖 Generated with Claude Code