Skip to content

πŸ› Customers: style tag chips as pills - #18883

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/customers-chip-style
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/customers-chip-style

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Tag chips on Customers cards used class badge customers-chip; .badge has no CSS, so they rendered as bare 16px text. Adds a tokens-only pill rule for .customers-chip; static/index.html regenerated with make dashboard-gen. Found in the live check of #18742.

Fixes #18882

The chips used class .badge, which no stylesheet defines, so tags rendered as bare text. Style .customers-chip with design tokens. Regenerated static/index.html.

Fixes #18882

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18873 πŸ› needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • PR Type

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Evidence bundle `#1888376564f4` sha256:319f747854af2c286220fcebbe5e27197d019bd08529a17385671a7a6770c0c6 β€” download from the dashboard or `hivectl review evidence #18883`.

merged by Hive trusted-author auto-merge: author clubanderson holds role owner and GitHub permission admin on repo; CI green at 76564f4.

@clubanderson clubanderson changed the title fix(customers): style tag chips as pills πŸ› Customers: style tag chips as pills (#18882) Nov 18, 2026
@clubanderson clubanderson changed the title πŸ› Customers: style tag chips as pills (#18882) πŸ› Customers: style tag chips as pills Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 2df260a into v5 Nov 18, 2026
103 of 104 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/customers-chip-style branch November 18, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customers: tag chips render as unstyled text (class .badge has no CSS)

1 participant