Repository navigation
✨ Customers list: GitHub avatars, tag pills and one-line rows - #18888
Conversation
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Avatars come from github.com for a confirmed GitHub login only, lazy, no referrer, fixed size, initial as fallback; never keyed by email. Tags, identities and origin are pills; rows are one line. customers.avatars.enabled (env HIVE_CUSTOMERS_AVATARS_ENABLED, Settings Features) switches avatars off. Fixes #18885 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
a6e9b51 to
f07e766
Compare
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #18885
Builds on #18817 (row cards, Why is this suggested, Suggested grouping, Add to existing); none of that is undone.
What changed
No new routes, no server-side proxy or cache of avatars.
Tests: customers_ui_test.go (render helpers run under node: avatar attributes, hosts, email-only, off switch, pill order, overflow, manual mark), API list carries the switch, config default/env, Features markup and round trip, CSP pin.
Not verified: live rendering in a browser (no browser run against this build). Light and dark themes and phone width were reasoned from tokens only.