Skip to content

✨ Customers list: GitHub avatars, tag pills and one-line rows - #18888

Merged
kubestellar-prow[bot] merged 4 commits into
v5from
feat/customers-avatars-pills
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 4 commits into
v5from
feat/customers-avatars-pills

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #18885

Builds on #18817 (row cards, Why is this suggested, Suggested grouping, Add to existing); none of that is undone.

What changed

  • Avatars: a person with a confirmed GitHub login shows the GitHub picture (https://github.com/LOGIN.png?size=56) over the initial circle. Lazy, referrerpolicy no-referrer, fixed 28px box (no layout shift), alt text is the name, and the picture hides itself on error so the initial shows. Email-only people, unconfirmed (claimed) logins and Slack, Discord, Teams, Meet get the initial or the existing source icon. Nothing keyed by an email or its hash is requested.
  • Pills: tags use the existing kc-pill shape, tinted with a token tone per default tag (accent, cyan, green, yellow); free-form tags are neutral. Tags set by hand carry a dot, with the setter or rule in the tooltip. Identities are compact monospace pills (first two, then +N with the rest in a tooltip), origin is a short pill (hive user, accepted, added) and the Satisfied pill is unchanged.
  • One line per row at desktop width: avatar, name, me badge, pills, muted date on the right, actions. On phone width the pills wrap under the name and the actions take their own line. Suggested rows and the profile header use the same density; evidence stays behind its disclosure.
  • Privacy and switch: customers.avatars.enabled (default on), env HIVE_CUSTOMERS_AVATARS_ENABLED, Settings, Features, Customer avatars. The list API carries the live value as avatars; the page requires it to be true. Documented in design/customers.md and security-model.md (also operator-reference, env-vars, hive.yaml.example).
  • CSP: img-src already allows https:, so no change; a test pins the exact img-src.

No new routes, no server-side proxy or cache of avatars.

Tests: customers_ui_test.go (render helpers run under node: avatar attributes, hosts, email-only, off switch, pill order, overflow, manual mark), API list carries the switch, config default/env, Features markup and round trip, CSP pin.

Not verified: live rendering in a browser (no browser run against this build). Light and dark themes and phone width were reasoned from tokens only.

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (rest 2/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18868 ✨ Sandbox Jobs: authenticated GitHub reads via a read-only hive relay CONFLICT src/docs/security-model.md
src/hive.yaml.example (conflict)
#18893 🐛 Hold decisions on a PR whose CI or review is still running on its current head same files src/pkg/dashboard/static/index.html
#18881 📖 Sessions: single-owner Codex/OpenCode login docs, invariant test, live-install checklist same files src/docs/security-model.md
#18891 ✨ feature: sandbox node preflight and fail-fast on an unschedulable Job same files src/pkg/dashboard/static/index.html
#18873 🐛 needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row same files src/docs/operator-reference/README.md
src/pkg/dashboard/static/index.html

Avatars come from github.com for a confirmed GitHub login only, lazy, no
referrer, fixed size, initial as fallback; never keyed by email. Tags,
identities and origin are pills; rows are one line. customers.avatars.enabled
(env HIVE_CUSTOMERS_AVATARS_ENABLED, Settings Features) switches avatars off.

Fixes #18885

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the feat/customers-avatars-pills branch from a6e9b51 to f07e766 Compare November 18, 2026 04:24
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 04d4d03 into v5 Nov 18, 2026
100 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/customers-avatars-pills branch November 18, 2026 04:41
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customers list: GitHub avatars, tag pills and one-line rows

1 participant