Repository navigation
π Never auto-close epics or parents a person reopened - #18871
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#18871a194936` sha256:a9f0f22ddeb80bd0a2654e1228b31fd343a08c73f09fc2fa92270067d74846fc β download from the dashboard or `hivectl review evidence #18871`.merged by Hive trusted-author auto-merge: author Review findings from One verified defect: the 30βminute "no reopen" cache can let the sweep reβclose a parent a person reopens right after a hive autoβclose, which is the case this PR exists to stop (#18869). Details are on the line thread. Everything else I read (label/config exemption order, failβclosed on an unreadable timeline, Findings not on a changed line
|
There was a problem hiding this comment.
One verified defect in the reopen guard (inline); the epic/hold/config exemptions read correctly to me.
The negative-verdict cache (decomposed_parents.go:451, :471, :483) is never invalidated when the hive closes the parent. The sequence: the sweep checks the timeline, finds no reopen, caches "no reopen" for 30 min, then closes the parent. If a person reopens it within that window, the next sweep reads the cache and re-closes the parent, which is the case #18869 is meant to prevent. The tests reset the cache and never exercise close followed by reopen inside the TTL.
β hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.326
| parentReopenMu.Lock() | ||
| v, ok := parentReopenCache[key] | ||
| parentReopenMu.Unlock() | ||
| if ok && (v.by != "" || time.Since(v.checked) < parentReopenNegativeTTL) { |
There was a problem hiding this comment.
A cached "no reopen" verdict (by == "") is honoured for 30 min even after this sweep closes the parent. A person who reopens within that window is not seen, and the next cycle re-closes the parent. Fix: drop the cache entry for the key once the close succeeds in closeDecomposedParent, or don't cache a negative verdict when the close proceeds. A test that closes, reopens via the fake timeline and sweeps again would fail without it.
Mutation testing9 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
@joerunde FYI: this is the fix for the hive closing epics (torch-spyre/spyre-inference#756 was closed by the parent auto-close sweep five times, including twice right after a maintainer reopened it and asked it to stop). It is merged to v5 as 8ce72d8. After this, the sweep never closes an issue labelled EPIC or hold and never re-closes a parent a human reopened; repos can switch it off with repos..parent_autoclose: false. It reaches your hive with the next hive build, which I will roll out for you. Until then, keep the sub-issue you added on #756 and please do not close or reopen it again. |
Fixes #18869
repos.<repo>.parent_autoclose: epics_too;falsedisables parent auto-close for the repo; defaulttruekeeps closing plain decomposed parents.Follow-up: dashboard pill 'kept open: reopened by ' not included (needs dashboard row plumbing); decision is logged.
π€ Generated with Claude Code