Skip to content

πŸ› Customers: Inbox-style layout, less noise, no non-people suggested, attach to existing customer - #18817

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
fix/customers-layout-noise
Nov 17, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
fix/customers-layout-noise

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #18816

Layout and noise

  • Customer and suggestion rows are cards (initial or source icon, name as title, muted line, tag chips, grouped actions) that wrap under the content on narrow screens. The panel and its children get min-width: 0, so nothing runs off the right edge. Long keys are cut with an ellipsis and a tooltip.
  • me is a badge; "0 goals" is gone from rows (goals are shown only when there are some; the profile says "No goal yet").
  • Evidence sits under "Why is this suggested?" as readable links (issue and PR numbers link to GitHub, events read "calendar invite"), at most five.
  • Suggested people are grouped by source (GitHub people, Email addresses), five shown with "Show N more", Accept, Add to existing and Dismiss in a fixed-width column.
  • The Suggested group, each "Why" disclosure, group expansion and scroll position survive accept, dismiss, attach, "Same person?" answers and the 60 second refresh; focus moves to the next suggestion.

Content defects

  • Root cause of hive users showing up as suggested GitHub people: the sweep only linked an access-list name as a GitHub login when it carried the github: prefix. A device-flow user is listed as the bare login, so danathar, hanthor and the owner were never linked and were suggested from their issues and PRs. Bare, login-shaped names now link too (security-model.md updated).
  • A suggestion whose identity a customer owns now expires on the sweep (self-heal), so a stale one cannot linger.
  • New deny rule (pkg/customers/address.go, named lists, tested): calendar group and room addresses, googlegroups, no-reply, bounce and service mailboxes, and the hive's own hive@<dashboard host>. Sightings of such addresses are skipped unless a customer owns them, and stored ones expire through the existing suggestion expiry path (counted in expired_suggestions, not tombstoned).

Attach to an existing customer

POST /api/customers/suggestions/{sid}/accept takes an optional {into} (customer id or me). It accepts the suggestion and folds it in with the existing merge, so the identity is a manual one of the target's, no duplicate person is made, and Undo merge reverses it. Full view only (a read-only user cannot see suggestions and keeps the unconfirmed-claim path). Audited as customer_attach with ids only. openapi.json, the API reference and its line citations are updated.

Testing

Added Go tests for the deny rule, expiry, linking, attach, undo, role matrix and audit, and node-run tests of the page helpers (including the group staying open after accept). Per instructions nothing was built or linted locally; the only local run was the dashboard test file for the Customers page helpers (plus go vet on pkg/customers).

πŸ€– Generated with Claude Code

… attach a suggestion to an existing customer (#18816)

Fixes #18816

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18786 πŸ› Claude model dropdown and price table: add Fable 5.2, Fable 5.1, Haiku 5.5 and the fable alias same files src/pkg/dashboard/static/index.html
#18783 ✨ Evidence summary: change failures (reverts, reopened issues) per model same files dashboard/openapi.json
src/pkg/dashboard/static/index.html
#18793 πŸ› Sessions: adopt a Codex or OpenCode login refreshed in a session back into the shared login same files src/docs/security-model.md
#18781 ✨ Spend and contributor run stats by model: add the canonical model name same files dashboard/openapi.json
src/pkg/dashboard/static/index.html
#18780 ✨ Governor PRs by model: what each model's PRs cost the hive to review same files src/pkg/dashboard/static/index.html
#18785 ✨ PRs by model: list one model's pull requests same files src/pkg/dashboard/static/index.html
#18779 ✨ Governor PRs by model: per-repository breakdown and weekly trend same files src/pkg/dashboard/static/index.html
#18782 ✨ Governor PRs by model: split closed-unmerged PRs into superseded, duplicate and other same files src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 2 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/customers/address.go 69 CONDITIONALS_BOUNDARY
src/pkg/customers/service.go 339 CONDITIONALS_BOUNDARY

Verdict: lived (#17349).

@clubanderson clubanderson added kind/bug Categorizes issue or PR as related to a bug. and removed kind/bug Categorizes issue or PR as related to a bug. labels Nov 17, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 08b5186 into v5 Nov 17, 2026
90 of 91 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/customers-layout-noise branch November 17, 2026 20:51
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#18817bb692f9` sha256:74003d1c1e6e6833c676e73a7121d8ede6e02b06c8d3dabf9e63ce950968a958 β€” download from the dashboard or `hivectl review evidence #18817`.

merged by Hive trusted-author auto-merge: author clubanderson holds role owner and GitHub permission admin on repo; CI green at bb692f9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customers section: broken layout, noisy rows, and non-people suggested

1 participant