Repository navigation
π Customers: Inbox-style layout, less noise, no non-people suggested, attach to existing customer - #18817
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 2 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
Verdict: |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#18817bb692f9` sha256:74003d1c1e6e6833c676e73a7121d8ede6e02b06c8d3dabf9e63ce950968a958 β download from the dashboard or `hivectl review evidence #18817`.merged by Hive trusted-author auto-merge: author |
Fixes #18816
Layout and noise
min-width: 0, so nothing runs off the right edge. Long keys are cut with an ellipsis and a tooltip.meis a badge; "0 goals" is gone from rows (goals are shown only when there are some; the profile says "No goal yet").Content defects
github:prefix. A device-flow user is listed as the bare login, so danathar, hanthor and the owner were never linked and were suggested from their issues and PRs. Bare, login-shaped names now link too (security-model.md updated).pkg/customers/address.go, named lists, tested): calendar group and room addresses, googlegroups, no-reply, bounce and service mailboxes, and the hive's ownhive@<dashboard host>. Sightings of such addresses are skipped unless a customer owns them, and stored ones expire through the existing suggestion expiry path (counted inexpired_suggestions, not tombstoned).Attach to an existing customer
POST /api/customers/suggestions/{sid}/accepttakes an optional{into}(customer id orme). It accepts the suggestion and folds it in with the existing merge, so the identity is a manual one of the target's, no duplicate person is made, and Undo merge reverses it. Full view only (a read-only user cannot see suggestions and keeps the unconfirmed-claim path). Audited ascustomer_attachwith ids only. openapi.json, the API reference and its line citations are updated.Testing
Added Go tests for the deny rule, expiry, linking, attach, undo, role matrix and audit, and node-run tests of the page helpers (including the group staying open after accept). Per instructions nothing was built or linted locally; the only local run was the dashboard test file for the Customers page helpers (plus
go vetonpkg/customers).π€ Generated with Claude Code