Repository navigation
✨ Customers: audit activity and "Same person?" hints - #18791
Conversation
PR 6 of RFC #18742. - The sweep reads the dashboard audit log: one acted edge per person per day and a logged_in edge on sign-in days. Only user, day and kind of action are read. An audit edge goes when its day leaves the audit retention. - Hints between a customer and a suggested person when an address starts like a login. Names are never compared. Yes makes the identity theirs, no pins the pair. POST /api/customers/hints/{hid}/answer, audited. - security-model.md: the customers store, people who never signed up, and the github:<login> access-list assumption. Step E (budgeted GitHub search on accept) is not built: the GitHub client has no comment or mention search. Refs #18742 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 2 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
ℹ️ 2 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
PR 6 of the Customers series (RFC #18742). Adds the dashboard audit log as an activity source and the hints a person answers on a profile. Step E is deliberately not here; see the end.
Step D: activity from the audit log
One
actededge per customer per day, and alogged_inedge on days they signed in. The sweep reads only the user, the day and whether the action name is a sign-in; the audit line's detail is never copied (tested with a secret in the detail). An audit edge goes when its day leaves the 90-day audit retention (compliance.BuiltinAuditRetentionDays) and is shown to the full view only, because it says when someone worked."Same person?" hints
Raised between a customer and a suggested person when a suggested address starts like one of the customer's logins (a GitHub login or the dashboard user name), or a suggested login starts like one of the customer's addresses. Exact, lower-cased keys with any
+tagremoved; locals under four characters and role addresses (info,noreply, ...) are skipped; a display name is never compared.A hint links nothing. On the profile, Yes makes the suggested identity the customer's own (recorded manual, by whom, source
same_person_hint) and deletes the suggestion; No pins the pair so it is not asked again. A hint between two customers has no Yes: it is answered by merging, which is PR 8.POST /api/customers/hints/{hid}/answeris full view only, in openapi and the API reference, audited ascustomer_hint_answer.Accepting a suggestion now also closes the hints that named it, so none dangle.
Docs
security-model.mdgains the customers store, the position on people who never signed up, the read-only claim rule, and the one trust assumption in identity linking, stated plainly: agithub:<login>access-list entry is taken as proof of that GitHub login. The hub writes that entry after signing the person in with GitHub, but a hand-edited access list would give the named person's profile the matching GitHub activity.Not built: step E
The budgeted GitHub search for mentions and comments on accept needs a new GitHub client method (the client has no comment or mention search) and a place in the API budget. I did not want to ship that unverified, so it is left for its own PR. Nothing in this PR depends on it.
Also not read by the sweep yet: recordings, the merged ledger, review evidence, contributor profiles and connector fact authors (no accessor reachable from the sweep).
Refs #18742
🤖 Generated with Claude Code