Repository navigation
π stage: the 085 needs-decision comment always names a cause - #18669
Merged
hivecommons-hive[bot] merged 1 commit intoNov 17, 2026
Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons-hive[bot] merged 1 commit into
Conversation
A PR the stage pass held at 085 on the same head was re-parked with a bare route when the lane's own human route came back without a decision: on projectbluefin/fsdk-containers#553 the contributor lane's verdict cache read no verdict while the stage pass held requires_human with the finding "the reviewer marked this change high-risk", and DecisionComment rendered "Needs a decision, not a merge:" over an empty list. - preserveNeedsDecisionOnSameHead's re-park now builds its route from the stage pass's verdict (sameHeadDecisionRoute): the requires_human verdict, the finding, and the question or summaries, in the wording RouteHuman uses (stagelabels.RequiresHumanReasons). - The shared-CI permission park carries its decision cause as the reason. - DecisionComment never renders an empty list: a route with no reasons names DecisionReasonUnnamed ("the reviewer asked for a human decision"), and postHumanEntry logs a warning naming the PR and head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#1866950375dd` sha256:3be6419ef578c087e7908ff6a8f18d506de5fd90f4f0eafdfd2ff78fbb26f086 β download from the dashboard or `hivectl review evidence #18669`.merged by Hive trusted-author auto-merge: author |
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
stage/085-needs-decisioncomment could say "Needs a decision, not a merge:" and then nothing, so nobody could tell what they were being asked to decide. This PR finds the route that produced the empty note and makes it carry the reviewer's reason. It also guarantees the note always names a cause.What happened (projectbluefin/fsdk-containers#553, times Eastern)
At 1:28 PM on 11-16, knuckle (build afb7da6) moved #553 from
072to085and posted comment 6925329114:The hive log shows the cause:
stage labels reconciled β¦ wanted 085-needs-decision, reason contributor-lane:decision-requestedat 1:28:55. One second later,entry comment posted β¦ "reasons": null.0afe7c60had beenrequires_human, withdecision_finding "the reviewer marked this change high-risk", since 1:21 PM.automerge skip β¦ reason contributor-lane:no-verdict.That is the mismatch:
humanEvidence, throughcontributorLaneVerdictFor), and that cache had no verdict for the head. SoRouteHumandid not return an 085 route.preserveNeedsDecisionOnSameHeadre-parked the PR there withstagelabels.Route{Stage: NeedsDecision}and no reasons.DecisionCommentrendered:followed by an empty list.The same bare-route re-park is still on v6 at
automerge_stage_labels.go:1461.The note was never updated:
updated_atequalscreated_at. A note posted with no recorded cause counts as already explained, and the same decision key short-circuits the rewrite.No existing issue covers this. #13137 (closed) was about a note going stale when the cause changes on the same head. #16407 keyed the comment on the decision.
What changed
sameHeadDecisionRoute(obs)builds the re-park's route from the stage pass's own verdict: therequires_humanverdict, the finding, and the question (or, without one, the reviewer's human-facing summaries).Head,Verdict,SelfAuthoredand holds, so the "how to answer" actions match a normal 085 note.stagelabels.RequiresHumanReasonsis the reason block moved out ofrouteProgress, unchanged.RouteHumanand the re-park both use it.automerge_stage_labels.go:1452) now usesdecisionCause(obs.Reason)as its reason, the same prose the human route gives for that reason.DecisionCommentwith no reasons renders "Needs a decision, not a merge: the reviewer asked for a human decision." That is the wordingstage-labels.mdalready shows for this note. One reason and several reasons render exactly as before.postHumanEntrylogs a warning naming the repo, PR, head, lane reason and lane whenever it is about to post or rewrite an 085 note with no reasons, so any other empty route can be found.stage-labels.mdandchangelog.d/fixed-needs-decision-empty-reasons.md.Not included: rewriting notes already posted empty
A note already posted with no reason is not rewritten in place. Detecting it would need a new stage-store field, because such a posting records no cause and the same decision key short-circuits the rewrite. I left that out to keep the store schema unchanged. New notes from this path will name the cause. The existing note on #553 stays as it is until its head changes.
Tests
CI on a draft test PR in my fork (base: a copy of v6 at
3b221dde0):v2 Tests(the full Go suite) andv2 CIpassed, along with 58 other checks: Danathar#2. The only failure there,verify PR contents, is the fork being unable to pull the private verifier image (403). It is not a code result.TestDecisionCommentReasonList(stagelabels): zero reasons render the fallback sentence and never an empty list; one reason is inline; several reasons are a list, exactly as before.TestRequiresHumanReasons(stagelabels): the shared wording, andRouteHumanproducing exactly those reasons for arequires_humanverdict with a finding and a question.TestSameHeadDecisionRouteNamesReviewerFinding(automerge):requires_human, decision requested, finding "the reviewer marked this change high-risk") yields a note listing the verdict and the finding;Locally I ran
gofmt -lonly, as AGENTS.md requires.Out of scope
π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1