Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-18590-betty-spoken-intro-voice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- **Betty answers a spoken "introduce yourself" by voice.** The intro reply did not carry the reply kind, so it went to the meeting chat even when the request was spoken and voice was on; typed intro requests still get a chat reply. ([#18590](https://github.com/hivecommons/hive/issues/18590))
6 changes: 3 additions & 3 deletions src/pkg/meetings/betty/betty_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,11 @@ func TestEngineIntroHelloAndSkip(t *testing.T) {
r := newRig(t, testSettings(), &fakeLLM{})
r.e.Observe(Line{Who: "Ana", Text: "Betty, introduce yourself", Spoken: true})
rep := r.reply()
if rep.Trigger != TriggerIntro || !strings.Contains(rep.Text, "Betty Bee from the hive") || !rep.VoiceWanted || rep.Kind != KindChat {
t.Fatalf("intro %+v", rep)
if rep.Trigger != TriggerIntro || !strings.Contains(rep.Text, "Betty Bee from the hive") || !rep.VoiceWanted || rep.Kind != KindVoice {
t.Fatalf("spoken intro must be answered by voice: %+v", rep)
}
r.e.Observe(Line{Who: "Bo", Text: "who's the bot?"})
if rep := r.reply(); rep.Trigger != TriggerIntro {
if rep := r.reply(); rep.Trigger != TriggerIntro || rep.VoiceWanted || rep.Kind != KindChat {
t.Fatalf("bot question %+v", rep)
}
r.e.Observe(Line{Who: "Bo", Text: "hey betty"})
Expand Down
2 changes: 1 addition & 1 deletion src/pkg/meetings/betty/queue.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func (e *Engine) onLine(l Line) {
}
switch {
case trig.Intro:
e.emit(Reply{Text: e.s.Persona.Intro(), Trigger: TriggerIntro, Question: l.Text, VoiceWanted: trig.VoiceWanted})
e.emit(Reply{Kind: replyKind(trig), Text: e.s.Persona.Intro(), Trigger: TriggerIntro, Question: l.Text, VoiceWanted: trig.VoiceWanted})
case trig.Addressed:
e.addressed(l, trig, now)
case question:
Expand Down
Loading