Skip to content

πŸ› Betty answers a spoken intro by voice - #18591

Merged
kubestellar-prow[bot] merged 1 commit into
v5from
fix/18590-intro-voice
Nov 17, 2026
Merged

kubestellar-prow[bot] merged 1 commit into
v5from
fix/18590-intro-voice

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Finding 3 of the first live meeting pass.

src/pkg/meetings/betty/queue.go built the intro Reply without Kind: replyKind(trig), so a spoken "introduce yourself" was answered in chat even with voice on. The addressed and answer paths already set the kind.

  • Set Kind: replyKind(trig) on the intro reply.
  • TestEngineIntroHelloAndSkip now asserts a spoken intro is KindVoice and a typed one stays KindChat (the old assertion pinned the bug).
  • changelog.d fragment.

Part of #18590

πŸ€– Generated with Claude Code

The intro Reply was built without Kind: replyKind(trig), so it defaulted
to chat even when the line was spoken and voice was wanted. The other
reply paths already set it.

Part of #18590

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 17, 2026
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2026
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18593 ✨ Betty answers questions about the hive from its live state same files src/pkg/meetings/betty/queue.go

@kubestellar-prow
kubestellar-prow Bot merged commit 72616cc into v5 Nov 17, 2026
95 of 101 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/18590-intro-voice branch November 17, 2026 02:23
clubanderson added a commit that referenced this pull request Nov 17, 2026
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure
logging and Discord wording, #18595, #18593, #18599, #18591) alongside
meeting delete. Clears consentTries on delete, adds the delete helpers
to the meetings/calendar role-race test harness (server-tests failed
with meetingsFinished is not defined), and refreshes docs citations.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Betty live test (Google Meet): turn-end delay, slow acks, silent research failures and 5 more

1 participant