Repository navigation
π Betty answers a spoken intro by voice - #18591
Merged
Merged
Conversation
The intro Reply was built without Kind: replyKind(trig), so it defaulted to chat even when the line was spoken and voice was wanted. The other reply paths already set it. Part of #18590 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
clubanderson
added a commit
that referenced
this pull request
Nov 17, 2026
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure logging and Discord wording, #18595, #18593, #18599, #18591) alongside meeting delete. Clears consentTries on delete, adds the delete helpers to the meetings/calendar role-race test harness (server-tests failed with meetingsFinished is not defined), and refreshes docs citations. Signed-off-by: Andy Anderson <andy@clubanderson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding 3 of the first live meeting pass.
src/pkg/meetings/betty/queue.gobuilt the introReplywithoutKind: replyKind(trig), so a spoken "introduce yourself" was answered in chat even with voice on. The addressed and answer paths already set the kind.Kind: replyKind(trig)on the intro reply.TestEngineIntroHelloAndSkipnow asserts a spoken intro isKindVoiceand a typed one staysKindChat(the old assertion pinned the bug).Part of #18590
π€ Generated with Claude Code