Skip to content

πŸ› Inbox: fact is a status, not a button; machine transcripts become knowledge - #18390

Merged
kubestellar-prow[bot] merged 2 commits into
v5from
fix/inbox-fact-indicator
Nov 16, 2026
Merged

kubestellar-prow[bot] merged 2 commits into
v5from
fix/inbox-fact-indicator

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

What

The "πŸ“š Fact" control is gone from the Inbox action row. It looked like an action but did one thing: inboxOpenFact(slug, layer) jumped to Knowledge and opened the item's fact (kbReadFact). It said nothing about what that fact holds. Now:

  • A non-interactive status pill (kc-pill, role="status", no hover or pointer) sits next to the "Machine transcript (…)" pill. It reads Pending text (metadata only), In knowledge (machine text), or In knowledge (the source's own text). An item that is listed live and has no fact yet shows no pill. It comes from a new fact_state field on the item.
  • The one real function, opening the fact, is kept as a plain open in Knowledge link in the item's metadata line, not as a button.

Machine transcripts now reach Knowledge. Before this change, a whisper, Gemini or Deepgram transcript was stored only under connector-state/transcripts/<source>/<id>.json. Only the Inbox read it, through the Content() fallback. The Knowledge fact stayed in its pending shape (title, date, duration, highlights and the pending note), so knowledge search, nous and agents never saw the words. Now:

  • When a run finishes, writeMachineFact (src/pkg/inbox/factwriteback.go) rewrites the item's fact:
    • It sets attr_<x>_content: machine, attr_transcript_provider: <provider>/<model>, attr_transcript_language and attr_transcribed_at.
    • It replaces the pending note with a ## Transcript (machine: …) section ahead of the highlights. The section is fenced in the untrusted-inbox-data envelope (WrapUntrusted).
    • All source attrs, metadata bullets, highlights and provenance stay.
  • A transcript that finished before the fact existed, including ones made before this fix, is written the next time the Inbox is listed.
  • FactWriter.Write will not overwrite a machine fact with a page that is still pending. So the next sync never resets it to pending.
  • Plaud and meeting refetch keep re-reading machine facts. Upstream text replaces the machine transcript once it exists (ready).
  • The Inbox still shows the stored transcript, unwrapped and under its machine label.

Tests

  • src/pkg/inbox/factwriteback_test.go:
    • an audio-only fact before transcription is pending;
    • finishing a transcription writes the machine fact (label, provider, envelope, highlights kept, pending note gone) and the item reads as machine;
    • the backfill works when the fact appears later;
    • upstream text is never overwritten.
  • dashboard/test/inbox-item.test.js: the row has no Fact button, the metadata link opens the fact, and the pill shows each state.
  • src/pkg/knowledge/connector/fact_content_test.go:
    • the real Plaud sync renders the documented audio-only pending shape;
    • the next sync keeps a machine fact while upstream is still empty;
    • machine facts are refetched;
    • upstream text replaces the machine fact;
    • an archived page still tombstones it.

Docs

  • New "What knowledge an Inbox item becomes" section in src/docs/inbox-voice-sources.md: audio-only (pending, with an example fact), after machine transcription, and after upstream transcription.
  • "Upstream text wins" in src/docs/inbox-transcription.md is updated.
  • Changelog fragment changelog.d/fixed-inbox-fact-indicator.md.
  • static/index.html is regenerated.

Coordination

πŸ€– Generated with Claude Code

…nowledge

Remove the πŸ“š Fact button from the Inbox action row. What the item's
Knowledge fact holds is now a non-interactive status pill (Pending text,
In knowledge (machine text), In knowledge), and opening the fact is a
plain link in the metadata line.

A finished machine transcription is now written into the item's fact,
fenced as untrusted data and marked attr_<x>_content: machine with
attr_transcript_provider, keeping source attrs, metadata and highlights.
Connector syncs that still find no upstream text leave a machine fact
alone; Plaud and meeting refetch keep re-reading machine facts so the
source's own text replaces it when it arrives.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18389 🌱 Inbox: one Share menu with a Hive group (RFC, spek, Knowledge, DIBS) CONFLICT dashboard/test/inbox-item.test.js
src/docs/inbox-voice-sources.md
src/pkg/dashboard/static-src/js/inbox.js (conflict)
src/pkg/dashboard/static/index.html (conflict)

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • server-tests

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 10 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/inbox/factwriteback.go 87 CONDITIONALS_BOUNDARY
src/pkg/inbox/factwriteback.go 100 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 120 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 160 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 167 CONDITIONALS_BOUNDARY
src/pkg/inbox/factwriteback.go 215 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 218 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 224 CONDITIONALS_NEGATION
src/pkg/inbox/transcription.go 281 CONDITIONALS_NEGATION
src/pkg/inbox/transcription.go 431 CONDITIONALS_NEGATION

18 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/inbox/factwriteback.go 34 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 34 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 35 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 35 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 101 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 101 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 170 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 170 ARITHMETIC_BASE
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_BOUNDARY
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_BOUNDARY
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_BOUNDARY
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_BOUNDARY
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 195 CONDITIONALS_NEGATION
src/pkg/inbox/factwriteback.go 199 CONDITIONALS_NEGATION

Verdict: lived (#17349).

…t the pill

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 3d6b2e5 into v5 Nov 16, 2026
92 of 95 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/inbox-fact-indicator branch November 16, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant