Repository navigation
🌱 Inbox: one Share menu with a Hive group (RFC, spek, Knowledge, DIBS) - #18389
Conversation
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
There was a problem hiding this comment.
The new test TestInboxShareMenuBehaviour fails in CI on this head, and it looks like a harness problem rather than a menu bug.
CI (test (dashboard 4/4) and shuffle 3/3, run 43861186030) fails at src/pkg/dashboard/inbox_share_menu_test.go:56: the actual groups are link:copy but the test expects link:copy,native. The Share… entry is gated by typeof navigator !== 'undefined' && !!navigator.share (inbox.js, inboxShareLinkActions). The test sets navigator = { share: () => {} } at line 54 after declaring var navigator = {} at line 32. Under the Node versions CI uses, that assignment does not seem to take effect, because navigator is a built-in global; the later navigator = {} (line 61) passes only by coincidence. I have not run it, so this is the likely cause, not a confirmed one. Suggested fix: stub it with Object.defineProperty(globalThis, 'navigator', { value, configurable: true, writable: true }), or read it through an injectable accessor.
Other points, read from the diff and the tree:
- The row, menu, role gating (owner-only Hive group), bulk menu and docs match the PR body. I found no mismatch between the body and the code.
server-tests,runtime-testsandcoveragealso fail. I did not look at those logs, so I can't say whether they are related.
— hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.325
|
Scanner triage: baseline check says the failures are PR-local ( 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
d8c9b8c to
496ec7c
Compare
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
496ec7c to
2c2dc23
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The Inbox item row is now only
▶ Play recording,Transcriptand🔗 Share ▾. The old→ dibs…,→ RFC…andKnowledge onlyrow buttons are gone; their actions live in the Share menu.Menu (role="menu", labelled groups, arrow keys, Esc closes and returns focus; reuses the existing
ham-menustyles and tokens):POST /api/inbox/routewithdestination: dibs; disabled with a Settings → Inbox → dibs URL hint when not configured).navigator.shareexists).inboxShareHiveActionsis an ordered list of{id, label, enabled(item, role), run(item)}; the spek session PR adds one entry there instead of a row button. Routed-state pills are unchanged.Hive (n) ▾menu built from entries that definebulk().Backend unchanged. Still referencing dibs: this menu, auto-routing rules,
inbox.dibs.*config and the Settings URL field.Tests:
inbox_share_menu_test.go(node) covers the three-control row, group order, role gating, disabled reasons, handlers and the registration point. Docs, changelog andstatic/index.htmlupdated.🤖 Generated with Claude Code