Skip to content

🌱 Inbox: one Share menu with a Hive group (RFC, spek, Knowledge, DIBS) - #18389

Merged
kubestellar-prow[bot] merged 4 commits into
v5from
chore/inbox-remove-dibs-button
Nov 16, 2026
Merged

kubestellar-prow[bot] merged 4 commits into
v5from
chore/inbox-remove-dibs-button

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

The Inbox item row is now only ▶ Play recording, Transcript and 🔗 Share ▾. The old → dibs…, → RFC… and Knowledge only row buttons are gone; their actions live in the Share menu.

Menu (role="menu", labelled groups, arrow keys, Esc closes and returns focus; reuses the existing ham-menu styles and tokens):

  • Hive (owners only): RFC… (existing dialog; disabled with the Transcribe hint when there is no text, or when no RFC repo is set), Knowledge (Back to inbox on a kept item), DIBS (existing confirm dialog and POST /api/inbox/route with destination: dibs; disabled with a Settings → Inbox → dibs URL hint when not configured).
  • Link: Copy link, Share… (only when navigator.share exists).
  • Read and read-write viewers only get the Link group, since the route and dismiss APIs are owner-only.
  • Registration point: inboxShareHiveActions is an ordered list of {id, label, enabled(item, role), run(item)}; the spek session PR adds one entry there instead of a row button. Routed-state pills are unchanged.
  • Multi-select bar: the Knowledge button became a Hive (n) ▾ menu built from entries that define bulk().

Backend unchanged. Still referencing dibs: this menu, auto-routing rules, inbox.dibs.* config and the Settings URL field.

Tests: inbox_share_menu_test.go (node) covers the three-control row, group order, role gating, disabled reasons, handlers and the registration point. Docs, changelog and static/index.html updated.

🤖 Generated with Claude Code

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2026
@clubanderson clubanderson changed the title 🌱 Inbox: remove the → dibs… item action 🌱 Inbox: one Share menu with a Hive group (RFC, spek, Knowledge, DIBS) Nov 16, 2026
@kubestellar-prow kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test TestInboxShareMenuBehaviour fails in CI on this head, and it looks like a harness problem rather than a menu bug.

CI (test (dashboard 4/4) and shuffle 3/3, run 43861186030) fails at src/pkg/dashboard/inbox_share_menu_test.go:56: the actual groups are link:copy but the test expects link:copy,native. The Share… entry is gated by typeof navigator !== 'undefined' && !!navigator.share (inbox.js, inboxShareLinkActions). The test sets navigator = { share: () => {} } at line 54 after declaring var navigator = {} at line 32. Under the Node versions CI uses, that assignment does not seem to take effect, because navigator is a built-in global; the later navigator = {} (line 61) passes only by coincidence. I have not run it, so this is the likely cause, not a confirmed one. Suggested fix: stub it with Object.defineProperty(globalThis, 'navigator', { value, configurable: true, writable: true }), or read it through an injectable accessor.

Other points, read from the diff and the tree:

  • The row, menu, role gating (owner-only Hive group), bulk menu and docs match the PR body. I found no mismatch between the body and the code.
  • server-tests, runtime-tests and coverage also fail. I did not look at those logs, so I can't say whether they are related.

— hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.325

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Scanner triage: baseline check says the failures are PR-local (FIX_DIFF), not shared CI. The PR removes the dibs action, but tests still assert the old markup: dashboard/test/inbox-item.test.js:60 ("inboxOpenRoute action kept", plus the Plaud pending-item and File RFC route-state cases) and TestInboxShareMenuBehaviour in src/pkg/dashboard/inbox_share_menu_test.go. Suggested fix: update those assertions to the new markup (drop the inboxOpenRoute expectation), then push. I'm not pushing to this branch since it isn't hive-authored.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18399 ✨ meetings: Calendar section, scheduled joins and approvals (Betty C1) CONFLICT src/docs/dashboard-sections.md
src/pkg/dashboard/static-src/js/sections.js (conflict)
src/pkg/dashboard/static/index.html (conflict)

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 16, 2026
@clubanderson
clubanderson force-pushed the chore/inbox-remove-dibs-button branch from d8c9b8c to 496ec7c Compare November 16, 2026 12:14
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 16, 2026
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the chore/inbox-remove-dibs-button branch from 496ec7c to 2c2dc23 Compare November 16, 2026 12:26
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 16, 2026
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit e91df2b into v5 Nov 16, 2026
90 of 92 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the chore/inbox-remove-dibs-button branch November 16, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant