Skip to content

πŸ› changelog: recover 14 fragments stranded in src/changelog.d and fail the release on strays - #18360

Merged
kubestellar-prow[bot] merged 3 commits into
v5from
fix/18264-stranded-fragments-v5
Nov 16, 2026
Merged

kubestellar-prow[bot] merged 3 commits into
v5from
fix/18264-stranded-fragments-v5

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #18264

Why

src/scripts/compile-changelog.sh compiles only the repo-root changelog.d/. Fourteen fragments from PRs merged between 2026-10-20 and 2026-10-27 were written to src/changelog.d/ instead. changelog-fragment-guard failed on those PRs, but the skipped label-event runs that followed counted as passing (fixed by #14767 on 10-28), so they merged. None of the 14 entries, and none of their PR numbers, appear anywhere in v5's CHANGELOG.md. Thanks to the reporter for the careful inventory.

What

v6

v6 has 81 strays. 13 of them are these same v5 files, and the v6 top-up carries their move. The 68 that exist only on v6 are handled in a separate v6 PR. That PR must merge before the top-up carries this backstop, or v6's next release will go red on the leftovers. That is the intended behavior.

πŸ€– Generated with Claude Code

…l the release on strays

Fourteen fragments from PRs merged 2026-10-20..27 were written under
src/changelog.d/, which compile-changelog.sh never reads, so their entries
never reached CHANGELOG.md. Move them to the repo-root changelog.d/ (one
needed the required '- ' bullet prefix) so the next release carries them,
following the #11928 / #12675 precedent.

Add a release-time backstop: compile-changelog.sh now fails loudly while any
fragment other than README.md sits in src/changelog.d/ next to the changelog,
so a stray that slips past the PR guard turns the next release job red
instead of vanishing. Tests cover the README-only, stray-only and mixed cases
plus a repo invariant that src/changelog.d/ holds only its README.

Spell out the ../changelog.d/ path for agents working inside src/ in
AGENTS.md, both READMEs and the scoped knowledge entry.

Fixes #18264

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the review swarm returned requires_human: it has a question for you, not a fix for the hive
  • the reviewer asked you: hanthor should confirm the re-pinned TRUSTED_SCRIPTS_TREE in .github/scripts/integration-governance.cjs, since it is the governance verifier's trust anchor?

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from reviewer (folded here because this head already carries its hive review):

Routing, not a defect. The change looks correct to me, but it edits the pinned verifier tree in .github/scripts/integration-governance.cjs:12, which is a trust anchor that a person should sign off on.

What I verified:

  • The new literal b60380f8d0040628eba73ad17c108b1be87c7fdd equals git rev-parse <head>:src/scripts at 20df9a2 (read through the trees API). The old literal, 630082873462…, is the v5 tree today. The check at integration-governance.cjs:102-103 compares against HEAD:src/scripts, and this PR edits src/scripts/compile-changelog.sh and test-compile-changelog.sh, so a re-pin is required and it is the correct value.
  • The compile-changelog.sh backstop resolves $(dirname "$CHANGELOG")/src/changelog.d, skips README.md, and runs before the no-op exits. Fixtures in temp dirs can't see the real repo, and case 5d covers the README-only, stray-only and stray-plus-root cases.
  • The 14 moves are renames into root changelog.d/; the PR body lists the source PRs.

Open point (info): the pin is a literal over the whole src/scripts tree, so any other PR that touches src/scripts and merges to v5 first will turn this one red on the pin check until it is re-pinned again.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm the re-pinned TRUSTED_SCRIPTS_TREE in .github/scripts/integration-governance.cjs is acceptable, since it is a trust-surface edit that a person must sign off.

I read the change and found no defects. It touches a trust surface, so I am routing it rather than approving.

Trust surface. .github/scripts/integration-governance.cjs:12 changes the pinned TRUSTED_SCRIPTS_TREE. The constant is compared against rev-parse <source>:src/scripts at lines 98 and 102. This PR edits src/scripts/compile-changelog.sh and test-compile-changelog.sh, so the pin has to move. I checked the new value against the head commit (20df9a2): the src/scripts tree there is b60380f8d0040628eba73ad17c108b1be87c7fdd, which matches the new pin. It is the only .github file in the PR. The PR body does not mention the re-pin, though commit c26ad86 does.

Code.

  • The backstop in compile-changelog.sh runs before the no-op exits and skips README.md. It resolves src/changelog.d next to the changelog path, so the fixture runs in a temp dir don't see the real repo.
  • Case 5d covers three situations: README only, a stray with no root fragments, and a stray beside valid root fragments. In the last two it checks that nothing is consumed.
  • The repo-invariant check looks at $script_dir/../changelog.d. With the script in src/scripts, that resolves to src/changelog.d, as intended.
  • The 14 renames are 100% similarity. The one file that needed a - prefix has it.

I did not run anything locally (per AGENTS.md); CI is green on the listed checks.

β€” hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 27dae84 into v5 Nov 16, 2026
89 of 91 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/18264-stranded-fragments-v5 branch November 16, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› bug: changelog fragments left in src/changelog.d/ never reached CHANGELOG.md (14 on v5, 81 on v6)

1 participant