Skip to content

🐛 bug: changelog fragments left in src/changelog.d/ never reached CHANGELOG.md (14 on v5, 81 on v6) #18264

Closed

Description

@Itx-Psycho0

What happened?

while setting up the repo i noticed some changelog fragments are still under src/changelog.d/ instead of changelog.d/ at the repo root. compile-changelog.sh only reads the root folder, so these entries never got into CHANGELOG.md.

on v5 there are 14 of them, and none of their PRs show up in CHANGELOG.md:

on v6 there are 81, and 77 of them are not in v6's CHANGELOG.md.

there is also a leftover changed-gate-fold-tap-target.md at the repo root from #17515. its entry is already in CHANGELOG.md under v5.211.11, so that file can just be removed.

Expected behavior

every merged fragment ends up in CHANGELOG.md, and nothing is left in src/changelog.d/ except its README.

Reproduction steps

  1. git fetch origin
  2. git ls-tree -r origin/v5 --name-only | grep '^src/changelog.d/[a-z]*-'
  3. pick any PR number from the list above and search CHANGELOG.md for it. it is not there.

Environment

  • Branch/version: v5 at 22708bb, v6 at 15ad6de7fc
  • Deployment method: not deployment related, repo contents only
  • Operating system or Kubernetes version: n/a
  • Relevant configuration (redact secrets): n/a

Logs or screenshots

on #14580, #13805 and #14322 the changelog-fragment-guard check shows FAILURE, followed by several SKIPPED runs from label events.

Additional context

all of these were added between oct 20 and oct 27. the guard did fail on those PRs, but github counted the later skipped label runs as passing. #14767 fixed that on oct 28, so new ones should be blocked now and only the cleanup is left. the earlier cleanups (#11928, #12675) ran before these were added.

one question before i send a PR: for releases that already shipped, should i move the fragments into changelog.d/ so the next release picks them up, or add them to CHANGELOG.md under the versions where they actually went out? i can do v5 first and v6 in a separate PR, or whatever you prefer.

Activity

  1. github-actions commented on Nov 15, 2026

    @github-actions
    Contributor

    Welcome to the Hive Commons community!

    Thanks for opening your first issue here! Every issue helps make the project better.

    To work on this issue, comment /assign to assign yourself (use /unassign to remove).

    Find issues to work on: look for the good first issue and help wanted labels.

    Hope you have a great time here!

    For Maintainers: /good-first-issue | /help-wanted

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 15, 2026
  3. Itx-Psycho0 commented on Nov 15, 2026

    @Itx-Psycho0
    Author

    /assign

  4. added
    needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
    on Nov 15, 2026
  5. hivecommons-hive commented on Nov 15, 2026

    @hivecommons-hive
    Contributor

    Thanks — this hive only works issues from OWNER, MEMBER, COLLABORATOR automatically. A maintainer can admit this one by adding the label triage/accepted (configured in issue_filter.reporter_trust.untrusted_require_labels). Until then the hive will not claim, label, or open PRs for it. See https://github.com/hivecommons/hive/blob/HEAD/GOVERNANCE.md#reporter-trust-and-escalation for what these terms mean and how to become a trusted reporter.

  6. added
    stage/015-triage-neededActionable but no maintainer has looked at it yet (hive-filed, or awaiting the triage label)
    on Nov 15, 2026
  7. clubanderson commented on Nov 16, 2026

    @clubanderson
    Member

    Triage: confirmed. Thanks for the careful inventory, your counts are exact.

    Evidence (v5 at 42bc2ba, v6 at 97b0461)

    On your question: the repo precedent (#11928, #12675) is to move strays into the root changelog.d/ so the next release carries them, not to backfill sections that already shipped. Both PRs below follow that.

    Fix

    Sorry for jumping ahead of your offered PR; this one was tied to release tooling. Reviews on either PR are very welcome.

  8. added
    triage/acceptedIndicates an issue or PR is ready to be actively worked on.
    and removed
    needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
    on Nov 16, 2026
  9. added and removed
    stage/015-triage-neededActionable but no maintainer has looked at it yet (hive-filed, or awaiting the triage label)
    on Nov 16, 2026
  10. hivecommons-hive commented on Nov 16, 2026

    @hivecommons-hive
    Contributor

    Fixed by #18361 (merged 0cd0a4f). Closing. Reply /reopen if the problem persists.

  11. github-actions commented on Nov 16, 2026

    @github-actions
    Contributor

    @Itx-Psycho0 this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

  12. added a commit that references this issue on Nov 16, 2026
    27dae84
  13. clubanderson commented on Nov 16, 2026

    @clubanderson
    Member

    Fixed by #18360 (v5, merged) and #18361 (v6, merged). v5's 14 strays and v6's 64 v6-only strays now sit in the root changelog.d/, so the next releases carry them. 4 v6 strays were dropped because their entries were already recorded. The remaining 13 shared files reach v6 through the next top-up, which should drop changelog.d/fixed-adopted-pr-rebase.md on v6 (already in v6.0.0). From now on, compile-changelog.sh fails the release while any fragment sits under src/changelog.d/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinghelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions