Repository navigation
π claude auth: share refreshed logins across per-agent .claude homes without sharing memory - #17767
Conversation
β¦without sharing memory Since the per-agent CLI homes landed, each per-UID agent has a real ~/.claude directory with only .credentials.json symlinked to the shared login at /data/home/.claude/.credentials.json. Claude Code refreshes its token by writing a temp file in ~/.claude and renaming it over .credentials.json, then chmod 0600. The rename replaces the symlink with a private, agent-owned file. bridgeHomeEntry refuses to clobber a regular file, so nothing ever re-links it; the refreshed access token and the rotated refresh grant stay in that agent's private file, the shared credential ages out, and the rest of the fleet logs out every ~8h (Discord report by Danathar, 2026-11-11). Andy's direction: keep per-agent memory isolated, make an exception for the login only. So no opt-in whole-directory sharing. Instead the hive repairs the bridge in-process: - repairClaudeCredentialBridge: when the agent's credential path is a regular file, read it (directly, or as its owner through the existing su-exec seam when the server cannot open an agent's 0600 file β the per-UID case), move it aside as .credentials.json.stale-<ts>, promote it into the shared login only if it is complete, usable and expires later than the shared token (a failed refresh's empty-token file never wins; ties keep shared), preserving the previous shared file, then restore the symlink. Legacy whole-directory ~/.claude symlinks and unreadable private files are left untouched, with a once-per-version log. - Triggered at agent launch (setupPerAgentCLIHome), every 5s from the credential watchdog (HIVE_CLAUDE_CREDENTIAL_BRIDGE_INTERVAL) so a refresh is fleet-visible before siblings try the rotated grant, and right after a dashboard sign-in (ReloadClaudeToken). - Audited as claude_credential_rebridged (no token material). - claude.ReadTokens/ParseTokens/TokensUsable split out of LoadTokens so "cannot open" is distinguishable from "no token". Tests reproduce the CLI's tmp+rename+chmod and show the shared file did not update before the fix and does after; cover newer-shared, failed refresh, su-exec owner read, unreadable fail-safe, legacy layout, stale name collisions, watchdog cycle and sign-in trigger. Refs #17039, #17253, #17678, #17752, #17753 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Security perspective (read head e9904be, plus 1. (in-scope, low) Live refresh grants accumulate on disk with no bound. Every repair leaves func moveAsideClaudeCredential(path string, now time.Time) (string, error) {
+ pruneClaudeStaleCredentials(path, claudeBridgeStaleKeep) // delete all but the newest N path.stale-* siblings
dst, err := claudeBridgeStaleName(path, now, func(dst string) (bool, error) {2. (out-of-scope, low β mirrors pre-existing Trust note, not a finding: the "newest Review findings from Intent alignment (read at e9904be): the diff does what the body says β detect-at-launch (
Open question (not verified, not a finding): the 5s cadence assumes sibling Claude Code processes re-read Review findings from Correctness re-review (delta e9904be β dbf9abf) β no blocker found; two advisory notes.
Previous style finding (manager_tokens.go 976 > 970 baseline): fixed β file is 970 lines at this head. Review findings from The red check has a concrete cause. What I verified in the tree (
Why I am routing rather than confirming. This changes how credentials move between uids: the hive server (dev) now reads an agent-owned 0600 OAuth refresh grant through I have not approved or requested changes; this is a comment. Review findings from Read the bridge against the v5 tree. The mechanism (Lstat β same-file guard β read-as-owner β move aside β judge the snapshot β promote-if-newer β relink) does what the description says, and the fail-safe branches at 1. CI failure is the 2. Stale credential archives are never pruned (medium). Every repair writes the agent's private file to Scope note for the maintainer, not a finding: beyond the bridge, this PR also hardens every |
Move the sign-in re-bridge body into claude_credential_bridge.go and defer it from ReloadClaudeToken (LIFO: after the Unlock). Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Mutation testingβ gremlins did not produce a report for 1 package(s), so no verdict can be derived from this run (see the job log):
Verdict: |
There was a problem hiding this comment.
Style/conventions review of e9904be (read the diff plus claude_session_adopt.go, manager.go, interactive_home.go, credentials_watchdog.go at head). No blocker; two maintainability notes with fixes, worst first.
1. readClaudeCredentialAsOwner duplicates the existing su-exec read seam β src/crux/agent/claude_credential_bridge.go (the readClaudeCredentialAsOwner func, ~L224β243) is line-for-line readClaudeSessionForAdoption + readClaudeSessionAsOwner in src/crux/agent/claude_session_adopt.go L109β147 (ReadFile β fs.ErrPermission β claudeSessionOwnerSpec β runAsAgentUser(spec, nil, "cat", path) β post-read size cap). Both callers (repairClaudeCredentialBridge) are already *Manager methods, so the method form is available. Two copies of a privilege-sensitive helper means the next hardening (cap, timeout, spec rule) has to land twice.
- if _, rerr := readClaudeCredentialAsOwner(link); rerr != nil {
+ if _, rerr := m.readClaudeSessionForAdoption(link); rerr != nil {
...
- agentData, rerr := readClaudeCredentialAsOwner(staleAgent)
+ agentData, rerr := m.readClaudeSessionForAdoption(staleAgent)and delete readClaudeCredentialAsOwner (keep its doc comment on a short alias or move the "fails closed on symlinks/root/oversized" sentence onto the call site if you want it visible here).
2. Package-level mutable state where the package keeps it on Manager β claudeBridgeMu, claudeBridgeLegacyWarned and claudeBridgeUnreadableWarned are package globals (claude_credential_bridge.go, the var blocks around L100β150). The existing idiom for exactly this "log once per agent" pattern is a Manager field: appNotInstalledWarned sync.Map in src/crux/agent/manager.go L601 and cliMemory.warnOnce used by warnSharedCLIMemoryOnce in interactive_home.go L452β463. Globals also mean the once-warned marks and the repair mutex are shared across every Manager built in the test binary, so test order can suppress a warning another test asserts on. Suggest moving all three onto Manager (claudeBridgeMu sync.Mutex; claudeBridgeLegacyWarned, claudeBridgeUnreadableWarned sync.Map) β the lock-ordering comment ("never held while taking m.mu") carries over unchanged.
Advisory, no action needed: StartCredentialWatchdog now calls RepairClaudeCredentialBridges from both the 5 s bridgeTicker case and the 5 min ticker case (credentials_watchdog.go hunk @@ -207). The comment explains the intent; with a 5 s poll the second call is at most 5 s fresher, so if you want one code path you could drop it, but it is harmless.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Review follow-ups (below
|
β¦t non-regular files Shared logins and CLI configs written by the hive (.claude/.credentials.json, .copilot/config.json, the durable Copilot token) now go through a new crux/sharedfile package: a randomly named temporary beside the target, mode and owner set and verified on the open descriptor, rename, directory fsync, and the write is refused unless the target is absent or a regular file in a regular directory the server owns. Credential promotion writes a canonical re-encoding of the parsed token block and checks the moved-aside source is the same regular file before and after. Parity with the v6 fail-safe behaviour: an unreadable private credential is left in place except on a dashboard sign-in with a usable shared login, the refusal is logged once per file version, WriteCredentials refuses a credential without an access token, and ReadTokens treats malformed JSON as nothing usable. entrypoint.sh: the shared dot-dirs get the sticky bit (not under HIVE_SHARED_AGENT_HOME=1); the single-file repairs act only on a regular file in a regular directory and WARN once otherwise; the remaining root chmod/chown sites under agent-writable directories gained the same checks. The Go permissions watcher keeps setgid/sticky when widening a directory's group bits. Shell tests drive the shipped guard functions with non-regular entries. Refs #17039, #17253, #17678, #17748 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
dbf9abf
βΉοΈ Sentinel notice β informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
There was a problem hiding this comment.
Intent-alignment delta review (e9904be β dbf9abf). Prior style finding (manager_tokens.go over the 970-line ratchet) is fixed β the file is 970 lines at this head. Verdict for the whole PR from this perspective: approve, with two advisory notes.
-
PR body no longer matches the repair's fail-safe contract. Body "Mechanism" Β§2 says the repair will "never move a file whose token cannot be read". At this head
repairClaudeCredentialBridge(src/crux/agent/claude_credential_bridge.go:323-325) moves an unreadable private file aside unread whentrigger == claudeBridgeTriggerSignInand the shared file is usable (relinkUnreadableAfterSignIn, :441-452). The callers ofReloadClaudeTokenI checked (src/pkg/dashboard/claude_auth.go:184,218,src/crux/serve/families.go:656) are login/logout only, so "newer by construction" holds today and the file is kept as.stale-*, so this is a documentation gap, not a defect. Β§5's "tmp + chmod 0660 + chown-like-target + rename" is nowsharedfile.Replace(claude_credential_bridge.go:469-486). Suggested body edit for Β§2: "β¦never move a file whose token cannot be read β except on the sign-in trigger, where the dashboard has just written a newer shared login; the unreadable private copy is then moved aside unread (kept as.stale-*) and the agent relinked." -
Scope widened beyond Claude auth. The changelog fragment now covers the
sharedfilepackage and sticky-bit/permission-guard hardening, which is fine and coupled to the promotion write. But severalsrc/deploy/entrypoint.shhunks in this delta are unrelated to the Claude login:.bashrc/.profilesymlink guards (:1975-2004),/data/beads/<agent>and/data/agents/<agent>chmod guards (:2101-2104), andhive_shared_dir_sticky /data/home/.gemini /data/home/.bob(:1570). Not blocking on a human PR with a documented changelog, but a reviewer bisecting a later Gemini/Bob or shell-rc regression will not look at a PR titled "claude auth". Consider splitting those into a follow-up, or at minimum naming them in the PR body.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦ a polling sleep Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm that any agent uid in the node group may have its private Claude token promoted into the fleet-wide /data/home/.claude/.credentials.json (mode 0660), i.e. that one agent's refreshed login intentionally becomes every agent's login on the node.
Routing, not objecting: this PR changes how Claude OAuth credentials are stored and shared across agent uids, which is a trust surface the hive does not sign off on alone. I read the new primitive and the bridge against v5 and found no defect; the facts a maintainer needs are below.
What the change does (verified in the tree at 9db16bc)
- Each agent's
~/.claude/.credentials.jsonbecomes a symlink to one shared file,/data/home/.claude/.credentials.json(src/crux/agent/claude_credential_bridge.go:129-142), written at mode0o660(:92) so every agent uid reaches it through thenodegroup. This is the same modeclaude.WriteCredentialsalready used for the dashboard sign-in, so group readability is not new; what is new is that a per-agent private copy can be promoted into the shared file when it is newer and usable (preferAgentClaudeCredential,:226;promoteClaudeCredential,:466-490). The replaced shared file is preserved as.stale-<timestamp>beside it. - Because the shared file is already group-writable, an agent process could overwrite it directly today; the promotion path adds a sanctioned route rather than a new capability. Whether that fleet-wide sharing of one login is the intended trust model is the decision above.
Primitive β src/crux/sharedfile/sharedfile.go: Replace refuses world-writable or foreign-owned parent dirs and non-regular targets (:49-77), creates the temp with O_EXCL|O_NOFOLLOW at 0600 (:84), re-verifies mode, Nlink == 1 and owner on the open descriptor after fsync (:113-128), re-checks the location before rename (Replace, second checkLocation), and rename replaces the directory entry without following a symlink swapped in between. ReadNoFollow caps at 64 KiB and rejects symlinks via ELOOP (:171-199). I could not find a TOCTOU window that yields a write through an attacker-placed symlink.
Entrypoint β src/deploy/entrypoint.sh: every new chmod/chown is gated on ! [ -L ] for both the directory and the file, uses chown -h, and the sticky bit is added to /data/home, /data/home/.claude, /data/home/.copilot, .gemini, .bob. hive_fix_shared_file refuses and warns once per path when the target is not a regular file in a regular directory. test_entrypoint_perm_guard.sh covers the refusal path.
I have not read the 853-line bridge test file or oauth.go line by line; the above covers the write path, the read path and the privilege boundary.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦omes and harden shared-home permission handling (#17807) Top-up of #17767 (v5 squash 0cf675d) onto v6, merged into the credential bridge v6 already carries from #17253/#17590: - keeps v6's dashboard surface (credentialBridgeBroken, resume after sign-in) and the legacy-dir-link rules; - brings the sharedfile-based promotion, owner read through su-exec, newest-expiresAt rule, 5s bridge cadence (HIVE_CLAUDE_CREDENTIAL_BRIDGE_INTERVAL), and the fail-safe handling of an unreadable private file (left in place except on sign-in); - hardens the shared-home permission guard and credential promotion against non-regular files (entrypoint guard, sticky shared dot-dirs, crux/sharedfile writer for the Claude login and Copilot config); - a dashboard sign-in still recovers a shared credential path that is a dangling or self-referencing link (#17590), by unlinking it first. Supersedes #17678 and #17748. (cherry picked from commit 0cf675d) Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π agents: Copilot CLI ET_EXEC binary fails with ENOEXEC on kernel 6.12 β exec via ld.so + startup preflight (#17737)
Fixes #17729. Refs #17642.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π release: v5.221.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.221.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* fix: warn once per agent about user identity in agent gitconfig (#17742)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π fix: name ENOEXEC instead of dumping binary stderr in model discovery error (#17756)
* π fix: name ENOEXEC instead of dumping binary stderr in model discovery error
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π fix: import unicode/utf8 and keep ANSI-coloured stderr out of the ENOEXEC check
cli_models.go used utf8.ValidString without importing unicode/utf8, so the
dashboard package failed to build. isBinaryStderr also treated ESC (0x1b) as
a binary control byte, so coloured stderr would have been mislabelled as an
ENOEXEC dump; ESC is now allowed alongside the whitespace controls, with a
regression test.
Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* β¨ crux: Substrate as the 4th sandbox runtime (opt-in, preflight-gated) (#17741)
* β¨ crux: Substrate as the 4th sandbox runtime (opt-in, preflight-gated)
Add Agent Substrate (CNCF Sandbox) as sandbox.runtime: substrate behind
the existing sandbox.Launcher seam, mirroring the OpenShell runtime
(ADR-0026 phase 2).
- crux/sandbox/substrate*.go: SubstrateLauncher (ActorTemplate + Actor
per kick, atenet-egress policy derived from the proxy host set +
allow_hosts, workspace push/run/pull through an in-actor bridge over
the atenet-router mTLS CONNECT tunnel, snapshot_on_idle suspends
instead of deleting), real gRPC client constructed lazily, Control
API preflight registered into crux/config.
- crux/sandbox/substrateapi: trimmed, wire-compatible proto subset of
ate.control.v1 generated in-repo (no go.ate.dev/substrate import:
it requires Go 1.27 and is very large). Zero new Go modules.
- crux/sandbox/substratebridge: the HTTP bridge served inside the actor.
- crux/config/agent_config_substrate.go: sandbox.substrate.* leaves with
per-agent merge; pkg/config gate warnings (digest-pinned image).
- Settings parity allowlist entries for the new leaves (#17699).
Fixes #17697
Part of #17695
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* changelog: fragment for #17741
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π± changelog: make the substrate fragment an entry bullet
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± changelog: drop the auto-generated duplicate fragment
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± substrateapi: drop a never-true nil comparison flagged by staticcheck
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* π docs: ADR-0026 phase 2 β Agent Substrate runtime operator and deploy notes (#17745)
* π docs: ADR-0026 phase 2 β Agent Substrate runtime operator and deploy notes
Amend ADR-0026 with the Substrate implementation notes (contract mapping,
deviations from the reference model, cluster prerequisites and which hive
clusters qualify, when to choose it over OpenShell); add the operator
section to sandbox-isolation.md, the integrations table row, deploy/README
pointer and a new deploy/substrate.md with install and verification steps.
Part of #17695
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* changelog: fragment for #17745
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π± changelog: make the substrate docs fragment an entry bullet
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± changelog: drop the auto-generated duplicate fragment
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π docs: fix the ADR-0002 link in the Substrate section
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* π release: v5.221.1
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.221.1 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* fix: stop read-only lanes retrying hive:unauthorized label removal (#17743)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: reconcile and expire effect-ledger ops stuck in Unknown (#17746)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π fix: guard nil config in stageEngineOptions before reading WorkflowsDir (#17765)
stageEngineOptions dereferenced cfg.Data.WorkflowsDir as an argument before any nil check. Because stageEngine is a package-level sync.Once, the panic only fired when a nil-config caller was first in the process, making it order-dependent. Build the workflow store only when cfg != nil.
Closes #17736
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π Skip archived repositories during GFI curation (#17739)
* Fix GFI curation for archived repositories
Hive-Run: hivecommons/hive#17734
Hive-Plan: archived-repository GFI recovery
Hive-Spec: good-first-issue#archived-repositories
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
* fix: correct changelog fragment category
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
---------
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.222.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.222.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π marketplace: resume CNCF catalogue seeding across hub restarts and let spokes trigger refresh (#17773)
* π marketplace: resume CNCF catalogue seeding across hub restarts and let spokes trigger refresh
Root cause of the one-entry catalogue on hive.hivecommons.dev: GitHub
tarballs lead with a pax_global_header entry, which Go's tar reader
surfaces as a header. ExtractTarGz counted it as a second top-level name,
returned dest instead of the wrapped "<owner>-<repo>-<sha>/" directory,
and ingest.ReadTree then saw every path with the wrapper prefix β no
GitHub Actions workflow matched. Only tektoncd/pipeline got through, via
the content-based Tekton sniff. Skip pax headers when extracting.
Seeding is now resumable: at startup the hub ingests every corpus repo
that is due (no record, record older than 24h or in an older format,
error older than 1h) instead of only when the catalogue is empty, so a
restart mid-seed continues and a flapping hub does not re-crawl fresh
repos. Records carry a format version; bumping it (format 2 for the
tarball fix) re-ingests everything on the next boot. The last run summary
is persisted so status.lastRefresh survives restarts; status gains
pendingRepos/lastRefreshErrors and ?verbose=1 (spoke or admin) lists the
failing repos with their errors.
POST /api/marketplace/refresh accepts the same credentials as publish
(hub admin session or spoke heartbeat bearer + X-Hive-ID); spokes are
rate-limited (one full run/hour, 10 ?repo= runs/min β 429 + Retry-After),
admins are not. The spoke proxy passes 429/409 through with the hub's
message. The crawl sleeps on 403/429 Retry-After (secondary limits) and
logs progress every 25 repos.
Refs hivecommons/hive#17620
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π marketplace: update refresh tooltip in static-src and regenerate index.html
Refs hivecommons/hive#17620
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: bound consecutive stale-snapshot drops in the status builder (#17744)
* fix: bound consecutive stale-snapshot drops in the status builder
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π docs: update staleDropStarvationThreshold comment for bounded publish
The constant's doc comment still described the pre-PR contract (drop
logged at Warn). It now marks the point where the build is published
anyway to bound staleness.
Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π docs: resync api-reference citations after server.go route shift
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π fix: log Prow ok-to-test rejection at WARN only when first noted (#17754)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* β¨ crux: Substrate preflight prover (operator, CRDs, gVisor RuntimeClass, feature gates) (#17766)
* β¨ crux: Substrate preflight prover (operator, CRDs, gVisor RuntimeClass, feature gates)
Extends the sandbox.runtime: substrate preflight with the cluster facts
behind a failing kick: operator CRDs and workloads, ready WorkerPools and
their sandbox classes, gVisor (SandboxConfig or runsc RuntimeClass) and
KVM availability, node kernels, the certificates.k8s.io APIs behind the
PodCertificateRequest and ClusterTrustBundle feature gates, and an mTLS
CONNECT probe of atenet-router. Skipped outside a cluster; one warning
when RBAC is missing, with a manifest that grants it.
Fixes #17698
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* fix(crux/sandbox): egress policy atespace + in-place workspace clear found by #17697 kick
The first real kick through Substrate v1.0.0 (kind, gVisor) surfaced two
defects in the launcher path: CreateActorEgressPolicy was rejected with
'egress_policy.metadata.atespace: Required value', and the bridge's PUT
/workspace failed with EBUSY because os.RemoveAll targeted the durableDir
mount point itself. Set the atespace on the singleton policy and clear the
workspace directory's contents in place.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* test(crux/sandbox): run the kube/router preflight halves only in a Pod wired for Substrate
CI runs in Pods, so /var/run/secrets/kubernetes.io/serviceaccount/token
exists there and the kube/router halves of the prover ran during the
Control-API-only tests (crux/sandbox and crux/agent). The prover now
requires both the Kubernetes token and hive's projected Substrate token
(opts.token_file, /var/run/secrets/ate/token by default) before probing the
cluster; the Kubernetes token path is a package variable the sandbox test
package pins to a nonexistent file, with a helper that flips both markers on
for the tests covering the in-cluster branches.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: openshell sandbox names and driver_config fit gateway 0.1.8 limits (#17780)
Prototype on LKE (#17643) hit four gateway rejections before a kick ran:
sandbox names over MAX_ROUTABLE_NAME_LEN (19), the reserved 'workspace'
volume name, default-denied pod labels/annotations, and the missing Agent
Sandbox prerequisite. Names are now hk-<slug>-<base36 unix> (fnv tag when
the slug does not fit), the claim mounts as hive-workspace, and the deploy
doc records the operator settings the measurements depended on
(allowed_pod_labels, workspaceStorageClass, sandboxUid, auth modes) plus
the landlock-in-LSM preflight lesson and the measured numbers.
Refs #17643, #17642
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π release: v5.222.1
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.222.1 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π marketplace: stream repository tarballs and keep only pipeline files (#17793)
The marketplace fetcher extracted each default-branch tarball to disk via
complexity.ExtractTarGz under a 256 MiB whole-tree cap, so large monorepos
(kubernetes/kubernetes, kserve/kserve, meshery/meshery, shipwright-io/build,
spidernet-io/spiderpool) failed with "archive exceeds size cap" and never
reached the catalogue. ingest.ReadTarball now streams the archive and keeps
only the paths ReadTree would select (shared selectTreeFile), 1 MiB per
file and 32 MiB in total, discarding everything else without buffering;
the complexity cap is untouched for its own callers.
GET /api/marketplace/status now includes failing:[{repo,error,checkedAt}]
without ?verbose=1 (repo names and fetch errors carry no secrets), so an
operator with a plain PAT can see why repos fail. Four corpus entries that
GitHub now redirects are updated to their current names.
Refs hivecommons/hive#17620
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: redact proxy userinfo in upstreamproxy URL errors (#17731)
* π fix: redact proxy userinfo in upstreamproxy URL errors
parseProxyURL formatted the raw proxy URL into its rejection errors, and
configureUpstreamProxy logs that error, so a malformed URL carrying the
proxy's Basic credential put the password in the hive JSON log on every
boot. logscrub's basic-auth category covers Authorization headers only,
not URL userinfo, so nothing downstream masked it. Use url.Redacted() on
the parsed form, strip the userinfo segment when url.Parse itself fails,
and drop the *url.Error wrapper whose message repeats the full URL.
Fixes #17730
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* chore: re-key merge request after transient lint-pending refusal
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* β¨ benchmarks: per-PR estimated cost in /api/benchmarks/export (#17791)
Records now carry cost.basis (tokens_x_pricing | unknown), cost.usd_est,
token share, launches and price_table_date, attributed from the spoke's
launch-cost collector: the swarm's PR ref for reviewer records, the
governor's issue ref of an issue the PR closed for author records (both
ref spellings). Vendored benchmarks schema refreshed; converter and
dashboard lookup tests; docs cost section.
Fixes #17790
Refs #17694
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π release: v5.223.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.223.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* β¨ marketplace: seed curated models and ship the CNCF TechDocs assessment workflow (#17798)
Curated marketplace tier gets a source of truth in the binary:
pkg/hub/marketplace/curated/*.yaml is embedded, strictly decoded, checked
for the curated invariants (provenance curated, a version, nothing left
inferred), compiled through bundle.Export and published at tier curated
on hub startup and at the start of every refresh run when that
name@version is absent. Bad files are logged and skipped, never fatal;
edits without a version bump are refused as conflicts, so a new version
is a new file. Seeded keys are reported in lastRefresh.curated.
The first curated model is cncf-techdocs-assessment@curated-2026.11.1:
Nate W.'s AI-assisted TechDocs assessment process (spec at
nate-double-u/cncf-techdocs@882be6f, intake template @ad91530), scoped to
cncf/techdocs. Issues travel requested β accepted β draft-open (β
escalated) β closed/declined; deliverable PRs travel drafting β in-review
β stakeholder-review β awaiting-merge β merged with checks-failing and
discarded branches. Every gate (/accept, /decline, /verify, /ready,
/confirm, /approve, /discard, /abort) is released by a human role; the
drafter and verifier agents stop at gates. Checks are the repo's
format/link/spell-check workflows plus the manual provenance block. The
rules evaluator is exercised over hand-written Facts for each step.
cncf/techdocs is not a landscape project, so the corpus package gains an
operator-added extra.json merged into Repos(); the ingested-unreviewed
version now sits next to the curated one.
Docs: marketplace section of docs/design/workflow-models.md (curated
seeding, where a model goes, how versions work) and
docs/workflows/techdocs-assessment.md for the TechDocs team.
Refs hivecommons/hive#17620
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: classify repeated agent-lifecycle log lines instead of filing unclassified selfreports (#17757)
* π fix: classify repeated agent-lifecycle log lines instead of filing unclassified selfreports
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* test: expect agent_lifecycle_repeated class for non-held kick failures
TestPostRestartKickHoldLogsWithoutFleetReport asserted the generic
unclassified class; 'failed to send kick' is now classified as
agent_lifecycle_repeated. Held kicks still produce no observation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π fix(marketplace): refuse and downgrade model-provenance curated claims from non-admin bundles (#17764)
* π fix(marketplace): refuse and downgrade model-provenance curated claims from non-admin bundles
The hub checked only the envelope Tier when deciding whether a publisher may
assert curated/built-in; the model's own spec.meta.provenance is hash-covered
and stored verbatim. Spoke import preferred the model's provenance over the
envelope tier, so a registered spoke could publish a bundle every importer
badged as curated. The hub now refuses such bundles from non-admins (it
cannot rewrite the hash-covered model) and importers honour a vouched model
provenance only when the envelope asserts the same tier.
Fixes #17763
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* fix(marketplace): express importedProvenance as an if so the mutation gate sees its coverage
Go's cover tool does not instrument the case expressions of a tagless
switch, only the case bodies, so gremlins reported the three conditionals
on the switch as NOT COVERED even though TestImportedProvenance exercises
every branch. Fold the switch into a single if with identical semantics;
if conditions sit inside the preceding coverage block and are attributed
correctly.
No behaviour change: empty provenance still takes the envelope tier, and a
curated/built-in claim the envelope does not assert still falls back to it.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π fix: hub digest reads a stale stage-tracker body instead of blocking on a rebuild (#17785)
* π fix: let the hub activity digest read a stale stage-tracker body instead of blocking on a rebuild
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π§ͺ test: wait for the hub digest rebuild with testutil.Eventually instead of a sleep loop
TestSleepRatchet failed on CI (196 time.Sleep calls in tests, baseline 195):
the new stale-read test polled stageTrackerBuild with a hand-rolled
time.Sleep loop. Use testutil.Eventually, which is the helper the ratchet
points to.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π fix: log issue-claims GitHub side-effect retries below WARN (#17786)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π fix: detect orphaned queued workflow runs in automerge held-run resolution (#17787)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* β¨ dashboard: surface agent_sandbox.substrate and per-agent sandbox.substrate settings (#17788)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π claude auth: share refreshed logins across per-agent .claude homes without sharing memory (#17767)
* π claude auth: share refreshed logins across per-agent .claude homes without sharing memory
Since the per-agent CLI homes landed, each per-UID agent has a real
~/.claude directory with only .credentials.json symlinked to the shared
login at /data/home/.claude/.credentials.json. Claude Code refreshes its
token by writing a temp file in ~/.claude and renaming it over
.credentials.json, then chmod 0600. The rename replaces the symlink with
a private, agent-owned file. bridgeHomeEntry refuses to clobber a regular
file, so nothing ever re-links it; the refreshed access token and the
rotated refresh grant stay in that agent's private file, the shared
credential ages out, and the rest of the fleet logs out every ~8h
(Discord report by Danathar, 2026-11-11).
Andy's direction: keep per-agent memory isolated, make an exception for
the login only. So no opt-in whole-directory sharing. Instead the hive
repairs the bridge in-process:
- repairClaudeCredentialBridge: when the agent's credential path is a
regular file, read it (directly, or as its owner through the existing
su-exec seam when the server cannot open an agent's 0600 file β the
per-UID case), move it aside as .credentials.json.stale-<ts>, promote
it into the shared login only if it is complete, usable and expires
later than the shared token (a failed refresh's empty-token file never
wins; ties keep shared), preserving the previous shared file, then
restore the symlink. Legacy whole-directory ~/.claude symlinks and
unreadable private files are left untouched, with a once-per-version
log.
- Triggered at agent launch (setupPerAgentCLIHome), every 5s from the
credential watchdog (HIVE_CLAUDE_CREDENTIAL_BRIDGE_INTERVAL) so a
refresh is fleet-visible before siblings try the rotated grant, and
right after a dashboard sign-in (ReloadClaudeToken).
- Audited as claude_credential_rebridged (no token material).
- claude.ReadTokens/ParseTokens/TokensUsable split out of LoadTokens so
"cannot open" is distinguishable from "no token".
Tests reproduce the CLI's tmp+rename+chmod and show the shared file did
not update before the fix and does after; cover newer-shared, failed
refresh, su-exec owner read, unreadable fail-safe, legacy layout, stale
name collisions, watchdog cycle and sign-in trigger.
Refs hivecommons/hive#17039, hivecommons/hive#17253,
hivecommons/hive#17678, hivecommons/hive#17752, hivecommons/hive#17753
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± keep manager_tokens.go at its file-size ratchet baseline
Move the sign-in re-bridge body into claude_credential_bridge.go and
defer it from ReloadClaudeToken (LIFO: after the Unlock).
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π harden shared-home permission guard and credential promotion against non-regular files
Shared logins and CLI configs written by the hive (.claude/.credentials.json,
.copilot/config.json, the durable Copilot token) now go through a new
crux/sharedfile package: a randomly named temporary beside the target, mode
and owner set and verified on the open descriptor, rename, directory fsync,
and the write is refused unless the target is absent or a regular file in a
regular directory the server owns. Credential promotion writes a canonical
re-encoding of the parsed token block and checks the moved-aside source is the
same regular file before and after.
Parity with the v6 fail-safe behaviour: an unreadable private credential is
left in place except on a dashboard sign-in with a usable shared login, the
refusal is logged once per file version, WriteCredentials refuses a credential
without an access token, and ReadTokens treats malformed JSON as nothing
usable.
entrypoint.sh: the shared dot-dirs get the sticky bit (not under
HIVE_SHARED_AGENT_HOME=1); the single-file repairs act only on a regular file
in a regular directory and WARN once otherwise; the remaining root chmod/chown
sites under agent-writable directories gained the same checks. The Go
permissions watcher keeps setgid/sticky when widening a directory's group
bits. Shell tests drive the shipped guard functions with non-regular entries.
Refs hivecommons/hive#17039, hivecommons/hive#17253, hivecommons/hive#17678, hivecommons/hive#17748
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± wait for the watchdog re-bridge with testutil.Eventually instead of a polling sleep
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π release: v5.224.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.224.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* β¨ hub: per-cluster host_aliases for hosted hives (#17805)
* β¨ hub: per-cluster host_aliases for hosted hives
Adds ClusterConfig.host_aliases ([{ip, hostnames[]}]) to /data/saas/clusters.json,
validated at load (IP parses, hostnames non-empty, lowercased; invalid blocks are
dropped with a warning, never the cluster). Rendered as Pod hostAliases in the
hosted-hive Deployment template next to the upstream_proxy env injection, and a
throttled, rate-limited reconcile sweep (3 patches / 15 min) converges existing
hives while preserving unrelated hand-applied aliases.
Needed for GHE hosts reachable only through a TLS reverse proxy on a fixed IP
(no CONNECT proxy), where upstream_proxy cannot apply.
Fixes #17801
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π api-reference: resync hub-server.go citations after host_aliases field
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: count PR author's own sign-off after a hive rebase; no decision gate on DCO asks (#17795)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* β¨ dashboard: render Substrate preflight warnings on the agent card (#17796)
* β¨ feat: render Substrate preflight warnings on the agent card
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π test: seed proc.Config so sandbox-warnings status test matches the builder's input
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π fix: dedupe repeated undelivered review kick warning (#17755)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π fix: cache app_keys_held key fingerprints so heartbeat collect stays in budget (#17806)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.225.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.225.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π fix(marketplace): restrict spoke-triggered ?repo= refresh to tracked repositories (#17800)
* π fix(marketplace): restrict spoke-triggered ?repo= refresh to tracked repositories
A registered spoke could pass any owner/name to POST /api/marketplace/refresh
and the hub would fetch it with its own GitHub identity and publish the
ingested model under the hub's name. Non-admin callers must now name a corpus
or HIVE_HUB_MARKETPLACE_EXTRA_REPOS entry; admins are unchanged.
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π± chore: refresh head to re-report required checks
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.226.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.226.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π substratebridge: refuse tar entries that write through symlinks on Unpack (#17813)
* π substrate: unpack pulled workspaces through os.Root so tar symlinks cannot escape
Fixes #17769
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* chore: re-trigger required checks after base moved
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* β¨ dashboard: show substrate kicks and stream bridge output in the terminal pane (#17809)
* β¨ dashboard: show substrate kicks and stream bridge output in the terminal pane
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π substratebridge: create the workspace dir before the streaming run test
newBridgeServer intentionally leaves the workspace path uncreated so the
PUT/GET workspace tests can exercise the missing-directory paths, but
TestHandlerStreamsRunOutput ran a command in it and failed with
chdir: no such file or directory before any frame was streamed.
Hive-Fix-Attempt: 1/6
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π substrate kicks: stream only transitions after the viewer connected; cover new sandbox paths
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π Mark hive's in-cluster k8s API dials so the egress redirect never MITMs them (#17818)
* π Mark hive's in-cluster k8s API dials so the egress redirect never MITMs them
On nodes without the xt_owner netfilter module (IBM Cloud IKS/ROKS) the
HIVE_PROXY chain has only the packet-mark self-exemption, so every :443
dial the hive makes for itself must carry SO_MARK. The proxy's upstream
dials did; the spoke's own Kubernetes API clients (self-upgrade, startup
probe, node metrics, ingress probes, kubejob) did not, so they were
REDIRECTed into the MITM proxy, hit the private-range forward guard and
got EOF β every wec2 hive failed self-upgrade with
'reading startup probe before upgrade β¦ EOF'.
Move the SO_MARK dialer into a new crux/egressmark package (crux/proxy
imports crux/agent which imports kubejob, so kubejob cannot import
proxy) and use it for all five in-cluster API transports.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± Allow crux/egressmark in the dashboard import ratchet
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± Add crux/egressmark tests for the coverage gate
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π hub: stop flagging off-cadence and scheduled agents as idle-with-work (#17825)
classifyInactiveAgent ignored AgentSummary.ExpectedActive, so an agent with
no cadence in the governor's current mode (e.g. redteam while quiet) was
alerted as idle whenever the hive had queued work. Spokes also reported
KickIntervalSec=0 for times/cron cadences, dropping the hub to the 45m rule
between slots. Skip the idle rule when the spoke says the agent is not
expected active, and report the gap from the last fired slot to the next
as the kick interval for scheduled cadences.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: use unique temp files when persisting hive and reach state (#17740)
* fix: use unique temp files when persisting hive and reach state
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π± chore: re-run PR verifier after cancelled concurrent run
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π± chore: refresh head to clear a Copilot PR Automation run stuck in queued
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π hub heartbeat: back off and classify a permanent 403 rejection (#17823)
* π hub heartbeat: back off and classify a permanent 403 rejection instead of retrying every tick
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π± fleetreport: add threshold case for hub_heartbeat_rejected_unprovisioned
TestEveryRuntimeClassTriggerAndNonTriggerThresholds requires every class in
Classes to have a trigger/non-trigger case; the new class was missing one.
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.227.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.227.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* β¨ knowledge: Plaud voice notes as a knowledge source (#17821)
* β¨ knowledge: Plaud voice notes as a knowledge source
Add a plaud knowledge connector that reads Plaud Note recordings (Plaud
summary + transcript) through the free official Plaud MCP server over
stdio, with a minimal JSON-RPC MCP client, Connect/Disconnect sign-in on
the Knowledge Integrations card, docs and tests.
Fixes #17820
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± knowledge/plaud: port dashboard edits to static-src, document auth routes in openapi.json, drop unused field
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π hive: do not gate the dashboard bind on the advisory-issue ensure (#17829)
* π hive: do not gate the dashboard bind on the advisory-issue ensure
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π hive: add missing time import in boot_github_deps_test
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π release: v5.227.1
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.227.1 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π substrate: garbage-collect older suspended kick actors when snapshot_on_idle is on (#17830)
* π substrate: garbage-collect older suspended kick actors when snapshot_on_idle is on
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π substrate: scope superseded-actor GC to the atespace it was created in and log via slog
Review follow-up for #17830:
- lastSuspended records {Name, Atespace}; the delete uses the stored
atespace and is skipped (with a warning) when the agent's atespace
changed between kicks, instead of targeting a name never created there.
- Replace stdlib log.Printf with an injected *slog.Logger on
SubstrateOptions (slog.Default() fallback), wired from the agent
manager, with agent/actor/atespace/error attrs.
- Document the one-snapshot-per-agent retention rule in
sandbox-isolation.md, ADR 0026 and the dashboard snapshot_on_idle help.
Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π hub: converge startupProbe and init image onto existing hosted deployments (#17831)
* π hub: converge startupProbe and init image onto existing hosted deployments
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* docs: resync hub-server api-reference citations after server.go field insertion
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π release: v5.228.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.228.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π hub: negatively cache rejected bearer tokens; stop re-probing exhausted user quota (#17837)
validateGitHubToken re-hit GET /user with the caller's own token on every
request once the token was rejected or rate-limited, charging the owner's
exhausted core bucket and prolonging the 401 outage. Remember 401/403/429
for 60 s (or until X-RateLimit-Reset, capped at 15 min), record the probe in
REST accounting under the pass-through caller agent:hub-bearer-validate, and
route hub release-notes contents reads through the shared ETag/accounting
transport. Document the fleet-wide operator steps for getting personal
tokens out of cluster secrets (ARC runner scale set -> GitHub App auth).
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π crux serve: count auth-rejected requests in crux.serve.auth.rejections (#17839)
instrument sits inside authenticate, so requests refused with a 401 never reached crux.serve.requests or crux.serve.request.duration. Wrapping authenticate with instrument would label them with the unmatched route, so a separate counter, crux.serve.auth.rejections, is incremented in each 401 branch of authenticate. Its only attribute is a fixed-enum reason (missing_or_invalid_token, project_forbidden, no_token_configured); never a token, path or remote address.
Closes hivecommons/crux#146
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.228.1
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.228.1 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* fix(hub): bound bearer token validation cache (#17846)
Sweep expired entries at capacity and skip new entries when all slots remain occupied. Apply the same limit to accepted and rejected tokens.
Hive-Run: hivecommons/hive#17844
Hive-Plan: issue-17844-cap-and-expired-sweep
Hive-Spec: issue-17844#recommendation
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
* π release: v5.228.2
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.228.2 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π knowledge: start the Plaud MCP server with an allowlisted env, not the hive process env (#17845)
stdioMCPDialer passed os.Environ() to a third-party MCP server fetched at
run time (npx -y @plaud-ai/mcp@latest), so every hub-injected credential
the hive process carries β DASHBOARD_AUTH_TOKEN (server-verified owner on
the dashboard API), HIVE_TERMINAL_KEY, HIVE_HEARTBEAT_KEY, HIVE_HUB_SECRET,
HIVE_UPSTREAM_PROXY_URL (proxy Basic credential), GitHub/Linear/provider
keys β reached code the hive does not control. crux/agent strips the same
set from agent panes (#17657); the MCP dialer bypassed that.
The child now gets an allowlist: PATH, HOME, locale, TMPDIR, TERM, the
proxy and CA-bundle variables Node needs to reach the registry through the
egress proxy, NODE_*/npm_config_*/NPM_CONFIG_* and PLAUD_*. Any name that
contains TOKEN, SECRET, PASSWORD or CREDENTIAL is dropped even when it
matches a prefix.
Fixes #17843
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.228.3
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.228.3 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π release: v5.228.4
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.228.4 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π± images: bump omp 18.18.0 -> 18.19.0 (#17850)
Automated pin bump (#8419). Digests recomputed from the downloaded
release artifacts by src/scripts/cli-pin-bump.sh:
VERSION=18.19.0
SHA256_AMD64=b44fda2ae5c9cce2bbe124d1672cba532a136d9e1eef68599b16efcd3bc5c626
SHA256_ARM64=61826bf89c2c0512417fee05fa2f486e60ee11b23ea95a17257a6c49edb6b8d5
Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: hive-release[bot] <hive-release@hive.kubestellar.io>
* π army: stop attributing adopted PRs to a remote agent's rework queue and show why a fix is not dispatched (#17853)
The contribute fleet card listed every stage-store record by author in 072
or 074 as the relay's pending rework, so merged/closed PRs still carrying
stage/074-adopted-by-hive (the store prunes them only after 14 days) and
PRs the hive had taken over piled up as '33 PRs awaiting rework'. Only open,
not-adopted, not-dispatched PRs count now: the forge cache decides open vs
merged/closed when it knows the PR, otherwise a record the stage lane has
not re-observed for an hour is treated as gone. A queued fix whose PR is
gone leaves the fix queue instead of being handed to the relay.
The idle-with-queue stall: a fix dispatched to a socket that dropped stays
booked in flight with nobody holding it, so capacity 1 is busy forever and
the relay gets neither the fix nor new work (task_unavailable
fix_pr_in_flight, which the card hid behind 'idle Β· N awaiting rework').
The relay's next ready now releases such orphans (no attempt counted) and a
task_complete for the dispatch on a reconnected socket settles it. The card
prints the dispatcher's actual reason (pending_rework_blocked) instead of
'not yet dispatched', and links at most three PRs inline with the rest
behind a show-N-more disclosure.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: detect missing GitHub App repository coverage (#17733)
* fix: detect missing GitHub App repository coverage
Hive-Run: hivecommons/hive#17696
Hive-Plan: repository access and advisory recovery
Hive-Spec: issue-17696#expected
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
* fix: add App repository coverage changelog
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
* fix: bound boot coverage and probe large installations
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
* docs: clarify GitHub App coverage polling
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
---------
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.228.5
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.228.5 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* β¨ knowledge: Wispr Flow dictation history as a knowledge source (#17855)
* β¨ knowledge: Wispr Flow dictation history as a knowledge source
Adds knowledge.connectors[].type: wisprflow. Reads the desktop app's local
flow.sqlite read-only through the sqlite3 CLI (text columns only, never the
audio/screenshot BLOBs) or a folder of exported .json/.ndjson/.csv/.md
files, and emits one fact per finalised dictation (or per day) with the
dictation time, source app and URL. Incremental by timestamp with a 2h
overlap; min_words and apps filters; tags.
Dashboard: Knowledge -> Integrations card (path, status, last sync, count),
Add-source entry pointing out that new dictations need no connector at all
(dictate into + New Fact). Docs section next to Plaud's; changelog fragment.
Fixes #17854
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π knowledge: wisprflow tests run without the sqlite3 CLI
Sync tests now use a fake sqlite3 runner fed from testdata/wisprflow/history.json
so the SQLite path is exercised (and counted for coverage) on runners without
the CLI; the real-CLI test skips when sqlite3 is absent. TestWisprValidate
passes an explicit path so it no longer depends on a macOS default location.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix(agent): replace unopenable pluk session log so the supervisor can create it (#17889)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π release: v5.228.6
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.228.6 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* β¨ workflows: owner toggle for model-based stage derivation from the dashboard (#17886)
* β¨ workflows: owner toggle for model-based stage derivation from the dashboard
workflow.enabled gates rules-based stage derivation and bound-model label
provisioning, but could only be set by editing hive.yaml, which hosted
hives cannot do. Add PUT /api/workflows/enabled {enabled} (owner-gated,
persists hive.yaml, audited workflow_enabled / workflow_disabled) and a
"Derive stages from bound models" switch in Settings β Workflows β Library
that confirms before turning on. The stage engine and the tracker already
read cfg.Workflow.Enabled live and the reloader mutates the same *Config
in place, so no reload hook is needed. Turning on also provisions every
bound repository's model labels at once through the sweep's memoised
ensureStageLabels path (new automerge.Engine.EnsureStageLabels, wired as
Dependencies.WorkflowProvisionLabels); failures come back as warnings and
the next sweep retries. The Repos binding row says "columns only β turn
on derivation in Workflows" when a binding exists while the flag is off.
Refs hivecommons/hive#17620
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* chore: move changelog fragment to root changelog.d/
Refs hivecommons/hive#17620
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π release: v5.229.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.229.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* fix: classify plain HTTP proxy forwarding failures (#17864)
Hive-Run: hivecommons/hive#17859
Hive-Plan: classify repeated proxy forward failures
Hive-Spec: fleet-report#runtime-classes
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* β¨ Inbox: voice recorders as first-class input sources (Plaud β spek RFC / dibs / knowledge) (#17885)
* β¨ Inbox: voice recorders as first-class input sources
Add a source-agnostic Inbox (sidebar β Intelligence) that lists recordings
synced by voice knowledge connectors (plaud now, wisprflow next), keyed by
(source, item_id), and routes each one inside the hive to a spektacular RFC
with child issues (spektacular voice --publish, or a spoke-agent fallback),
a dibs draft idea, or Knowledge only β single, bulk, or by auto-routing
rules applied after every sync.
- pkg/inbox: Item/RouteState model, JSON store, fact-backed source,
rules, spek_rfc + dibs destinations, service with sweep.
- config: inbox.{sources,rules,spek,dibs} + validation.
- dashboard: GET /api/inbox, POST /api/inbox/{route,dismiss},
GET|POST /api/inbox/settings, Inbox section + modals, sidebar badge.
- Plaud: POST /api/knowledge/connectors/{name}/auth/complete paste
fallback for hosted hives (Plaud OAuth only redirects to localhost:8199);
the Integrations card now shows connection state + Open Inbox only.
- docs: inbox-voice-sources.md, knowledge-connectors.md, api-reference,
dashboard-sections, openapi.json.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* β¨ Inbox: default spek_rfc agent fallback to first enabled agent
When the hive image has no spektacular binary and inbox.spek.agent is
unset, hand the RFC job to the alphabetically first enabled, unpaused
agent so candidate hives can file RFCs without extra config.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± Inbox: allowlist pkg/inbox dashboard import; sidebar order test includes inbox-section
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± Inbox: cover service/store/source edge cases and inbox config validation
Raises pkg/inbox to 92% and pkg/config back over the 90% coverage floor.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π release: v5.230.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.230.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π PR comments: overlap/mutation only on a finding, thank first-time contributors only, no self-/lgtm relay on Prow PRs (#17870)
* π PR comments: post overlap/mutation reports only on a finding, thank first-time contributors only, no self-/lgtm relay on Prow PRs
Fixes #17863.
- .github/scripts/pr-overlap.sh: create the <!-- hive-pr-overlap --> comment
only when a sibling PR conflicts or shares a file; a later clean run edits
the existing comment to a one-line Resolved note; never post for a PR that
never had a finding. The step summary keeps the full report.
- src/scripts/mutation-report.sh post: same for <!-- hive-mutation --> on a
pass verdict; the report is appended to the step summary first.
- src/scripts/feedback-gate.sh (+ test): decides whether the merge thank-you
is posted β skips bot/App authors, scanner/* and hive/* branches, hive-origin
bodies and returning contributors; FEEDBACK_* env knobs. Wired by the
feedback.yml change in the next commit.
- pkg/github: a dashboard approval on a Prow-managed, hive-authored PR relays
/approve only (LGTMSkipped); Prow rejects a self-/lgtm every time and no
hive lane reads the relayed /lgtm.
- docs: notifications.md (new section + Prow config location), glossary,
running-at-level-6; changelog fragment.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π workflows: gate the Feedback Wanted thank-you on src/scripts/feedback-gate.sh
Refs #17863. Workflow-only commit: adds a gate job (self-test + decision)
before the hivecommons/infra reusable-feedback call, which runs only when
the gate outputs post=true.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π± governance: re-pin TRUSTED_SCRIPTS_TREE for the feedback-gate and mutation-report scripts
Refs #17863. src/scripts gained feedback-gate.sh / test-feedback-gate.sh and
mutation-report.sh changed, so the pinned tree moves to 1f1eb9048.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π fix: atomic runtime config save + fresh legacy fallback (#17862) (#17867)
* π fix: atomic runtime config save + fresh legacy fallback (#17862)
Config.Save wrote /etc/hive/hive.yaml and /data/hive.yaml.runtime in place
with O_TRUNC. A liveness SIGKILL between truncate and write left a 0-byte
runtime file; the entrypoint's -s check then fell back to /data/hive.yaml.bak,
frozen at the Aug 2026 rename on every hive, and vllmd-03 booted level 3
instead of 6.
- writeFileAtomic: temp file in the target's dir, fsync, rename onto the
EvalSymlinks-resolved target so the #17468 link survives; falls back to
the old in-place write when rename is refused (single-file bind mounts).
- Both Save writes use it; runtime stays 0600, source keeps its mode.
- entrypoint: hive_refresh_legacy_fallback copies a YAML-valid runtime
config over hive.yaml.bak on clean boots (tmp+mv), only when the new name
is the boot source; hive_runtime_config_read WARNs loudly on fallback and
flags a fallback older than the damaged runtime file.
- Tests: writer unit tests incl. symlink + no-partial-read race; shell
suite covers WARN, refresh, parse guard, legacy-boot no-op.
Fixes #17862
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* test(config): cover atomic writer failure paths for coverage floor
Adds tests for missing target dir, ENOTDIR resolve error, dangling
symlink, rename+fallback double failure (no temp leak), in-place
fallback, syncDir tolerance and sourceConfigMode, lifting pkg/config
back over its 90% coverage floor.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
---------
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* π release: v5.231.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.231.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π fix: wait for marketplace refresh completion in auth test (#17868)
Wait for a new refresh result rather than interpreting an idle refresher as proof that the newly accepted asynchronous run has finished.
Hive-Run: hivecommons/hive#17865
Hive-Plan: marketplace-refresh-flake
Hive-Spec: marketplace-refresh-flake#async-completion
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
* π release: v5.231.1
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.231.1 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* π docs: Inbox voice sources page + quickstart link (#17899)
* π docs: add Inbox voice sources page and quickstart links
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π docs: use .row utility for Inbox quickstart link group
TestStyleRatchet counts inline style= attributes in static/index.html;
the new link group pushed it over the 1403 baseline. The existing .row
utility (flex, gap var(--sp-4)) renders the same.
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π docs: link #17882 from the changelog fragment
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* β¨ dashboard: Settings β Inbox section (default repo, dibs URL, rules) (#17901)
* β¨ dashboard: Settings β Inbox section for default repo, dibs URL and rules
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
#17885 landed inbox.* config, validation, parity allowlist and /api/inbox/settings but no Settings tab section. Add Settings β Inbox reusing the Inbox drawer form and endpoint. Part of #17883.
* π dashboard: scope the Inbox settings form to its active root
The Inbox settings form renders twice β in the Inbox page modal and inline under Settings β Inbox β and both can be mounted at once: the settings tab stays in the DOM and the closed modal keeps its last body. inboxReadRules collected .inbox-rule rows from every #inbox-settings-rules, the repo/dibs inputs were read via getElementById (first in document) and the inline sniff kept the modal open on save, so saving from the modal after visiting Settings β Inbox posted the inline form's values and left the dialog up.
Wrap the form in .inbox-settings-form[data-inbox-form=inline|modal], replace the duplicated ids with data-inbox-field attributes, and resolve one active root per operation (the modal while open, otherwise the inline section). Read, render, save and the close-modal decision all go through that root.
Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
---------
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* π release: v5.232.0
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.232.0 entry.
See src/docs/releases.md.
Signed-off-by: hive-release-bot <actions@github.com>
* β¨ inbox: Plaud source onto the Source interface (#17900)
* β¨ inbox: read Plaud recordings directly through the Source interface
The Inbox only saw recordings through the facts the Plaud connector writes. Add a PlaudSource that lists/fetches straight from the connector (item id stays attr_plaud_file_id), preferred while Plaud is signed in with the fact-backed source as fallback.
Refs #17877, part of #17875.
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π inbox: cache the direct Plaud listing off the poll path and keep fact fields
PreferDirect.List spawned the Plaud MCP process on every Items/Find/Sweep call, so each dashboard poll paid for a process spawn plus list_files pagination and a slow spawn past the handler timeout silently flipped the UI back to facts. The direct listing is now cached for a TTL and refreshed by a single background goroutine with its own timeout; List serves the cache (or just facts while nothing is cached) and never blocks on Plaud. A failed refresh clears the cache and is not retried before the TTL.
Direct items also dropped FactSlug/FactPath/Layer/Excerpt, hiding the Fact button and excerpt for recordings that do have facts. The fact listing is now merged by id onto the direct items, and facts Plaud no longer lists stay visible.
Refs #17877.
Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* π inbox: wait on the Plaud refresh with testutil.Eventually, not a sleep loop
The sleep ratchet (TestSleepRatchet) rejects any new fixed β¦
β¦without sharing memory (#17767) * π claude auth: share refreshed logins across per-agent .claude homes without sharing memory Since the per-agent CLI homes landed, each per-UID agent has a real ~/.claude directory with only .credentials.json symlinked to the shared login at /data/home/.claude/.credentials.json. Claude Code refreshes its token by writing a temp file in ~/.claude and renaming it over .credentials.json, then chmod 0600. The rename replaces the symlink with a private, agent-owned file. bridgeHomeEntry refuses to clobber a regular file, so nothing ever re-links it; the refreshed access token and the rotated refresh grant stay in that agent's private file, the shared credential ages out, and the rest of the fleet logs out every ~8h (Discord report by Danathar, 2026-11-11). Andy's direction: keep per-agent memory isolated, make an exception for the login only. So no opt-in whole-directory sharing. Instead the hive repairs the bridge in-process: - repairClaudeCredentialBridge: when the agent's credential path is a regular file, read it (directly, or as its owner through the existing su-exec seam when the server cannot open an agent's 0600 file β the per-UID case), move it aside as .credentials.json.stale-<ts>, promote it into the shared login only if it is complete, usable and expires later than the shared token (a failed refresh's empty-token file never wins; ties keep shared), preserving the previous shared file, then restore the symlink. Legacy whole-directory ~/.claude symlinks and unreadable private files are left untouched, with a once-per-version log. - Triggered at agent launch (setupPerAgentCLIHome), every 5s from the credential watchdog (HIVE_CLAUDE_CREDENTIAL_BRIDGE_INTERVAL) so a refresh is fleet-visible before siblings try the rotated grant, and right after a dashboard sign-in (ReloadClaudeToken). - Audited as claude_credential_rebridged (no token material). - claude.ReadTokens/ParseTokens/TokensUsable split out of LoadTokens so "cannot open" is distinguishable from "no token". Tests reproduce the CLI's tmp+rename+chmod and show the shared file did not update before the fix and does after; cover newer-shared, failed refresh, su-exec owner read, unreadable fail-safe, legacy layout, stale name collisions, watchdog cycle and sign-in trigger. Refs #17039, #17253, #17678, #17752, #17753 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * π± keep manager_tokens.go at its file-size ratchet baseline Move the sign-in re-bridge body into claude_credential_bridge.go and defer it from ReloadClaudeToken (LIFO: after the Unlock). Signed-off-by: Andrew Anderson <andy@clubanderson.com> * π harden shared-home permission guard and credential promotion against non-regular files Shared logins and CLI configs written by the hive (.claude/.credentials.json, .copilot/config.json, the durable Copilot token) now go through a new crux/sharedfile package: a randomly named temporary beside the target, mode and owner set and verified on the open descriptor, rename, directory fsync, and the write is refused unless the target is absent or a regular file in a regular directory the server owns. Credential promotion writes a canonical re-encoding of the parsed token block and checks the moved-aside source is the same regular file before and after. Parity with the v6 fail-safe behaviour: an unreadable private credential is left in place except on a dashboard sign-in with a usable shared login, the refusal is logged once per file version, WriteCredentials refuses a credential without an access token, and ReadTokens treats malformed JSON as nothing usable. entrypoint.sh: the shared dot-dirs get the sticky bit (not under HIVE_SHARED_AGENT_HOME=1); the single-file repairs act only on a regular file in a regular directory and WARN once otherwise; the remaining root chmod/chown sites under agent-writable directories gained the same checks. The Go permissions watcher keeps setgid/sticky when widening a directory's group bits. Shell tests drive the shipped guard functions with non-regular entries. Refs #17039, #17253, #17678, #17748 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * π± wait for the watchdog re-bridge with testutil.Eventually instead of a polling sleep Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Problem
Reported on Discord by Danathar (2026-11-11), hive operator on a per-UID hive: since #17039 gave every agent a real
~/.claudedirectory with only.credentials.jsonsymlinked to the shared login, Claude logins stopped propagating and the fleet logged out roughly every 8 hours.Root cause (v5):
src/crux/agent/interactive_home.goperAgentCLIHomesbridges.claude/.credentials.jsonas a symlink to/data/home/.claude/.credentials.json.~/.claudeβrename()over.credentials.jsonβchmod 0600.rename()replaces the symlink itself with a private, agent-owned regular file.bridgeHomeEntry(interactive_home.go, "Real file/dir: refuse to clobber") then leaves it alone forever. The refreshed access token and β worse β the rotated refresh grant stay in that one agent's 0600 file. The shared credential ages out; every other agent tries the old grant, fails, and lands at/login.Supersedes #17678 and #17748 once ported to v6.
Direction
Andy: "we don't want claude to share all its memory, but we can make an exception for the login stuff." So this PR does not take Danathar's proposed opt-in
HIVE_SHARED_CLAUDE_HOME=1(#17752, whole-directory link, gives up memory isolation). Per-agent~/.claudestays the only layout; only the login is shared and kept refresh-safe. No operator switch.Mechanism
New
src/crux/agent/claude_credential_bridge.go:Lstatthe agent's credential path; a regular file means the CLI's rename replaced the link.~/.claudesymlink β moving that would log the fleet out), and never move a file whose token cannot be read (fail-safe: it may be the only fresh token in the fleet; logged as ERROR once per file version).os.ReadFile; onEACCES(per-UID: agent-owned 0600, server runs asdev) read through the existingsu-execseam (runAsAgentUser/claudeSessionOwnerSpec, the same path session adoption already uses β fails closed on symlinks, root-owned or oversized files). No root, no new privilege..credentials.json.stale-<UTC ts>[-N], kept, not deleted).expiresAt, is usable, and either the shared one is unusable or the agent'sexpiresAtis later. Ties keep shared. A failed refresh (CLI writes empty tokens /expiresAt: 0) never wins. Promotion is tmp + chmod 0660 + chown-like-target + rename, re-validated; the previous shared file is preserved as.stale-<ts>.claude_credential_rebridged(kept=agent|shared, trigger, stale paths; no token material).Triggers:
setupPerAgentCLIHome, beforebridgeHomeEntry(interactive_home.go).StartCredentialWatchdog(credentials_watchdog.go,HIVE_CLAUDE_CREDENTIAL_BRIDGE_INTERVAL). The short cadence matters: all agents hold the same access token and refresh near-simultaneously; the first refresh rotates the grant, so publishing fast shrinks the window in which siblings try the dead grant. Also re-bridges before the 5-min probe.ReloadClaudeToken(manager_tokens.go) after a dashboard login, so a stranded agent is re-linked immediately.Serialized by a package mutex (never held with
m.mu).Parity with #17748 (v6): an unreadable private file is never moved aside or relinked, except on the sign-in trigger when the shared login is usable; the refusal is logged once per file version; a file replaced mid-move is put back;
WriteCredentialsrefuses a credential with no access token (ErrNoAccessToken);ReadTokenstreats malformed JSON as "readable, nothing usable".Hardening of the shared-home write paths
Harden shared-home permission guard and credential promotion against non-regular files:
crux/sharedfile(Replace,ReadNoFollow,Chmod): randomly named temporary beside the target,O_EXCL|O_NOFOLLOW, mode/owner set and verified on the descriptor, rename, directory fsync; the target must be absent or a regular file in a regular, non-world-writable directory owned by the server. Used bypromoteClaudeCredential,claude.WriteCredentials,copilottoken.WriteConfig,copilottoken.WriteDurableToken,fixSharedConfigPerms..stale-*move checks the source is a regular file before and the same inode after.entrypoint.sh: the shared dot-dirs (/data/home,.claude,.copilot,.gemini,.bob) get the sticky bit (not underHIVE_SHARED_AGENT_HOME=1);hive_fix_shared_credential/hive_fix_copilot_configgo throughhive_fix_shared_file, which acts only on a regular file in a regular directory viafind -maxdepth 1 -type f ! -type l -exec chmod/chown -h, and WARNs once per path otherwise; the instant-path dir chmods,hive_sweep_root_phase_paths, the.bashrc/.profilewrites, and the/data/agents,/data/beadsper-agent chmod/chown sites gained the same regular-file/-dir checks. The Go permissions watcher keeps setgid/sticky when it widens a directory's group bits.test_entrypoint_perm_guard.shsection 14 drives the shipped guard functions with non-regular entries at the repaired paths.crux/claude/oauth.go:LoadTokenssplit intoReadTokens(keeps the read error so "cannot open" β "no token"),ParseTokens,TokensUsable.Trade-offs / alternatives considered
CLAUDE_CONFIG_DIRβ shared dir: moves everything, kills memory isolation (that is π [v6] claude auth: opt-in switch to keep one shared ~/.claude so a token refresh reaches every agentΒ #17752).apiKeyHelperreading the shared file: yields a static token with no refresher; hive has no Claude refresh client, so the fleet would still die at expiry.Runtimeinterface method (would touch runtime/api/client/recorders); reused the existing watchdog goroutine.Interaction with #17678 / #17753 (v6)
su-exec, no root guard needed. For the v6 top-up, the delta on π [v6] claude auth: re-bridge per-agent credentials a token refresh replaced, and resume login-paused agents after sign-inΒ #17253/π [v6] claude auth: never discard an agent's refreshed credential the server cannot readΒ #17678 is small: make the repair's read fall back toreadClaudeCredentialAsOwner, add the 5 s poll and the newest-expiresAtrule.claude.ReadTokens/ParseTokensandclaudeBridgePromotablehere are named to match π [v6] claude auth: never discard an agent's refreshed credential the server cannot readΒ #17678 so the port is mechanical.claude setup-tokenvia env) is orthogonal and still worthwhile.v6 differences noted
v6 already has
claude_credential_bridge.gofrom #17253 (+ dashboardcredentialBridgeBroken, resume-after-sign-in). This file is new on v5; the v6 port should merge into the existing one rather than add a second.Tests
src/crux/agent/claude_credential_bridge_test.go(packageagent):TestSetupInteractiveHome_RefreshReplacedLinkIsPublishedToSharedLoginβ the reproduction: provision, simulate the CLI's tmp+rename+chmod 0600 with a newer token, assert shared file did NOT move (the bug), relaunch β shared has the new token (0660), link restored, private copy kept aside 0600, old shared preserved, memory untouched, audit kept=agent without token text, idempotent. Fails on v5 without the fix.runAsAgentUserassertsuid:gid cat <path>); unreadable left in place, nothing audited, ERROR once per file version; legacy whole-directory symlink never touched; healthy/absent/dir no-ops and no-bridge cases; stale names never collide within a second;preferAgentClaudeCredentialtable;promoteClaudeCredentialrefuses unusable bytes and keeps shared owner/mode;TestCredentialWatchdog_RebridgesWithinOneCycle;TestReloadClaudeToken_RebridgesAfterSignIn(logout moves nothing); mid-rename race.crux/claude/usable_token_test.go:ReadTokenserror kinds,ParseTokens,TokensUsable;oauth_write_error_branches_test.go:WriteCredentialsrefusals (ErrNoAccessToken, non-regular target, no leftover temporaries).TestPromoteClaudeCredential_WritesOnlyTheTokenBlock,TestRepairClaudeCredentialBridge_SharedTargetSymlinkIsRefused/_SharedDirSymlinkIsRefused,TestMoveAsideClaudeCredential_NonRegularSourceIsRefused,TestRepairClaudeCredentialBridge_UnreadableIsRelinkedOnlyAfterSignIn,TestFixSharedConfigPerms_SymlinkIsNotFollowed,crux/sharedfile/sharedfile_test.go(unpredictable temp names, no temp left on failure, refusals).Docs:
docs/agent-configuration.md(new "How the Claude login stays shared when the CLI replaces the link"),docs/env-vars.md. Changelog fragmentchangelog.d/fixed-claude-shared-credentials.md.Notes for operators
/loginuntil that agent restarts (v5 has no resume-after-sign-in; the login scanner handles it)..credentials.json.stale-*files are kept for forensics, not auto-cleaned.Refs #17039, #17253, #17678, #17748, #17752, #17753