Skip to content

🌱 Top up v6 with v5 latest (v5.237.2) - #18030

Merged
clubanderson merged 155 commits into
v6from
topup/v6-from-v5-20261112
Nov 12, 2026
Merged

clubanderson merged 155 commits into
v6from
topup/v6-from-v5-20261112

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Merge origin/v5 at v5.237.2 (4d8744035, 154 commits since merge-base ac919930d) into v6 β€” a true merge, not cherry-picks β€” following the last top-up (#17747, v5.220.0). v6-only features (CheckSummary.Missing, BucketDependencyDashboard, newer hub/relay/contribute code, split config/manager files) are preserved.

Notable v5 changes carried

Features

  • Substrate as 4th sandbox runtime (opt-in, preflight-gated) with preflight prover, dashboard warnings/settings, substrate kick streaming in terminal pane; ADR-0026 phase 2 docs
  • Inbox: Settings β†’ Inbox section (default repo, dibs URL, rules); voice recorders as first-class input sources (Plaud β†’ spek RFC / dibs / knowledge); Wispr Flow dictation history and Plaud notes as knowledge sources; empty-state rendering
  • Benchmarks: per-PR estimated cost in /api/benchmarks/export
  • Hub: per-cluster host_aliases for hosted hives
  • Marketplace: curated model seeding + CNCF TechDocs assessment workflow; seeding resumes across hub restarts; spokes can trigger refresh
  • Workflows: owner toggle for model-based stage derivation
  • crux proxy: OTel metrics/span for inference translator; crux.serve.auth.rejections counter
  • Claude auth: operator-supplied long-lived token (HIVE_CLAUDE_OAUTH_TOKEN) β€” v5 port of v6's feature; v6's ✨ [v6] claude auth: report long-lived-token vs dashboard-sign-in mode on auth status and surface 401 as token rejectedΒ #17861 additions kept

Fixes

  • Automerge: detect orphaned queued workflow runs in held-run resolution
  • Agent: don't WARN-dump the pane when a prompt wait outlasts a live turn; Copilot CLI ENOEXEC on kernel 6.12 handled via ld.so exec + preflight; pluk session log recreated when unopenable
  • Army/rework: stop attributing adopted PRs to a remote agent's queue; show why a fix isn't dispatched
  • Fleetreport: new classes for Dependabot-alerts permission, prow/lgtm statuses permission, hub heartbeat unprovisioned, plain-HTTP proxy forwarding failures, repeated agent-lifecycle lines; structured context cancellation recognized; forge_unreachable for transport-level App token mint failures
  • Hub: negatively cache rejected bearer tokens (bounded); stop re-probing exhausted user quota; stale stage-tracker body served instead of blocking; startupProbe/init image converge on existing deployments; off-cadence/scheduled agents no longer flagged idle-with-work
  • Config: atomic runtime config save + fresh legacy fallback (πŸ› Config.Save O_TRUNC + stale hive.yaml.bak fallback boots a months-old config after a mid-save kill (vllmd-03 L6β†’L3)Β #17862); review.perspectives_source + ReviewPerspectives parser; nil-config guard in stageEngineOptions
  • PR comments: overlap/mutation notices only on a finding; thank first-time contributors only; no self-/lgtm relay on Prow PRs; count PR author's own sign-off after a hive rebase
  • Dashboard: summarize dropped SSE events; bound consecutive stale-snapshot drops; cache app_keys_held fingerprints
  • Misc: unique temp files for hive/reach state; effect-ledger ops stuck in Unknown reconciled/expired; read-only lanes stop retrying hive:unauthorized label removal; warn-once for user identity in agent gitconfig; check-action-pins retries transient API errors; archived repos skipped in GFI curation; openshell sandbox names fit gateway 0.1.8 limits

Hardening (behaviour-neutral)

  • Hub-signed webhook relay so hosted spokes can verify relayed GitHub webhooks
  • crux/sharedfile: pluk session log prepared without following planted symlinks
  • substratebridge.Unpack refuses tar entries that write through symlinks
  • Plaud MCP server started with an allowlisted env
  • Marketplace: model-provenance curated claims from non-admin bundles downgraded; spoke-triggered ?repo= refresh restricted to tracked repos; repository tarballs streamed, only pipeline files kept
  • Proxy userinfo redacted in upstreamproxy URL errors; in-cluster k8s API dials marked so egress redirect never intercepts them

Conflict resolutions (61 files)

Already-ported pairs β€” resolved toward v6, then re-applied any v5-only delta:

Pair (v5 ↔ v6) Files Resolution
#17767 ↔ #17807 Claude shared-credential bridge crux/agent/claude_credential_bridge.go, credentials_watchdog.go, manager_tokens.go, pluk_dirs.go, crux/claude/oauth.go v6 (strict superset incl. ApplyProfile, removeDeadCredentialLink); pluk_dirs.go imports unioned (sync, syscall, crux/sharedfile)
#17890 (v5 port of v6 operator token) + v6 #17861 claude_operator_token*, crux/claude/operator_token.go v6 (add/add; v6 superset)
#17853 ↔ #17857 army rework queue contribute_fleet.go, contribute_fleet_rework(+_test).go, pkg/fixqueue/* v6 (fleetReworkFor(c, fc.Stale, openPRs, held), pendingReworkUnseenBound, Return/ReasonRelay*); removed a v5 auto-merged duplicate reworkCandidateOpen check
#17886 ↔ #17887 workflow.enabled toggle pkg/config/*, hive.yaml.example, docs v6
#17798 ↔ #17804 curated TechDocs model, #17793 ↔ #17794 streaming fetch pkg/hub/marketplace(+_test).go v5 taken (adds marketplaceTracksRepo 403 for non-admin ?repo= refresh + refreshAndWait helper); v6 content already identical
#17914 ↔ #17915 hub-signed webhook relay webhook_relay(+_test).go, webhook_relay_key.go, api_github_webhook.go, webhook_cache.go v6 (add/add superset; RecordWebhookDeliveryFailure(reason); relay reason consts stay in pkg/github)

Other content conflicts:

  • pkg/github/automerge/automerge_held_runs.go β€” kept v5's orphaned-queued-runs block (πŸ› automerge: PRs wait forever when GitHub leaves workflow runs orphaned in 'queued' (zero jobs) β€” detect and re-triggerΒ #17775) but dropped v5's rebaseNudged call (v6 removed Dependabot nudging; kept v6 botTakeoverAttempted/autofixDependabotHeadKnown).
  • pkg/config/config.go β€” v6 split this file; v5 hunks hand-applied to v6's agent_config.go (AgentSandboxGateReport, substrate noDigest check), save.go (writeFileAtomic, sourceConfigMode), review_config.go (PerspectivesSource, LinkedPerspectives, EffectivePerspectives()); added Inbox InboxConfig field. New v5 files (atomic_write.go, agent_sandbox_report.go, inbox_config.go) arrived cleanly.
  • crux/config/agent_config.go β€” v6; SandboxRuntimeSubstrate added to v6's sandbox_runtime.go.
  • crux/agent/manager_tokens.go / v5 manager_mint.go β€” v5 moved mintAgentTokenUnlocked to manager_mint.go (superset with ForgeUnreachable); kept v5's.
  • crux/audit.go, pkg/dashboard/audit.go, api_governor_security.go β€” v6 (superset keys; imports unioned).
  • crux/agent/agent_working_test.go β€” both tests kept.
  • pkg/fleetreport/runtime(+_test).go β€” union of class lists (v5's five new classes added).
  • Static-src/sections: v6 has runs-section/search-section, v5 adds inbox-section. Chosen order knowledge β†’ search β†’ inbox β†’ review-queue, applied in layout.js, refresh.js, sections.js, sidebar.html, config-state.js ('Inbox' tab after Knowledge, v6 tabs kept), config-tabs.js, static_index_test.go, dashboard_section_reorder_9062_test.go (moved.length !== 24), search_pane_ui_test.go (pinned adjacency string updated).
  • import_count_test.go β€” maxDashboardInternalImports 69 β†’ 70 (pkg/inbox import from v5).
  • CHANGELOG.md β€” both sides kept, v6 ordering per hunk. bin/hive-baseline-check.sh, src/hive.yaml.example β€” v6.
  • src/docs/** β€” v6 wording where equivalent; v5-only additions spliced in (dashboard-sections Inbox, glossary hive-pr-overlap πŸ› PR comment noise: overlap/mutation/feedback workflows and Prow relay post a fixed ~4 comments on every PRΒ #17863 wording, runtime-and-quota "Hub bearer validation" / "Keep personal tokens out of cluster secrets" sections, /api/benchmarks/export row).

Generated / pinned files

  • src/pkg/dashboard/static/index.html β€” regenerated via make dashboard-gen (dashboard-gen-check passes).
  • dashboard/openapi.json β€” no generator exists; structurally 3-way merged at the JSON level (v5 added 8 paths: /api/inbox*, /api/knowledge/connectors/{name}/auth*; no overlapping edits), re-serialized with the file's canonical 2-space formatting. openapi_route_parity_test passes.
  • .github/scripts/integration-governance.cjs β€” TRUSTED_SCRIPTS_TREE re-pinned to this merge's src/scripts tree (f42d6489f0…).
  • src/docs/api-reference/* and scale-envelope.md citations refreshed with check-api-reference-citations.sh --fix / check-docs-citations.py --fix (one RankActionableIssues range set by hand).

Ratchets

  • crux file-size ratchet: the merge legitimately grew crux/agent/manager.go to 1673 > v6 ceiling 1653 (v6 guards against bumping). Moved AuthorizeReviewRequest to new crux/agent/manager_review_authz.go β†’ 1620 lines. No baseline raised.
  • Sleep ratchet, style/px ratchets, import-count: all pass; no bumps.

Verification

From src/: go build ./... && go vet ./..., golangci-lint run (0 issues), gofmt, go test on crux/…, pkg/config, pkg/dashboard/…, pkg/fixqueue, pkg/fleetreport, pkg/github/…, pkg/hub, pkg/inbox, internal/…, cmd/…; dashboard/ npm test (101 pass). Only local failures are pre-existing macOS-environment ones (/var symlink, tmux socket path) that also fail on untouched v6.

clubanderson and others added 30 commits November 11, 2026 19:45
…2 β€” exec via ld.so + startup preflight (#17737)

Fixes #17729. Refs #17642.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.221.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…ry error (#17756)

* πŸ› fix: name ENOEXEC instead of dumping binary stderr in model discovery error

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› fix: import unicode/utf8 and keep ANSI-coloured stderr out of the ENOEXEC check

cli_models.go used utf8.ValidString without importing unicode/utf8, so the
dashboard package failed to build. isBinaryStderr also treated ESC (0x1b) as
a binary control byte, so coloured stderr would have been mislabelled as an
ENOEXEC dump; ESC is now allowed alongside the whitespace controls, with a
regression test.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
#17741)

* ✨ crux: Substrate as the 4th sandbox runtime (opt-in, preflight-gated)

Add Agent Substrate (CNCF Sandbox) as sandbox.runtime: substrate behind
the existing sandbox.Launcher seam, mirroring the OpenShell runtime
(ADR-0026 phase 2).

- crux/sandbox/substrate*.go: SubstrateLauncher (ActorTemplate + Actor
  per kick, atenet-egress policy derived from the proxy host set +
  allow_hosts, workspace push/run/pull through an in-actor bridge over
  the atenet-router mTLS CONNECT tunnel, snapshot_on_idle suspends
  instead of deleting), real gRPC client constructed lazily, Control
  API preflight registered into crux/config.
- crux/sandbox/substrateapi: trimmed, wire-compatible proto subset of
  ate.control.v1 generated in-repo (no go.ate.dev/substrate import:
  it requires Go 1.27 and is very large). Zero new Go modules.
- crux/sandbox/substratebridge: the HTTP bridge served inside the actor.
- crux/config/agent_config_substrate.go: sandbox.substrate.* leaves with
  per-agent merge; pkg/config gate warnings (digest-pinned image).
- Settings parity allowlist entries for the new leaves (#17699).

Fixes #17697
Part of #17695

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* changelog: fragment for #17741

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* 🌱 changelog: make the substrate fragment an entry bullet

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 changelog: drop the auto-generated duplicate fragment

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 substrateapi: drop a never-true nil comparison flagged by staticcheck

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…y notes (#17745)

* πŸ“– docs: ADR-0026 phase 2 β€” Agent Substrate runtime operator and deploy notes

Amend ADR-0026 with the Substrate implementation notes (contract mapping,
deviations from the reference model, cluster prerequisites and which hive
clusters qualify, when to choose it over OpenShell); add the operator
section to sandbox-isolation.md, the integrations table row, deploy/README
pointer and a new deploy/substrate.md with install and verification steps.

Part of #17695

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* changelog: fragment for #17745

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* 🌱 changelog: make the substrate docs fragment an entry bullet

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 changelog: drop the auto-generated duplicate fragment

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– docs: fix the ADR-0002 link in the Substrate section

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.221.1 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…17743)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…sDir (#17765)

stageEngineOptions dereferenced cfg.Data.WorkflowsDir as an argument before any nil check. Because stageEngine is a package-level sync.Once, the panic only fired when a nil-config caller was first in the process, making it order-dependent. Build the workflow store only when cfg != nil.

Closes #17736

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* Fix GFI curation for archived repositories

Hive-Run: #17734
Hive-Plan: archived-repository GFI recovery
Hive-Spec: good-first-issue#archived-repositories
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>

* fix: correct changelog fragment category

Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>

---------

Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.222.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…let spokes trigger refresh (#17773)

* πŸ› marketplace: resume CNCF catalogue seeding across hub restarts and let spokes trigger refresh

Root cause of the one-entry catalogue on hive.hivecommons.dev: GitHub
tarballs lead with a pax_global_header entry, which Go's tar reader
surfaces as a header. ExtractTarGz counted it as a second top-level name,
returned dest instead of the wrapped "<owner>-<repo>-<sha>/" directory,
and ingest.ReadTree then saw every path with the wrapper prefix β€” no
GitHub Actions workflow matched. Only tektoncd/pipeline got through, via
the content-based Tekton sniff. Skip pax headers when extracting.

Seeding is now resumable: at startup the hub ingests every corpus repo
that is due (no record, record older than 24h or in an older format,
error older than 1h) instead of only when the catalogue is empty, so a
restart mid-seed continues and a flapping hub does not re-crawl fresh
repos. Records carry a format version; bumping it (format 2 for the
tarball fix) re-ingests everything on the next boot. The last run summary
is persisted so status.lastRefresh survives restarts; status gains
pendingRepos/lastRefreshErrors and ?verbose=1 (spoke or admin) lists the
failing repos with their errors.

POST /api/marketplace/refresh accepts the same credentials as publish
(hub admin session or spoke heartbeat bearer + X-Hive-ID); spokes are
rate-limited (one full run/hour, 10 ?repo= runs/min β†’ 429 + Retry-After),
admins are not. The spoke proxy passes 429/409 through with the hub's
message. The crawl sleeps on 403/429 Retry-After (secondary limits) and
logs progress every 25 repos.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› marketplace: update refresh tooltip in static-src and regenerate index.html

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…17744)

* fix: bound consecutive stale-snapshot drops in the status builder

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ“– docs: update staleDropStarvationThreshold comment for bounded publish

The constant's doc comment still described the pre-PR contract (drop
logged at Warn). It now marks the point where the build is published
anyway to bound staleness.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ“– docs: resync api-reference citations after server.go route shift

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…17754)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…ss, feature gates) (#17766)

* ✨ crux: Substrate preflight prover (operator, CRDs, gVisor RuntimeClass, feature gates)

Extends the sandbox.runtime: substrate preflight with the cluster facts
behind a failing kick: operator CRDs and workloads, ready WorkerPools and
their sandbox classes, gVisor (SandboxConfig or runsc RuntimeClass) and
KVM availability, node kernels, the certificates.k8s.io APIs behind the
PodCertificateRequest and ClusterTrustBundle feature gates, and an mTLS
CONNECT probe of atenet-router. Skipped outside a cluster; one warning
when RBAC is missing, with a manifest that grants it.

Fixes #17698

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* fix(crux/sandbox): egress policy atespace + in-place workspace clear found by #17697 kick

The first real kick through Substrate v1.0.0 (kind, gVisor) surfaced two
defects in the launcher path: CreateActorEgressPolicy was rejected with
'egress_policy.metadata.atespace: Required value', and the bridge's PUT
/workspace failed with EBUSY because os.RemoveAll targeted the durableDir
mount point itself. Set the atespace on the singleton policy and clear the
workspace directory's contents in place.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* test(crux/sandbox): run the kube/router preflight halves only in a Pod wired for Substrate

CI runs in Pods, so /var/run/secrets/kubernetes.io/serviceaccount/token
exists there and the kube/router halves of the prover ran during the
Control-API-only tests (crux/sandbox and crux/agent). The prover now
requires both the Kubernetes token and hive's projected Substrate token
(opts.token_file, /var/run/secrets/ate/token by default) before probing the
cluster; the Kubernetes token path is a package variable the sandbox test
package pins to a nonexistent file, with a helper that flips both markers on
for the tests covering the in-cluster branches.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…mits (#17780)

Prototype on LKE (#17643) hit four gateway rejections before a kick ran:
sandbox names over MAX_ROUTABLE_NAME_LEN (19), the reserved 'workspace'
volume name, default-denied pod labels/annotations, and the missing Agent
Sandbox prerequisite. Names are now hk-<slug>-<base36 unix> (fnv tag when
the slug does not fit), the claim mounts as hive-workspace, and the deploy
doc records the operator settings the measurements depended on
(allowed_pod_labels, workspaceStorageClass, sandboxUid, auth modes) plus
the landlock-in-LSM preflight lesson and the measured numbers.

Refs #17643, #17642

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.222.1 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
#17793)

The marketplace fetcher extracted each default-branch tarball to disk via
complexity.ExtractTarGz under a 256 MiB whole-tree cap, so large monorepos
(kubernetes/kubernetes, kserve/kserve, meshery/meshery, shipwright-io/build,
spidernet-io/spiderpool) failed with "archive exceeds size cap" and never
reached the catalogue. ingest.ReadTarball now streams the archive and keeps
only the paths ReadTree would select (shared selectTreeFile), 1 MiB per
file and 32 MiB in total, discarding everything else without buffering;
the complexity cap is untouched for its own callers.

GET /api/marketplace/status now includes failing:[{repo,error,checkedAt}]
without ?verbose=1 (repo names and fetch errors carry no secrets), so an
operator with a plain PAT can see why repos fail. Four corpus entries that
GitHub now redirects are updated to their current names.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
* πŸ› fix: redact proxy userinfo in upstreamproxy URL errors

parseProxyURL formatted the raw proxy URL into its rejection errors, and
configureUpstreamProxy logs that error, so a malformed URL carrying the
proxy's Basic credential put the password in the hive JSON log on every
boot. logscrub's basic-auth category covers Authorization headers only,
not URL userinfo, so nothing downstream masked it. Use url.Redacted() on
the parsed form, strip the userinfo segment when url.Parse itself fails,
and drop the *url.Error wrapper whose message repeats the full URL.

Fixes #17730

Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* chore: re-key merge request after transient lint-pending refusal

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Records now carry cost.basis (tokens_x_pricing | unknown), cost.usd_est,
token share, launches and price_table_date, attributed from the spoke's
launch-cost collector: the swarm's PR ref for reviewer records, the
governor's issue ref of an issue the PR closed for author records (both
ref spellings). Vendored benchmarks schema refreshed; converter and
dashboard lookup tests; docs cost section.

Fixes #17790
Refs #17694

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.223.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…ent workflow (#17798)

Curated marketplace tier gets a source of truth in the binary:
pkg/hub/marketplace/curated/*.yaml is embedded, strictly decoded, checked
for the curated invariants (provenance curated, a version, nothing left
inferred), compiled through bundle.Export and published at tier curated
on hub startup and at the start of every refresh run when that
name@version is absent. Bad files are logged and skipped, never fatal;
edits without a version bump are refused as conflicts, so a new version
is a new file. Seeded keys are reported in lastRefresh.curated.

The first curated model is cncf-techdocs-assessment@curated-2026.11.1:
Nate W.'s AI-assisted TechDocs assessment process (spec at
nate-double-u/cncf-techdocs@882be6f, intake template @ad91530), scoped to
cncf/techdocs. Issues travel requested β†’ accepted β†’ draft-open (β†’
escalated) β†’ closed/declined; deliverable PRs travel drafting β†’ in-review
β†’ stakeholder-review β†’ awaiting-merge β†’ merged with checks-failing and
discarded branches. Every gate (/accept, /decline, /verify, /ready,
/confirm, /approve, /discard, /abort) is released by a human role; the
drafter and verifier agents stop at gates. Checks are the repo's
format/link/spell-check workflows plus the manual provenance block. The
rules evaluator is exercised over hand-written Facts for each step.

cncf/techdocs is not a landscape project, so the corpus package gains an
operator-added extra.json merged into Repos(); the ingested-unreviewed
version now sits next to the curated one.

Docs: marketplace section of docs/design/workflow-models.md (curated
seeding, where a model goes, how versions work) and
docs/workflows/techdocs-assessment.md for the TechDocs team.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…unclassified selfreports (#17757)

* πŸ› fix: classify repeated agent-lifecycle log lines instead of filing unclassified selfreports

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test: expect agent_lifecycle_repeated class for non-held kick failures

TestPostRestartKickHoldLogsWithoutFleetReport asserted the generic
unclassified class; 'failed to send kick' is now classified as
agent_lifecycle_repeated. Held kicks still produce no observation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ims from non-admin bundles (#17764)

* πŸ› fix(marketplace): refuse and downgrade model-provenance curated claims from non-admin bundles

The hub checked only the envelope Tier when deciding whether a publisher may
assert curated/built-in; the model's own spec.meta.provenance is hash-covered
and stored verbatim. Spoke import preferred the model's provenance over the
envelope tier, so a registered spoke could publish a bundle every importer
badged as curated. The hub now refuses such bundles from non-admins (it
cannot rewrite the hash-covered model) and importers honour a vouched model
provenance only when the envelope asserts the same tier.

Fixes #17763

Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* fix(marketplace): express importedProvenance as an if so the mutation gate sees its coverage

Go's cover tool does not instrument the case expressions of a tagless
switch, only the case bodies, so gremlins reported the three conditionals
on the switch as NOT COVERED even though TestImportedProvenance exercises
every branch. Fold the switch into a single if with identical semantics;
if conditions sit inside the preceding coverage block and are attributed
correctly.

No behaviour change: empty provenance still takes the envelope tier, and a
curated/built-in claim the envelope does not assert still falls back to it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hivecommons-hive Bot and others added 16 commits November 12, 2026 20:17
TestDialUpstreamTLSSurfacesProxyRefusal relied on the test CONNECT proxy failing to resolve ghe.corp.invalid within 3s; on CI the resolver hung and the client timed out instead of seeing the 502. The test proxy now refuses on demand so the test does not depend on DNS.

Closes #17979

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.236.5 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.237.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
… own selfreport class (#17980)

* πŸ› fix(fleetreport): name the prow/lgtm statuses-permission 403 as its own selfreport class

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ“ fix(fleetreport): document the statuses-permission class and gate it on the 403

Review follow-up for #17980:

- fleet-report.md: add the github_app_statuses_permission_missing row beside
  its sibling github_app_alerts_permission_missing (component, log-fed gate,
  Commit statuses read & write remedy, github-app-setup.md link).
- bindProwLgtm: emit the "lacks the statuses: write permission" wording only
  when the CreateStatus error is a 403 *gh.ErrorResponse; 5xx, 422 and
  transport failures log a neutral line, so a transient outage is no longer
  filed as an installation-permission fault with a grant-permission remedy.
- fleetreport keyword now matches the 403-only line; tests pin both the
  positive match and that the neutral line stays out of the class.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* docs: re-anchor RankActionableIssues citation after client.go shift

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Run: #17944
Hive-Plan: stage digest cancellation
Hive-Spec: fleet-report#unclassified-error-repeated

Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.237.1 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…live turn (#17996)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ctives parser (#17994)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* πŸ› Avoid self-reporting intentional signing skips

Hive-Run: #17924
Hive-Plan: signed-commit skip self-report
Hive-Spec: fleet-report#unclassified-error-repeated
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>

* docs: explain signed-commit ownership suppression

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>

---------

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.237.2 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…vent (#17998)

* fix(dashboard): summarize dropped SSE events instead of warning per event

Signed-off-by: operations <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* docs(api-reference): refresh server.go citations after SSE drop summary

Signed-off-by: operations <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: operations <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: operations <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Merge origin/v5 (4d87440, v5.237.2) into v6, resolving 61 conflicts
toward v6 for already-ported pairs and carrying v5-only improvements.
Regenerated static/index.html; structurally merged dashboard/openapi.json;
re-pinned TRUSTED_SCRIPTS_TREE; split AuthorizeReviewRequest out of
crux/agent/manager.go to stay under the v6 file-size ceiling.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 12, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18000 ✨ feat(contribute): a relay that drops an issue says why, and the hub keeps and shows the reason same files src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor
eeb1ec9

ℹ️ Sentinel notice β€” informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head eeb1ec9ad853) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 12 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/feedback.yml
    • bin/gh-wrapper.sh
    • bin/gh-wrapper.test.sh
    • src/Dockerfile
    • src/Dockerfile.contributor
    • src/crux/go.mod
    • src/deploy/README.md
    • src/deploy/entrypoint.sh
    • src/deploy/k8s/sandbox-substrate-preflight-rbac.yaml
    • src/deploy/openshell.md
    • src/deploy/substrate.md
    • src/deploy/test_entrypoint_runtime_config.sh
  • ci_gate_weakening β€” CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • src/scripts/feedback-gate.sh

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • native-queue-policy

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

Head eeb1ec9ad.

⏱️ The 900s mutation budget ran out, so 13 package(s) were not fully mutated and the results below do not cover them:

  • pkg/dashboard: cut short (partial, no report)
  • pkg/delegatedecision: skipped (not started)
  • pkg/effects: skipped (not started)
  • pkg/evidence/benchmarks: skipped (not started)
  • pkg/fleetreport: skipped (not started)
  • pkg/gfi: skipped (not started)
  • pkg/github: skipped (not started)
  • pkg/hub: skipped (not started)
  • pkg/inbox: skipped (not started)
  • pkg/knowledge/connector: skipped (not started)
  • pkg/perspsrc: skipped (not started)
  • pkg/snapshot: skipped (not started)
  • pkg/tracing: skipped (not started)

❌ gremlins did not produce a report for 1 package(s), so no verdict can be derived from this run (see the job log):

  • crux: gremlins exited 1

15 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/cmd/hive/boot_dashboard_api_deps.go 44 ARITHMETIC_BASE
src/cmd/hive/boot_inbox.go 15 ARITHMETIC_BASE
src/cmd/hive/boot_inbox.go 36 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 42 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 46 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 65 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 65 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 69 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 89 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 93 CONDITIONALS_NEGATION
src/cmd/hive/boot_inbox.go 99 CONDITIONALS_NEGATION
src/cmd/hive/main.go 1691 ARITHMETIC_BASE
src/cmd/hive/review_kick_order.go 127 ARITHMETIC_BASE
src/pkg/config/agent_config.go 161 CONDITIONALS_NEGATION
src/pkg/convergence/mutation/boundary.go 268 CONDITIONALS_NEGATION

ℹ️ 1 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first lines added lines of each default-context hunk, so non-contiguous edits in one hunk are partly missed. This does not affect the verdict.

File Line Mutation
src/pkg/config/save.go 187 CONDITIONALS_NEGATION

Verdict: error (#17349).

@clubanderson
clubanderson merged commit 2ab505e into v6 Nov 12, 2026
101 of 109 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the topup/v6-from-v5-20261112 branch November 12, 2026 23:29
hivecommons-hive Bot added a commit that referenced this pull request Nov 13, 2026
Forward-merge v5 at 3b1eaed (v5.244.1, includes #18024 owner webhooks
setup) into v6. Merged against v5.237.2 (4d87440) as the base, the
v5 commit the previous top-up (#18030) carried; that top-up was
squash-merged, so git's own merge base is older and re-raised ~80
already-resolved conflicts.

Conflict resolutions (27 files) keep v6's structure and re-apply the
v5 delta:
- pkg/config: v5's project.reference_repos field goes into v6's split
  project_config.go; validateReferenceRepos added after v6's repo-policy
  checks.
- cmd/hive: perspsrc import added beside v6's nous/persona imports; the
  #18112 quota-probe stamp moved into v6's relocated kick-dispatch block.
- crux/agent: v6's SendKickWithSource and deferred-mention queue kept;
  sendKick(name, msg, trigger) added for v5's canary retry.
- dashboard: review section keeps v6's ReviewerAutoscale and named PUT
  body and adds v5's linked-perspectives fields; FrontendStatus gains
  ReferenceRepos; contribute_ws keeps both fields; navbar summary button
  (#18110) combined with v6's tile fitting.
- github: WebhookVerification uses v5's WebhookSecret() so the generated
  secret file counts; reopen test takes v5's pinned clock.
- docs/CHANGELOG: union (v6 rows/sections kept, v5 additions inserted).

Closes #18041

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants