Skip to content

🌱 Top up v6 with v5 (workflow models RFC phases 1–7, OpenShell runtime, benchmarks publisher and more) - #17747

Merged
clubanderson merged 96 commits into
v6from
topup/v6-from-v5-20261111
Nov 11, 2026
Merged

clubanderson merged 96 commits into
v6from
topup/v6-from-v5-20261111

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Top up v6 with everything on v5 through v5.220.0 (ac919930d), 94 commits. Merge commit of origin/v5 into v6 (--no-ff), 75 conflicted files resolved by hand.

Refs #17620

Carried v5 PRs

Workflow models RFC (#17620), phases 1–7

PR Phase Content
#17679 P0–P3a ingest, schema, compiler, DeriveFromModel, store, /api/workflows, repo bindings, tracker columns
#17681 P3b Settings β†’ Workflows tab (library, diagram, ingest)
#17685 P4 versions, diff, confirm-inferred, label regeneration on bind
#17688 P4 simulate an issue/PR against a model
#17708 P5 intake ingest: issue templates, triage, owners, branch rules
#17710 P5 safe label GC on rebind + model-defined human-gate replies
#17713 P6 cluster (Tekton) and written-spec ingest (LLM-assisted, inferred)
#17706 P6 visual editor with live compile, YAML, diff, simulate, export
#17714 P7 signed bundles, hub marketplace catalogue with nightly refresh, spoke import/publish

Other v5 changes

How the v6-only deltas were preserved

Workflow-model code (pkg/workflowmodel/**, pkg/stageengine/workflow.go, pkg/dashboard/api_workflows*.go, stage_tracker_workflows.go, cmd/workflow-survey, cmd/hive/workflow_ingest.go, config-workflows-*.js, docs/design/workflow-models.md) was taken from v5 wholesale, then:

  • stagelabels.CheckSummary.Missing β€” pkg/stageengine/workflow.go: checksName returns "missing" when len(c.Missing) > 0 (before pending), and ParseChecks("missing"|"none") round-trips to CheckSummary{Known: true, Missing: []string{"ci"}}. pkg/dashboard/api_workflows_simulate.go maps snap.Checks.MissingRequired β†’ CheckSummary.Missing when building simulate facts from a WorkflowItemSnapshot.
  • BucketDependencyDashboard β€” v6's pkg/stageengine/export_parity_test.go kept (v5 has no references to that bucket); TestStageGoldens and export parity unchanged.

Conflict resolution summary (75 files)

  • Workflow models (v5 is truth): 14 files via checkout --theirs + the two deltas above. reconciler.go/stage_engine.go/deps.go/main.go take v5's new WorkflowProvisioned/WorkflowLabelGC options and WorkflowItemSnapshot/RepoFile/ClusterRunner/SpecLLM deps alongside v6's AgentMgr/CruxRuntimeHealth/ReviewBotAuthors. main_sweeps.go adds WorkflowFor to the unpark sweep.
  • pkg/github: issue_unpark_command.go hand-merged β€” v6's release-policy (unparkReleasePolicy, Now) and v5's model-reply (WorkflowFor, *workflowmodel.Profile) both flow into tryUnparkIssue. issue_model_reply.go ported to v6's renderUnparkAcceptedReplyKeeping(…, removed, …) signature (v6 names removed labels in the reply). v5's FetchBranchRules (ingest) saved as branch_rules_ingest.go because v6 already has branch_rules.go (ReadBranchRules). attribution.go keeps both new audit actions. Automerge files keep v6 (v6 already carries the πŸ› Honor every configured trusted bot in the trusted-bot automerge laneΒ #17578 port via [v6] πŸ› Honor every configured trusted bot in the trusted-bot automerge laneΒ #17581) plus ensuredWorkflow on the stage tracker.
  • Config (v6 split kept): config.go extended with Workflow.LabelGC and Workflow.Marketplace (workflow_marketplace.go), network_config.go (upstream proxy); Benchmarks, WorkflowBindings auto-merged into v6's files. OpenShell gate warnings ported into agent_config.go AgentSandboxGateWarnings. testdata/agent_runtime_golden.json and settings_parity_allowlist.txt updated.
  • dashboard/openapi.json: v6 base; spliced 17 v5-only paths (workflows simulate/yaml/import/versions/diff/confirm/labels/bundle, ingest cluster/spec/capabilities, marketplace, benchmarks export) and 16 v5-only schemas; tag union.
  • static/index.html: manifest.txt union (v5 order for the four config-workflows-*.js), regenerated with webstatic/gen, -check clean. config-state.js adds the Workflows tab.
  • CHANGELOG.md / NOTICE: union β€” 26 v5 release sections (v5.211.19–v5.220.0) added after the v6 sections, matching the previous top-up's layout; NOTICE takes oauth2 v0.37.0 (go.mod) and lists both x/sync/errgroup (v6) and x/sync/singleflight (v5). New fragment changelog.d/changed-v6-topup-from-v5-20261111.md; v5's unreleased added-workflowmodel-marketplace.md carried as-is.
  • Docs: api-reference/*.md take v6 and re-add v5-only rows (benchmarks export, hub marketplace, agent log/kicks/terminal-urls/login-code); citations re-pinned with check-docs-citations.py --fix / check-api-reference-citations.sh --fix. adr/README.md ADR-0026 β†’ Accepted; github-app-setup.md keeps both Dependabot and Code-scanning rows.
  • Scripts / CI: mutation-report.sh + test take v5's verdict phase and wall-clock budget, with v6's head-SHA line re-added (and asserted in the test). integration-governance.cjs TRUSTED_SCRIPTS_TREE re-pinned to the merged src/scripts tree (689fea04d4…). dco-post-merge.yml takes v5's fuller waiver text. import_count_test.go ceiling 68 β†’ 69 (v5 added one dashboard-internal import on top of v6's).
  • Removed: stray Mach-O binary src/cmd/workflow-survey/workflow-survey that v5 committed by accident. discord/ stays removed.

Validation (local, macOS)

  • go build ./..., go vet on workflowmodel/dashboard/stageengine/github/config/hub/cmd, gofmt -l clean
  • go test ./pkg/workflowmodel/... ./pkg/stageengine/... ./pkg/config/... ./pkg/dashboard/webstatic/
  • go test ./pkg/dashboard/ -run 'Workflow|OpenAPI|Ratchet|Import|Manifest|Settings'
  • go test ./pkg/github/ -run 'Workflow|Unpark|StageLabel', go test ./pkg/hub/ -run Marketplace
  • check-docs-citations.py (2040 verified), validate-generated-notice.sh, test-mutation-report.sh

hivecommons-hive Bot and others added 30 commits November 10, 2026 17:27
#17561)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
… PR (#17564) (#17567)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.19 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…R mutation report (#17569)

* 🌱 mutation: verdict phase and misrouted/uncovered detection for the PR mutation report

The Phase 2 decision on #17349 asks the mutation job to (1) tell a run that
produced no mutants because the diff was not matched from one whose added
lines simply contain nothing gremlins can mutate, (2) fail on survivors and
(3) warn on uncovered mutants with a label override. All of that logic lives
in the script, which this change adds; the workflow step that calls the new
verdict phase is left for a human to land (see the issue).

Run 42842443653 (PR #17557) is the reference case for (1): gremlins v0.6.0
has no mutator for unary ! or for return values, so
'if !looksLikeUUID(id) { return "" }' yields zero mutants and the 108
SKIPPED ones all sit on unchanged lines. Counting added lines alone would
have failed that PR wrongly; a SKIPPED mutant inside an added range is the
actual signature of a matching fault.

Refs #17349

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* 🌱 mutation: honour gremlins' hunk approximation and fail closed on a missing report

Review fixes for #17569:

- misrouted was judged against the exact -U0 added ranges, but gremlins
  v0.6.0 honours only start=+pos+leading-context, end=start+added-1 per
  default-context hunk, so a hunk with non-contiguous added lines made the
  script fail legitimate PRs. Derive that range (gremlins.tsv) from the same
  default-context diff; SKIPPED inside it is misrouted, SKIPPED on an added
  line outside it is a non-blocking hunk-approximation note.
- A gremlins non-zero exit or missing JSON produced verdict=pass with a false
  "nothing to mutate" explanation. Record each failed package in errors.tsv,
  write verdict=error, report it in the comment, and make the verdict phase
  exit 1 on error and on a missing verdict file (#17349 item 1).
- has_label: make arr local.
- test-mutation-report.sh: stub gains GREMLINS_EXIT/GREMLINS_NO_OUTPUT, new
  split-hunk and failing-stub cases, missing-verdict expectation flipped.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* 🌱 mutation: re-pin TRUSTED_SCRIPTS_TREE to the mutation-report.sh tree

The second commit edited src/scripts/mutation-report.sh after the first
re-pin, so runtime-tests' integration-governance contract failed on the
stale literal. Pin to git rev-parse HEAD:src/scripts.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.20 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
#17578)

PRs authored by a login in auto_merge.trusted_bot_authors (Settings bot
toggles or a custom login) were evaluated by the trusted-bot lane but held
on the review swarm's requires_human verdict and parked at "needs a
person", while the contributor lane logged them as app-authored and the
self-authored sweep's skip/hold lines carried no tier.

- The swarm verdict is advisory on the trusted-bot lane by default
  (auto_merge.trusted_bot_skip_review, default true): recorded on the
  evidence bundle, never a hold or an 085 stage.
- The contributor lane hands trusted bots off as trusted-bot-lane; every
  self-authored sweep skip/hold line carries tier=<lane>.
- A config-named required check that never reported on the repo gates on
  the other reported checks (one warning per repo per hour) or holds with
  required-check-never-reported:<check>, shown on the Activity Monitor as
  the human-gate reason.

Fixes #17577

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.21 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…abel provisioning stops retrying every sweep (#17585)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.22 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…and Import forms (#17589)

* πŸ› knowledge: inline required-field errors on Add Git Source, Add Sub and Import forms

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* πŸ› knowledge: test inline field-error helpers

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› knowledge: use --fs-xs token for .field-error (style ratchet)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.23 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…s read and installations re-accept it (#17597)

The sec-check 403 persists after the code fix because the App itself must
declare Dependabot alerts: Read-only in the GitHub UI (no API exists) and
every installation must accept the permission update. Add a step-by-step
subsection, point the permission row at it, and mend the table split that
left the Workflows row outside the table.

Refs #17426

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…ines (#17612)

markProviderErrorLocked stored the raw pane line into LastError,
ProviderErrorLine and BackendAuth.LastError. Those reach the /v1 status,
the dashboard and the hub heartbeat, and unlike compactPaneTail and the
dashboard's redactTokens(LastError) nothing scrubbed BackendAuth.LastError
on the way out. Scrub once at the source so every consumer inherits it.

Fixes #17611

Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.24 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…ch to the repo default (#17614)

* πŸ› knowledge: show Clone & Index busy state and resolve blank branch to repo default

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* πŸ› knowledge: style failed git-source rows with classes, not inline styles

The error rows added for the Clone & Index failure state carried inline
style attributes and raw 0.7rem font sizes, which raised the operator
page's styling-debt counts and tripped TestStyleRatchet. Move them to
.kb-gs-error-* classes in nous.css using the --fs-xs token.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.25 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…/never-set reason (#17621)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.26 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
… instead of being cancelled (#17613)

* πŸ› mutation-advisory: give the script a wall-clock budget so the job completes instead of being cancelled

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* 🌱 ci: re-pin TRUSTED_SCRIPTS_TREE for the mutation-report budget change

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Links the held RFCs #17091 (Hive for teams), #12815 (containment
guardrails) and #17620 (workflow models) from the Later table so the
roadmap names the v7 direction instead of stopping at v6.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…aimed hive (v5 backport of #17594) (#17625)

An unclaimed hosted "available slot" hive has no real project.org β€” either
none at all, or the synthetic "available-<id>" / legacy "placeholder" org the
pool seeds into the slot β€” so it legitimately has no GitHub App installation.
The runtime still observed github_app_not_installed on every token mint and
fleetreport.Evaluate filed it as a [selfreport] fleet issue; #17600 was filed
by exactly such a slot running 5.209.6.

Evaluate now skips that one class when the org is empty or a placeholder. The
prefix list moves to config.PlaceholderOrgPrefixes / config.IsPlaceholderOrg,
shared with the dashboard's project_org health check. The local warning log,
runtime condition and dashboard onboarding banner are unchanged, and a hive
with a real org but no App installation still self-reports it.

Backport of fb8ac6d (#17594, v6). On v5 the PlaceholderAppID sentinel lives
in config.go rather than forge_config.go, so the helper is added there.

Closes #17600

(cherry picked from commit fb8ac6d)
Hive-Fix-Attempt: 3/6

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.211.27 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
clubanderson and others added 12 commits November 11, 2026 11:19
…17722)

Catch-up run actions/runs/43070009570 failed with 'Discord project table is
missing Devin, Copilot agent, Jules, Codex cloud'. Replaying the three
agent_output.json artifacts from this week through the gate surfaced:

- project rows: key on the first word of the GitHub project name
  (punctuation-stripped, case-insensitive) since Discord rows are abbreviated;
- table notes: the agent re-wraps them for Discord, so require the same
  provenance URLs instead of the same wording;
- licence inference: 'it does not mean no licence' and 'returned no licence,
  so it is unverified' are the disclaimers the prompt asks for and tripped the
  'no licen[cs]e' regex; scope the check to the sentence.

Run 2's output (19479a3) now passes the full gate offline; run 3's remaining
failure is a real agent typo in a ledger quote.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.219.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…M-assisted, inferred) (#17713)

* ✨ workflowmodel: ingest Tekton pipelines from a live cluster context

Add pkg/workflowmodel/ingest/cluster: lists tekton.dev Pipelines, Tasks,
PipelineRuns (newest N per pipeline) and Tekton Triggers objects from a
kube context via kubectl, serialises them as cluster/<ns>/<kind>/<name>.yaml
and feeds the existing file-based Tekton ingester so there is one parser.
Last run status per pipeline is recorded as an observed annotation and
coverage finding, never as an inferred lifecycle element. Clear errors for
missing CRDs, RBAC denials, unknown contexts and missing namespaces; caps
on namespaces, runs, objects and bytes.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ workflowmodel: ingest written process specs into inferred draft models

Add pkg/workflowmodel/ingest/spec. Markdown/plain text is split into
heading sections with line ranges; a deterministic stage turns step lists,
conditional sentences and role nouns into a compiling skeleton (states,
columns, chained transitions, manual guards, gates, roles). An optional
LLM stage asks a Completer to refine the skeleton with the Model schema
(reflected from the Go types), the fact vocabulary and the compiler's
refusal rules; the answer is parsed with DisallowUnknownFields, normalised
by Mark (inferred confidence on every state/event/gate, ingested origin,
spec:<heading>#L<a>-L<b> citations validated against real sections,
pipelines/sources/agents stripped, provenance ingested-unreviewed) and
compiled, with one retry quoting the diagnostics before falling back to
the skeleton. This is the only LLM seam in the workflow-model stack.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ dashboard: cluster and written-spec workflow ingest routes

Add POST /api/workflows/ingest/cluster, POST /api/workflows/ingest/spec
and GET /api/workflows/ingest/capabilities in a new handler file,
registered by one line from registerWorkflowRoutes. The cluster route
runs the kubectl-backed fetcher and the existing Tekton ingester; the
spec route runs the deterministic extractor and, when a model gateway is
configured and useLLM is on, the gateway-backed refinement through the
reviewer TurnRunner with a larger completion budget. Owner role, audit
workflow_ingest, same response shape as repo ingest plus source, llm
and sections. 422 when kube access or a gateway is missing.

Wire WorkflowRepoFile, WorkflowClusterRunner and WorkflowSpecLLM deps
from cmd/hive; document the three routes and their schemas additively
in dashboard/openapi.json.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ dashboard: cluster and written-spec panels on Workflows β†’ Ingest

Two collapsible panels appended to the Ingest view by a single guarded
hook in renderWorkflowIngest: From a cluster (context select from
kubectl's contexts or a text field, namespace, selector, all-namespaces,
observed-run list) and From a written spec (paste, URL or repository
file; a Use AI assistance checkbox shown only when the capabilities
route reports a gateway, LLM note and section list in the result). Both
reuse the repository ingest's result block, diagnostics and diagram.
Pure renderers over module state, token-only CSS in its own sheet, node
test for gating, modes, request validation and result rendering.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– workflow models: document cluster and written-spec ingest (phase 6)

Append the RFC phase 6 section to the design doc β€” data flow for both
sources, the kubectl seam, the observed-run rule, the LLM boundary and
what enforces it (strict unmarshal, Mark, Compile, one retry, fallback),
prompt outline, failure modes and caps β€” and add the changelog fragment.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 workflowmodel/spec: use reflect.Pointer in the schema walker

govet's inline check flags the reflect.Ptr alias.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…benchmarks (#17716)

* ✨ benchmarks: per-PR evidence export + opt-in publish to hivecommons/benchmarks

Every hive now contributes anonymized per-PR benchmark records (salted hive
hash; agent/harness/model/sandbox runtime/task kind/outcome/review quality)
to https://hivecommons.dev/benchmarks/, built from the review evidence
bundles it already seals. Publication is on by default; benchmarks.publish:
false opts out and benchmarks.repo_consent (default on) names only
GitHub-public repos.

Cadence is hub-driven and hourly: spoke -> POST /api/benchmarks/ingest on
the hub (heartbeat bearer, hash recomputed server-side) -> hub commits
data/fleet/<hash>/<YYYY-MM>.json to hivecommons/benchmarks via its App
identity -> Pages rebuild.

- pkg/benchmarks: record types, HiveHash, Convert, schema golden test
- spoke: GET /api/benchmarks/export?since=, benchmarks block in /api/status,
  hourly pusher, Settings -> Features -> Benchmarks toggles + hash
- hub: ingest, month-file store, hourly publisher, GET /api/hub/benchmarks
- evidence: Author.runtime / Author.task_kind stamped at bundle write
- docs/benchmarks.md, operator-reference, api-reference, changelog fragment

Refs #17694

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 benchmarks: keep pkg/dashboard import ratchets flat, add help mark

Move the converter to pkg/evidence/benchmarks (it is a view over evidence
bundles) so pkg/dashboard gains no new top-level dependency, and give the
read-only hive-hash field its ? help mark (#7256).

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 benchmarks: coverage for converter edge cases, config knobs, hub/spoke pushers

Also make the since-filter exclusive at the watermark so the hourly push
does not resend the newest PR every run.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.219.1 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…ate and export (#17706)

* workflowmodel: structural Diff, Confirm inferred→local, Profile.LabelDefs, store.NextVersion

Pure, deterministic model diff (columns/states/transitions/labels/rules/meta),
Confirm that clears inferred confidence and localises provenance, the label
vocabulary a profile reconciles, and the store's next free integer version.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* dashboard: workflow versions, diff, confirm and labels-preview routes

GET /api/workflows/{name}/versions, GET /api/workflows/{name}/diff?from&to
(fromName/toName for cross-model), POST .../{version}/confirm (owner,
audited workflow_confirm, 409 for hive-default) and GET .../{version}/labels.
Documented in dashboard/openapi.json.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* automerge: provision a bound workflow model's labels, re-provision on rebind

ensureStageLabels asks the stage engine's WorkflowFor lookup for the profile
bound to the repository and creates or recolours its LabelDefs after the
built-in family, memoised per repo and profile hash so a binding change takes
effect on the next pass. Unbound repositories take the pre-existing path
unchanged. Design doc section and changelog fragment.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* Workflow models: editor endpoints for YAML and unsaved-model simulate

Adds POST /api/workflows/yaml (model <-> YAML, inline errors) and
POST /api/workflows/simulate (body model + facts, same shape as the
stored-model variant), and lets POST /api/workflows assign the next
free version when meta.version is empty so the editor's Save never has
to guess. OpenAPI entries and handler tests included.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit d8949480e0f33151bb7417f6d370519246cbf70a)

* Workflow models: visual editor canvas, inspector, drawers and pure core

Adds js/config-workflows-editor.js (pure model/layout/diff/problems/svg
core plus the runtime: SVG canvas with lanes, chips, ports and edges;
drag, marquee, pan/zoom, minimap; palette; inspector; Problems/YAML/Diff/
Simulate drawers; undo/redo; save/save-as/revert; export) with
css/workflows-editor.css, wires the Editor nav item, Edit / Edit-a-copy
buttons and the ingest 'Open in editor' affordance into the library, and
pins the pure core under node in workflows_editor_ui_test.go.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit 16812a4519330e7bedfe955d816e425b45d0a94a)

* Workflow models: editor polish from browser smoke test, docs and changelog

Fix the YAML drawer losing newlines through esc(), restore canvas focus after
re-render so undo/redo shortcuts keep working, resolve export theme tokens from
the canvas element (light theme exported dark), hide edge labels on dense
models unless selected, and tighten inspector field layout. Append the Editor
section to docs/design/workflow-models.md and add the changelog fragment.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit 2c94cade8ea85a0b807366ac91c2a4b3edf7b736)

* Workflow editor: quiet orthogonal edge router with focus mode, bundling and fan collapse

Replace the one-bezier-per-transition edge layer in the editor canvas and
the read-only library diagram with a shared pure router (wfRouteEdges,
wfOrthoPath, wfEdgeChannels, wfEdgeCommonEvent): orthogonal polylines
through the lane gutters bundled per lane pair, same-lane edges stacked on
the lane margin, lane-skipping edges in corridors outside the lanes (back
edges above the headers, dashed/muted), no edge labels by default (hover or
select an edge, or the Labels toggle which skips the most common event),
focus mode on hover/selection that dims non-incident edges and lifts the
incident ones to the front, and +N fan collapse for >4 edges from one state
into one lane. Node tests cover bundling, back-edge placement, label
visibility, fan threshold and determinism; design doc updated.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…htly refresh, spoke import/publish (#17714)

* ✨ workflowmodel: signed bundle format and embedded CNCF corpus

Add pkg/workflowmodel/bundle: Export compiles a model and wraps it with
its profile and a sha256 of the canonical model JSON; Encode/Decode use
canonical (sorted-key) JSON; Verify recomputes the hash, recompiles the
model locally and compares the profile structurally so importers never
trust a published profile.

Add pkg/workflowmodel/ingest/corpus embedding the CNCF survey corpus
(262 projects / 299 repos) so the hub marketplace refresh and
cmd/workflow-survey share one list; the survey falls back to it when a
corpus directory has no projects.json.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ config: workflow.marketplace block (enabled, url, refresh_interval)

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ dashboard: workflow bundle export/import and hub marketplace proxy

GET /api/workflows/{name}/{version}/bundle exports a verified bundle;
POST /api/workflows/import verifies and recompiles locally before saving
(422 on verification failure). /api/marketplace/workflows proxies the
hub index with an ETag cache and serves the cached copy with stale=true
on hub outage; .../{name}/{version}/import and .../publish move bundles
between the library and the hub with the spoke's heartbeat credential;
/api/marketplace/refresh forwards an on-demand refresh. Owner-gated and
audited where the store or hub is written. Shared index types live in
pkg/workflowmodel/bundle so hub and spoke agree on the wire shape.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ hub: workflow marketplace catalogue with immutable bundles and corpus refresh

Adds an immutable, file-backed catalogue under the hub data dir
(marketplace/workflows/<name>/<version>.bundle.json + index.json) with
routes for the index (strong ETag / 304), per-bundle fetch, publish
(spoke heartbeat bearer or hub admin; curated/built-in tiers admin-only),
admin on-demand refresh and a status view. The refresh walks the embedded
CNCF corpus plus HIVE_HUB_MARKETPLACE_EXTRA_REPOS, records source SHA and
pipeline-file hash per repo, skips unchanged repos and publishes changed
ones as ingested-YYYYMMDD.N (tier ingested-unreviewed). Curated versions
are never overwritten; the index flags them newerIngestAvailable. A
nightly run (HIVE_HUB_MARKETPLACE_REFRESH_SCHEDULE, default 03:00 UTC)
starts with the background pollers and seeds an empty catalogue once a
GitHub token is present.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ dashboard UI: Workflows β†’ Marketplace view with import, publish and catalogue refresh

Adds a Marketplace item to the Settings β†’ Workflows nav that lists the
hub catalogue through the spoke proxy (tier badges, search, tier filter,
newer-ingest flag, reserved adoption/rating columns, stale banner when
the hub is unreachable), imports entries into the local library (the
spoke verifies and recompiles; nothing is bound) and lets owners publish
a library model to the hub after confirmation. New files only, plus
one-line hooks in config-workflows-library.js and the manifest.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– workflow models: document bundles, hub marketplace and spoke import/publish (RFC phase 7)

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 marketplace tests: drop fixed sleeps and unused field

Replace the two time.Sleep polls in the hub marketplace tests with
testutil.Eventually / direct cancel so the sleep ratchet stays at its
baseline, and remove the unused fakeHub.down field flagged by
golangci-lint.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– hub api-reference: refresh server.go line citations after rebase

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 marketplace UI test: loosen WF_LIB_VIEWS assertion to coexist with editor view

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.220.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…e, benchmarks publisher and 30 more)

Merge origin/v5 (v5.220.0, ac91993) into v6. Carried v5 PRs:

Workflow models RFC (Refs #17620):
- #17679 P0–P3a port: ingest, schema, compiler, DeriveFromModel, store, workflows API, repo bindings, tracker columns
- #17681 Settings β†’ Workflows tab (library, diagram, ingest)
- #17685 P4 versions, diff, confirm-inferred, label regeneration on bind
- #17688 simulate an issue/PR against a model
- #17708 P5 intake ingest (issue templates, triage, owners, branch rules)
- #17710 label GC on rebind + model-defined human-gate replies
- #17713 P6 cluster (Tekton) and written-spec ingest
- #17706 visual editor with live compile, YAML, diff, simulate, export
- #17714 P7 signed bundles, hub marketplace catalogue, spoke import/publish

Other v5 fixes and features:
- #17646 #17655 #17656 #17647 #17670 OpenShell sandbox runtime (ADR-0026 phase 1), preflight, terminal pane, docs
- #17638 upstream corporate forward proxy for TLS egress
- #17716 benchmarks per-PR evidence export + opt-in publish
- #17578 honour every configured trusted bot in the automerge lane
- #17680 proxy: GraphQL mutation gate no longer fails open
- #17674 skip ok-to-test post from read-only eligibility probe
- #17658 #17612 #17666 credential scrubbing in agent panes / logscrub
- #17585 memoise repos the App cannot label
- #17567 release hold on issue-via-PR row targets the covering PR
- #17569 #17613 mutation report verdict phase + wall-clock budget
- #17589 #17614 knowledge: inline field errors, Clone & Index busy state and default branch
- #17621 #17625 fleetreport/selfreport fixes
- #17705 #17711 #17722 competitor report publication-gate fixes
- #17709 inference: fully-qualify curlimages/curl
- #17633 Go 1.26.11 (GO-2026-6859); #17651 goose 1.59.0
- #17561 #17640 #17682 CI/DCO housekeeping; #17597 #17626 #17687 docs

v6-only deltas preserved over the v5 workflow code: stagelabels
CheckSummary.Missing ("missing" checks) in stageengine/workflow.go and
the simulate facts; BucketDependencyDashboard export-parity coverage.
Config keeps v6's config.go/project_config.go split with v5's
Workflow.LabelGC, Workflow.Marketplace, Network and Benchmarks added.
openapi.json, api-reference docs, CHANGELOG and NOTICE are unions on
the v6 base; static/index.html regenerated from manifest.txt.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 11, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@kubestellar-prow kubestellar-prow Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 11, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
c4298ba

ℹ️ Sentinel notice β€” informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head c4298bad62bd) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 23 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/changelog-fragment-guard.yml
    • .github/workflows/ci-runner-image.yml
    • .github/workflows/dco-post-merge.yml
    • .github/workflows/docs-index-reminder.yml
    • .github/workflows/mutation-advisory.yml
    • .github/workflows/pr-overlap.yml
    • .github/workflows/stream-image.yml
    • src/Dockerfile
    • src/Dockerfile.contributor
    • src/crux/go.mod
    • src/crux/proxy/rules.go
    • src/deploy/README.md
    • src/deploy/inference/vllm-deployment.yaml
    • src/deploy/openshell.md
    • src/go.mod
    • src/pkg/workflowmodel/ingest/testdata/k8s-owners/OWNERS
    • src/pkg/workflowmodel/ingest/testdata/k8s-owners/OWNERS_ALIASES
    • src/pkg/workflowmodel/ingest/testdata/md-template/.github/CODEOWNERS
    • src/pkg/workflowmodel/ingest/testdata/techdocs/.github/workflows/copilot-setup-steps.yml
    • src/pkg/workflowmodel/ingest/testdata/techdocs/.github/workflows/format-check.yml
    • src/pkg/workflowmodel/ingest/testdata/techdocs/.github/workflows/link-check.yml
    • src/pkg/workflowmodel/ingest/testdata/techdocs/.github/workflows/spell-check.yml
    • src/pkg/workflowmodel/ingest/testdata/techdocs/.github/workflows/trigger-contribute-site-netlify.yml
  • secret_exposure β€” workflow step routes secrets or the environment to a shell sink (Workflow change that prints, encodes or ships secrets off-host)
    • src/pkg/workflowmodel/ingest/testdata/techdocs/.github/workflows/trigger-contribute-site-netlify.yml
  • remote_code_execution β€” adds a remote-fetch-and-execute, decoded payload, reverse shell or embedded credential (Adds curl|sh, eval of encoded payloads, reverse shells or embedded private keys)
    • src/crux/agent/backend_auth_test.go
    • src/crux/logscrub/pane_test.go

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing

Head eca9b0dac.

⏱️ The 900s mutation budget ran out, so 8 package(s) were not fully mutated and the results below do not cover them:

  • pkg/dashboard: cut short (partial, no report)
  • pkg/evidence: skipped (not started)
  • pkg/fleetreport: skipped (not started)
  • pkg/github: skipped (not started)
  • pkg/hub: skipped (not started)
  • pkg/knowledge: skipped (not started)
  • pkg/stageengine: skipped (not started)
  • pkg/workflowmodel: skipped (not started)

❌ gremlins did not produce a report for 2 package(s), so no verdict can be derived from this run (see the job log):

  • crux/agent: gremlins exited 1
  • crux/sandbox: gremlins exited 1

gremlins found 9 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/crux/proxy/upstream_chain.go 22 CONDITIONALS_NEGATION
src/crux/proxy/upstream_chain.go 22 CONDITIONALS_NEGATION
src/crux/proxy/upstream_chain.go 54 CONDITIONALS_NEGATION
src/crux/upstreamproxy/upstreamproxy.go 228 CONDITIONALS_NEGATION
src/crux/upstreamproxy/upstreamproxy.go 263 CONDITIONALS_NEGATION
src/crux/upstreamproxy/upstreamproxy.go 277 CONDITIONALS_BOUNDARY
src/crux/upstreamproxy/upstreamproxy.go 313 CONDITIONALS_NEGATION
src/crux/upstreamproxy/upstreamproxy.go 353 CONDITIONALS_BOUNDARY
src/crux/upstreamproxy/upstreamproxy.go 478 CONDITIONALS_NEGATION

12 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/cmd/hive/workflow_ingest.go 42 CONDITIONALS_NEGATION
src/cmd/hive/workflow_ingest.go 44 CONDITIONALS_NEGATION
src/cmd/hive/workflow_ingest.go 45 CONDITIONALS_NEGATION
src/cmd/hive/workflow_ingest.go 59 CONDITIONALS_NEGATION
src/cmd/hive/workflow_ingest.go 63 CONDITIONALS_NEGATION
src/cmd/hive/workflow_ingest.go 63 CONDITIONALS_NEGATION
src/cmd/workflow-survey/main.go 335 CONDITIONALS_NEGATION
src/crux/proxy/github_proxy_connect.go 216 ARITHMETIC_BASE
src/crux/upstreamproxy/upstreamproxy.go 293 ARITHMETIC_BASE
src/pkg/config/agent_config.go 142 CONDITIONALS_NEGATION
src/pkg/config/config.go 308 CONDITIONALS_NEGATION
src/pkg/config/workflow_marketplace.go 25 ARITHMETIC_BASE

ℹ️ 7 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first lines added lines of each default-context hunk, so non-contiguous edits in one hunk are partly missed. This does not affect the verdict.

File Line Mutation
src/crux/proxy/linear_rules.go 385 ARITHMETIC_BASE
src/crux/proxy/linear_rules.go 385 INVERT_NEGATIVES
src/crux/proxy/linear_rules.go 447 ARITHMETIC_BASE
src/crux/proxy/linear_rules.go 447 CONDITIONALS_BOUNDARY
src/crux/proxy/linear_rules.go 447 CONDITIONALS_NEGATION
src/crux/proxy/linear_rules.go 447 INCREMENT_DECREMENT
src/crux/proxy/linear_rules.go 453 ARITHMETIC_BASE

Verdict: error (#17349).

…nowledge busy-state test to v6

- NOTICE regenerated with go-licenses v1.6.0 (module-level golang.org/x/sync entry)
- src/crux/config/sandbox_runtime.go split out of agent_config.go so the
  crux file-size ratchet (800 lines) holds after the OpenShell additions
- knowledge_git_source_busy.test.js exercises v6's _kbGitSourceFailed /
  kbGitSourceSubmitLabel implementation of the same behaviour

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the hivecommons org. You can then trigger verification by writing /verify-owners in a comment.

  • sig-widgets-reviewers
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • bob
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • sig-widgets-leads
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • alice
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@clubanderson
clubanderson merged commit 47144c1 into v6 Nov 11, 2026
134 of 146 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the topup/v6-from-v5-20261111 branch November 11, 2026 21:23
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants