Skip to content

✨ workflow models on v5: ingest, schema, compiler, DeriveFromModel, store, workflows API, repo bindings, tracker columns - #17679

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
workflowmodel/v5-p1-p3a
Nov 11, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
workflowmodel/v5-p1-p3a

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Ports the workflow-models RFC work (#17620) from v6 to v5 so v5 is the source of truth and the next top-up carries it forward cleanly. Two cherry-picks:

v5-specific resolution

  • project_config.go does not exist on v5 → WorkflowBindings added to ProjectConfig in config.go.
  • stagelabels.CheckSummary.Missing (🐛 fix(stage): a required check that never reported keeps the PR at 060 #16822) and BucketDependencyDashboard are v6-only → the "missing" checks fact value and that parity-sweep case are dropped here; the top-up will restore them.
  • dashboard/openapi.json: only the five /api/workflows* paths and six Workflow* schemas were inserted (no v6-only routes).
  • Regenerated: static/index.html, config golden, api-reference citations (327), import allowlist + import-count ratchet (59→60).

v5 impact

None for any hive: flag off, no repo bound, built-in derivers untouched; stage goldens byte-identical.

Tests: workflowmodel/stageengine/config/testutil/dashboard/cmd-hive green locally (only the known macOS-only /var-symlink failures). golangci-lint clean.

clubanderson and others added 2 commits November 11, 2026 07:34
…nd survey harness (#17620) (#17630)

* ✨ workflowmodel: phase-1 ingest (GitHub Actions, Tekton), renderers and survey harness (#17620)

Deterministic ingest of a repository's GitHub Actions workflows and Tekton /
OpenShift Pipelines resources into one content-hashed workflow model bound
onto the hive default lifecycle; Mermaid and Activity Monitor column
renderers; cmd/workflow-survey proving harness; golden fixtures from six
real repositories. Nothing wires into the stage engine yet.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* workflow-survey: make main testable, drop unused const

golangci-lint flagged maxFileBytes as unused and the coverage gate
hard-fails any new cmd package without tests. Split main into
realMain(args, stdout, stderr) and run over the curated fixture corpus
in-process (96.6% statement coverage).

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit a59684c)
…rkflows API, repo bindings, tracker columns (#17648)

* ✨ workflowmodel: lifecycle schema, compiler, hive-default generator, DeriveFromModel (#17620 P1)

Extends the v1alpha1 schema with columns, derivation, events, gates,
roles, agents, checks, bookkeeping, labels and meta; adds Compile with
coded refusals; generates hive-default from the stage table and the
engine's expected edges; adds stageengine.DeriveFromModel (builtin
delegation + rules evaluator) and Options.Workflow; adds the
workflow.enabled flag (default false, no wiring effect yet).

The PR stage-golden corpus derives identically under hive-default.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit 43eb8b2)

* ✨ workflow models P2: store, /api/workflows, repo bindings, engine wiring, tracker columns (#17620) (#17649)

* ✨ workflowmodel: store, /api/workflows, repo bindings (RFC #17620 P2a)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ stageengine: per-repo workflow binding, tracker workflows block (RFC #17620 P2b)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* workflow models P2: Settings/tracker UI, openapi, gates, docs (P2c)

Per-repo Workflow select on Settings → Repos, tracker workflows block
rendering (model column header, per-row strip, Not covered chevron),
openapi routes/schemas, import ratchet and settings-parity allowlist,
regenerated agent-runtime golden, phase-2 design notes and fragment.

Refs #17620

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* workflowmodel P2: refresh api-reference citations, tokenize badge padding, lower style ratchet baselines

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* testutil: allow pkg/dashboard → pkg/workflowmodel in import ratchet (RFC #17620 P2)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ workflowmodel: ingest → lifecycle models, /api/workflows/ingest, survey compile stats (RFC #17620 P3a) (#17652)

ingest.Lifecycle composes hive-default's compiled lifecycle with a
repository's pipelines: PR-verify pipelines on the CI / Review states with
citations, the post-merge chain as inferred columns after Merged,
provenance ingested-unreviewed. New pipeline.status fact (engine reports
unknown until post-merge runs are observed). ingest.ReadTree selects CI
files from a checkout. POST /api/workflows/ingest fetches a repo's default
branch read-only (or takes pasted files), compiles, optionally saves at the
next integer version. workflow-survey compiles every corpus repo's
lifecycle model: 317/317 compile, 0 refusals.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
(cherry picked from commit 1217d64)
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 11, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

hivecommons-hive Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • mobile-shots

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Evidence bundle `#176793712858` sha256:3f6f676d29f3613c91c6ba590e6c849dfd5c0143406f2f3ea405de22fbd04486 — download from the dashboard or `hivectl review evidence #17679`.

@hivecommons-hive
hivecommons-hive Bot merged commit 5a1f8cf into v5 Nov 11, 2026
87 of 93 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the workflowmodel/v5-p1-p3a branch November 11, 2026 14:42
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 3712858.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

⏱️ The 900s mutation budget ran out, so 2 package(s) were not fully mutated and the results below do not cover them:

  • pkg/stageengine: skipped (not started)
  • pkg/workflowmodel: skipped (not started)

❌ gremlins did not produce a report for 1 package(s), so no verdict can be derived from this run (see the job log):

  • pkg/dashboard: gremlins exited 137

2 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/cmd/hive/workflow_ingest.go 27 CONDITIONALS_NEGATION
src/cmd/hive/workflow_ingest.go 32 CONDITIONALS_NEGATION

Verdict: error (#17349).

hivecommons-hive Bot pushed a commit that referenced this pull request Nov 16, 2026
Removes src/cmd/workflow-survey/workflow-survey, a 4.4 MB compiled binary
that was committed by mistake in #17679. It is a build artifact and is
absent on v6. The Go sources (main.go, main_test.go) stay. Adds the path
to .gitignore so it cannot be re-added, and a changelog fragment because
changelog-fragment-guard treats any deletion under src/ as a code change.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant