Repository navigation
π dashboard: fold the human-gate verbs at render time; β¦ keeps its 44px tap target - #17515
Conversation
β¦px tap target The merged pill (#17505) folded its verbs with CSS β display:none on the trailing verbs and an always-rendered hidden menu β which the mobile-shots acceptance rejects: tracker-header-geometry hit-tests every button in .ham-badges, and tracker-phone-ergonomics measured the β¦ button at 28px because its tap-target rule used a child selector while the button sits inside .ham-gate-more-wrap. Now the row renders only the visible verbs (three on the strip tier, one plus β¦ at β€1100px via matchMedia, re-rendered on change); the overflow items wait in a <template> and are stamped into the row the first time β¦ opens; the tap-target sizing targets the descendant β¦ button. Fixes #17514 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Correctness review at 6176246.
1. Folded verbs escape the "settlingβ¦" disable β src/pkg/dashboard/static-src/js/tracker-human-gate.js:213
stageTrackerHumanGateSettling disables via gate.querySelectorAll('.ham-gate-act'), but the overflow items now live in <template class="ham-gate-menu-tpl"> (line 201), whose .content is not reachable by querySelectorAll. After an inline verb succeeds and the pill reads "settlingβ¦", opening β¦ for the first time stamps still-enabled menu items (line 226), so a second verb can post before the next snapshot re-renders the row. Before this PR the menu items were in-DOM and got disabled with the rest. tracker-actions.js:981 only guards on aria-disabled, so nothing else catches it.
gate.querySelectorAll('.ham-gate-act').forEach(b => b.setAttribute('aria-disabled', 'true'));
gate.querySelectorAll('template.ham-gate-menu-tpl').forEach(t => t.content.querySelectorAll('.ham-gate-act').forEach(b => b.setAttribute('aria-disabled', 'true')));
2. Changelog fragment is in the wrong place and won't be compiled β changed-gate-fold-tap-target.md:1 (repo root)
changelog.d/README.md says fragments live in changelog.d/ and must start with a - bullet; compile-changelog.sh does not read the repo root, so this entry is silently dropped at release. Meanwhile changelog.d/fixed-17515.md:1 carries only the PR title with the β¦ character stripped ("render time; keeps its 44px"). Suggest replacing the latter's content with the hand-written entry and deleting the root file:
--- a/changed-gate-fold-tap-target.md
+++ /dev/null
-Activity Monitor: the human-gate pill folds its verbs at render time ...
--- a/changelog.d/fixed-17515.md
+++ b/changelog.d/fixed-17515.md
-- dashboard: fold the human-gate verbs at render time; keeps its 44px tap target (#17515)
+- Activity Monitor: the human-gate pill folds its verbs at render time (three on the strip tier, one plus `β¦` at β€1100px), keeps the folded verbs in a template until `β¦` opens, and gives the `β¦` button its 44px tap target β the row holds no hidden buttons for the header-geometry probe to reject (#17514, #17515).Verified otherwise: STAGE_TRACKER_GATE_FOLD_QUERY (1100px) matches the .ham-head-cols breakpoint at tracker.css:1014, and the phone tier (max-width: 640px / coarse β€820px) sits inside it; closeAll (line 220) and the stamp path (line 226) handle both the template and already-stamped states.
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Read the diff against Finding (low) β misplaced changelog fragment at the repository root. What I verified in the code:
I have not run the mobile-shots harness; CI's Review findings from Read the diff against the v5 tree and the callers. The render-time fold looks correct to me; one stray file should go before this lands. Finding (low): What I verified, for the record:
clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Evidence bundle `#17515e92c3ca` sha256:25b987adc79011e13baf16cb9d8eb6f84abe61548f5ea209059ce2a0814a4f39 β download from the dashboard or `hivectl review evidence #17515`. |
There was a problem hiding this comment.
Read the diff against v5 plus the callers; the fold logic looks correct to me. One stray file to drop before merge.
Verified
tracker-human-gate.js:146STAGE_TRACKER_GATE_FOLD_QUERY = '(max-width: 1100px)'matches the stacked-head breakpoint attracker.css:1014(@media (max-width: 1100px)), so JS and CSS fold at the same width.- The
matchMediachange listener callsrenderStageTracker()with no args; that is the established pattern (tracker-display.js:137,tracker-filter-state.js:199) andrenderStageTrackerattracker-filter-render.js:60falls back to_stageTrackerwhendatais undefined. - Template stamping at
tracker-human-gate.js:226:menu.replaceWith(stamped)keeps the stamped<div class="ham-gate-menu">as the button'snextElementSibling, socloseAll'sm.previousElementSibling(line 219) still finds theβ¦button to resetaria-expanded. A re-render restores the template, which is fine since the row is rebuilt from scratch. - CSS: every
.ham-human-gate > .ham-gate-moreselector moved to a descendant selector (tracker.css:990β998,1266,1268), so the phone-tiermin-width: var(--tap-target)/::beforehit-area now reaches the button inside.ham-gate-more-wrap. stage_tracker_human_gate_test.goruns the pill under node (nowindow), so it pins the 3-verb strip tier and the template menu; the β€1100px branch is exercised only bymobile-shots, which is still in progress on this head.
Finding (low) β changed-gate-fold-tap-target.md is committed at the repository root. It reads like a changelog fragment (<category>-<slug>.md, prose body, no - bullet) that landed outside changelog.d/; the real fragment is changelog.d/fixed-17515.md, and the fragment guard passes because of that one. The root file would ship as a loose markdown file next to README.md/AGENTS.md and is never picked up by the changelog assembler. Suggest git rm changed-gate-fold-tap-target.md.
Nit, take or leave: changelog.d/fixed-17515.md lost the β¦ glyph (render time; keeps its 44px), leaving a double space.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at e92c3ca. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
/lgtm |
β¦17515 (#17524) The node harness that renders tracker rows has no matchMedia, so stageTrackerHumanGateVisible() always returned STAGE_TRACKER_GATE_VISIBLE under test and the one-verb-plus-β¦ arm (β€1100px) added by #17515 never ran. Stub window.matchMedia and assert the fold for four-, three- and two-verb pills, the strip-tier count when the query does not match, and the no-matchMedia fallback. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Fixes #17514
Follow-up to #17505 (merged with mobile-shots red β the workflow is reporting-only). The pill folded its verbs with CSS, which the acceptance probes reject:
tracker-header-geometry(844β2400px): "expected header control is not hidden" β the probe hit-tests everybuttonin.ham-badges; CSS-hidden rest verbs and the always-rendered hidden menu are buttons.tracker-phone-ergonomics(390Γ844):button.ham-gate-more28Γ48 β the tap-target rule used.ham-human-gate > .ham-gate-morebut the button sits in.ham-gate-more-wrap.Change:
tracker-human-gate.js:stageTrackerHumanGateVisible()β 3 verbs on the strip tier, 1 +β¦at β€1100px (matchMedia, re-render on change); overflow items wait in<template class="ham-gate-menu-tpl">and are stamped into the row the first timeβ¦opens.tracker.css: dropped thedata-ham-gate-overflow/ham-gate-act-restCSS fold; descendant selectors for theβ¦button so the 44px tap target applies.stage_tracker_human_gate_test.go: pins the template menu / no hidden buttons.static/index.html; changelog fragment at repo root.Verified locally with
src/scripts/dashboard-mobile-shots.mjsat 1440x1200@1 and 390x844@3 (light + dark): all activity probes pass.