Skip to content

πŸ› hold guard: announce a stopped held-PR update at INFO instead of WARN - #17525

Merged
hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-17520
Nov 10, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-17520

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #17520

The hold guard's "stopped keeping held PR mergeable" line is an expected steady state (a fork the App cannot push to, an up-to-date or conflicting PR, a workflow-permission or not-landed stop), and noteHeldPRUpdateStopped already posts the person-facing note on the PR once. Nothing is wrong with the hive, so WARN was the wrong level.

The self-report classifier collapses numbers, hashes and paths before counting, so one WARN each for five distinct held PRs inside ten minutes reads as the same line repeated five times and files a self-report. This moves the first announcement to INFO; dedupe, ledger and note behaviour are unchanged.

Same shape as #17297 (deferred base refresh to debug) and #17519 (freshness-guard line below WARN). The existing tests' log handlers filtered at Warn, so they now use Info, and a new test pins the announcement at level=INFO.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 10, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17506 🌱 Top up v6 with v5 (durable hosted hive.yaml, shared-CI deferral naming and 118 more) same files src/cmd/hive/main_helpers.go

@hivecommons-hive

hivecommons-hive Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Reviewed by reviewer β€” no findings.

Reviewer notes

Read src/cmd/hive/main_helpers.go and src/pkg/fleetreport/slogfeed/slogfeed.go on v6 β€” this looks correct to me, and the mechanism in the body holds.

What I verified

  • slogfeed.go:44 sets minLevel = slog.LevelWarn, so moving the announcement to INFO at main_helpers.go:548 does take it out of the self-report feed; that is the whole fix for [selfreport] unclassified_error_repeated: hold guard: stopped keeping held PR mergeable until its head or base movesΒ #17520, not a side effect.
  • The demotion doesn't hide a real failure: stopHeldPRUpdate is only reached from the classified terminal arms of ClassifyBranchUpdateError (main_helpers.go:434-444) and the two no-error stops at :412/:417. Transient failures (rate limit, 5xx, journal fence) take the default arm at :445-449 and stay at WARN under a different message, unchanged by this PR.
  • Dedupe (heldPRUpdateStopAnnounced), the ledger MarkUpdateStopped, and noteHeldPRUpdateStopped are untouched; the three existing tests only lower their handler threshold so they still see the line, and the new TestStopHeldPRUpdateAnnouncesAtInfoNotWarn pins level=INFO at Debug capture.

Body matches the diff. No findings.

Evidence bundle `#17525d0d1f16` sha256:acd94889bfa5d2681724fdaf0e26b3c8e7d55dfa3412909771e0b710ccec189b β€” download from the dashboard or `hivectl review evidence #17525`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 0b22971 into v6 Nov 10, 2026
86 of 93 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-17520 branch November 10, 2026 06:08
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: hold guard: stopped keeping held PR mergeable until its head or base moves

0 participants