Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.d/fixed-agent-github-cap-override-alone.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
- **A per-agent GitHub API hourly cap now applies without the fleet key.** `agents.<name>.github_api_hourly_cap` was read only when `agents.github_api_hourly_cap` was also set, so `agents.reviewer.github_api_hourly_cap: 600` on its own left the reviewer at the default 300. The override now applies on its own, and a replica or review head that has none of its own takes its base agent's. `0` still means no cap at either level. See [Runtime and quota](src/docs/operator-reference/runtime-and-quota.md).
- **A replica takes its base agent's GitHub API hourly cap even before the next reload.** A replica or review head (`reviewer-2`, …) with no `agents.<name>.github_api_hourly_cap` of its own now takes its base agent's override directly, so an override set on the base applies to its replicas at once instead of after the config is next reloaded. The lookup order is the agent's own value, then the base agent's, then `agents.github_api_hourly_cap`, then the default of 300; `0` means no cap at either level. See [Runtime and quota](src/docs/operator-reference/runtime-and-quota.md).
3 changes: 0 additions & 3 deletions src/pkg/config/github_api_budget.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@ func mappingNode(node *yaml.Node) *yaml.Node {
// or review head is built as a copy of the base, so it normally carries the
// base's value already; the lookup also covers a base override set after the
// copy was made), then agents.github_api_hourly_cap, then the default of 300.
// The override used to be read only when the fleet key was set as well, so
// agents.reviewer.github_api_hourly_cap: 600 on its own left the reviewer at
// 300.
func (c *Config) AgentGitHubAPIHourlyCap(agentName string) int {
if c == nil {
return DefaultAgentsGitHubAPIHourlyCap
Expand Down
5 changes: 3 additions & 2 deletions src/pkg/config/github_api_budget_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ agents:
}
}

// A per-agent override applies on its own: the fleet key used to be required
// too, so this left the reviewer at 300 (projectbluefin hive, 2026-11-09).
// A per-agent override applies with the fleet key unset. applyDefaults fills
// the fleet value in on every load, so this held before #17379 too; the test
// pins it.
func TestGitHubAPIBudgetOverrideWithoutFleetKey(t *testing.T) {
raw := `
agents:
Expand Down
Loading