Repository navigation
π [v6] proxy cap: correct #17379's changelog note (the per-agent cap was never ignored) - #17388
Conversation
β¦ents hivecommons#17379 said a per-agent agents.<name>.github_api_hourly_cap was ignored without the fleet key. It was not: every load runs applyDefaults, which fills the fleet value in, so the old guard never fired on a loaded config (hive reviewer on hivecommons#17379). What hivecommons#17379 adds is the base-agent fallback for replicas and review heads. The changelog note and comments now say that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Douglas Baggett <doug.baggett@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Looks correct to me β the factual claim this PR rests on checks out against the v6 tree.
src/pkg/config/load.go:92callsapplyDefaults()on every load, andsrc/pkg/config/defaults.go:128-130setsAgentsGitHubAPIHourlyCap = 300whenever it is0and unset. So on any loaded config the pre-#17379 early return (if c.AgentsGitHubAPIHourlyCap == 0 && !c.AgentsGitHubAPIHourlyCapSet { return Default }) could not fire: the field was either 300 or an explicitly-set value. The per-agent override was never skipped; the only case the old guard affected was a hand-builtConfig{}that bypassedLoad.- The rewritten fragment describes what #17379 actually adds β the
BaseAgentNamefallback atgithub_api_budget.go:165-169β and the lookup order it states matches the getter body line for line.
Text-only change (changelog fragment + two comments), CI green. Nothing to fix.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me; this is a text-only correction and the factual claim holds against the v6 tree.
What I checked:
- Pre-#17379 getter (
src/pkg/config/github_api_budget.go, removed hunk in #17379) returned early onc.AgentsGitHubAPIHourlyCap == 0 && !c.AgentsGitHubAPIHourlyCapSet, before consulting the per-agent override. Loadcallscfg.applyDefaults()unconditionally (src/pkg/config/load.go:92), andapplyDefaultssetsAgentsGitHubAPIHourlyCap = 300whenever it is zero and unset (src/pkg/config/defaults.go:128-130). So on any loaded config the old guard could not fire, and the per-agent override was already honoured. The old changelog's "left the reviewer at the default 300" described a path only reachable with a hand-built&Config{}, not an operator config.- The rewritten fragment's lookup order (own β base agent β fleet key β 300) matches the current getter (
github_api_budget.go:156-171), andsrc/docs/operator-reference/runtime-and-quota.md:166-169already says the same thing, so no doc drift is introduced.
No behaviour change; the three edits are the fragment and two comments, as the body says.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Looks correct to me; the correction is accurate against the v6 tree. I checked the claim rather than taking it from the body. Before #17379 ( What #17379 did add β the base-agent fallback at Text-only diff; no behaviour change. Nothing to request. Evidence bundle `#17388166d48a` sha256:fdf8f27c7fc60fe2aab75b95b174d3f397c3115909aff94c0c7948a8ecc2f0a3 β download from the dashboard or `hivectl review evidence #17388`. |
Summary
#17379's changelog note and comments describe a bug that did not exist. They say a per-agent
agents.<name>.github_api_hourly_capwas ignored unless the fleet key was also set. On a loaded config it was never ignored: every load runsapplyDefaults(src/pkg/config/load.go:92), which fills in the fleet value (defaults.go:128-130), so the old guard never fired. The hive reviewer pointed this out on #17379, and it merged before the correction. This PR changes only text: the changelog fragment now describes what #17379 actually adds (replicas and review heads take the base agent's override directly), and two comments are corrected.Files
changelog.d/fixed-agent-github-cap-override-alone.md: rewritten.src/pkg/config/github_api_budget.go: the getter's comment no longer claims the old bug.src/pkg/config/github_api_budget_test.go: the test comment says the case held before too.No behaviour change. Only
gofmt -lwas run locally.Refs #17379
π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1