Repository navigation
✨ Activity Monitor: shared-PR issues group under their primary row - #17333
Conversation
|
/lgtm |
|
/approve |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
1. 2. jsFunc(t, html, "stageTrackerLoadSharedCollapsed"),
jsConstLine(t, html, "STAGE_TRACKER_SHARED_COLLAPSED_KEY"),(and a Baseline: 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Two red checks on f5ae2e4 (v2 Tests → test (dashboard 2/4), test (dashboard shuffle 3/3), and coverage downstream) are both caused by this diff and each has a one-line fix. I read the failing job log and the tree at f5ae2e4.
1. TestStageTrackerCuesWiring — stage_tracker_cues_test.go:125: tracker-cues CSS must use tokens only, found "#1"
The guard scans the tracker-cues block (tracker.css lines 512–842 at this head) for #0…#f as a proxy for hex colours. The new comment at tracker.css:614 reads /* Shared-PR group (hivecommons/hive#17324 follow-up): … — the #17324 issue reference inside the block trips it. No colour literal was actually added; the ruleset uses tokens. Fix: cite the issue without the hash (e.g. hivecommons/hive 17324 or gh-17324), or move the comment above the block's start marker.
2. TestStageTrackerGroupByRepo ×4 — ReferenceError: stageTrackerLoadSharedCollapsed is not defined at stageTrackerLoadGrouping
tracker-filter-state.js:192 now calls stageTrackerLoadSharedCollapsed() from stageTrackerLoadGrouping(). stage_tracker_repo_grouping_test.go:240 lifts stageTrackerLoadGrouping into its Node harness but does not lift the new function (the new stage_tracker_shared_pr_group_test.go:23 does, which is why that test passes). Fix: add jsFunc(t, html, "stageTrackerLoadSharedCollapsed") and the STAGE_TRACKER_SHARED_COLLAPSED_KEY const to the harness in stage_tracker_repo_grouping_test.go — or guard the call with the file's existing typeof … === 'function' idiom.
I did not find anything wrong with the grouping logic itself on this pass; the review is limited to the CI failures. Not a duplicate of #17334 / #17337 — the three Activity Monitor PRs share tracker.css/activity-monitor.md/index.html but make distinct changes and git merge-tree shows no textual conflicts.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
The issues one PR closes together are one group of the list: a secondary issue's row always follows its primary (whatever the lead sort or a train put between them; the group takes the primary's place), draws as an indented child on a rail, and is rebound to the primary's own listing of the PR so both chevron strips light from the same snapshot. The primary's "also closes" pill carries a caret that folds the secondaries, remembered in localStorage under hive.tracker.shared.collapsed. A secondary whose primary is not a row of the list stays standalone as before. Fixes #17332 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…cker alone Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
f5ae2e4 to
69b9c15
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #17332
What
Shared-PR grouping in the Activity Monitor — the issues one PR closes together (#17292 primary, #17302 secondary, PR #17308) are one unit of the list.
stageTrackerSharedPRContiguousruns last inrenderStageTracker: every secondary issue row sits right after its primary, whatever the lead sort / train / preparation ordering put between them; the group takes the primary's place; several secondaries keep their lead order. A secondary whose primary is not a row of the list (filtered out, other page) stays standalone as before (stageTrackerAdoptOrphanPRspath untouched).drawn_underkept,also_closesdropped) before rows render, so both chevron strips light from one object of one payload tick. The server payload is not mutated (row copies).ham-shared-head/ham-shared-child/ham-shared-lastrow classes +data-ham-shared-under; a thin token-only rail from the primary's pill to the last child's elbow (reuses--line-strong,--sp-*).hamSharedToggle, same caret class as the repo group header), default expanded, persisted underhive.tracker.shared.collapsed; folded rows leave the list but still count in the total. Pill markup without a group is byte-identical to before.stage_tracker_shared_pr_group_test.go(adjacency with an unrelated row between, group sorts by primary, several secondaries, same-snapshot lit chevron, child/head classes, fold + persistence, primary-filtered-out fallback, cross-repo same number, unchanged pill) + a wiring/tokens-only check. Doc paragraph inactivity-monitor.md; changelog fragment.Kept out of
tracker-row-layout.jsexcept for the pill's optionalgroupargument (another PR edits that file for one-lit-chevron-per-row).