Skip to content

🐛 dashboard: widen the Recent merges popover so titles are readable - #17326

Merged
clubanderson merged 1 commit into
v5from
fix/recent-merges-popover-width
Nov 9, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/recent-merges-popover-width

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

What

The "Recent merges" popover (opened from the Merged N · x today · y this week pill in the Activity monitor's sticky bar) was capped at max-width: 34rem, so every PR title ellipsised at ~40 characters ("[v6] contributor container: put the hive knowledge b…").

  • .ham-merged-pop is now width: 52rem with max-width: min(calc(100vw - 2rem), calc(100% - 2 * var(--sp-2))) — capped to the viewport and to the sticky bar it is absolutely positioned in (that bar clips overflow, so a plain 100vw cap still cut the left edge off at 1440 with the sidebar open).
  • It stays right-anchored under the pill and grows leftward; verified on-screen at 1100, 1280 and 1440.
  • The row grid is already auto minmax(0,1fr) auto, so all extra width goes to the title column (340px → 627px at 52rem); the by … · lane · time meta column keeps its natural nowrap width. No font/size changes.
  • The merge-queue popover shares the class; it keeps its previous 22rem–34rem sizing via a new .ham-queue-pop rule.
  • The ≤720px phone tier (🐛 dashboard: phone layout for merged banners and toasts; drop Overview tile font override #17116) is a separate .hive-dialog.ham-pop-sheet and is unchanged — same 390-wide sheet, same column widths, before/after.

Screenshots

WebKit, 20-row fixture with long titles (harness: Playwright/WebKit serving the built bundle, same shape as src/scripts/dashboard-mobile-shots.mjs).

Before After
1440×900 544px popover, 20/20 titles clipped 832px popover, title col 627px, 7/20 (the 100+ char ones) clipped
1280×900 544px 832px, right edge = pill right edge, fully on-screen
390×844 full-width sheet full-width sheet, unchanged

1440×900 — before / after

Recent merges popover before, 544px wide, titles clipped
Recent merges popover after, 832px wide, titles readable

1280×900 — before / after

1280 before
1280 after

390×844 phone sheet — before / after (unchanged)

phone sheet before phone sheet after

The popover opened from the Merged pill was capped at 34rem, so every
PR title ellipsised at ~40 characters. Set it to 52rem, capped to the
viewport and to the sticky bar that clips it (it is right-anchored
under the pill and grows leftward). The title column is the grid's only
flexible track, so the width goes to titles; the by/lane/time meta
column keeps its natural nowrap width. The merge-queue popover keeps its
old 22–34rem sizing and the ≤720px phone sheet is a separate dialog and
is unchanged.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17325 🐛 Activity Monitor: secondary issue of a shared PR rides the PR's lane same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Reviewed by reviewer — no findings.

Reviewer notes

Read the stylesheet and the markup at this head; this looks correct to me.

  • The new .ham-queue-pop { width: auto; min-width: 22rem; max-width: 34rem; } (static-src/css/tracker.css:751) is live, not dead: the merge-queue dialog already carries both classes at static/index.html:8715 (class="ham-merged-pop ham-queue-pop"), and the rule follows .ham-merged-pop at equal specificity, so the queue popover keeps its previous sizing while only Recent merges (index.html:8713) widens.
  • The calc(100% - 2 * var(--sp-2)) cap resolves against the sticky bar: .ham-sticky is position: sticky (tracker.css:684), which is the popover's containing block, so the card cannot exceed the bar it is drawn in.
  • The ≤640px / coarse-pointer tier (tracker.css:754+) scopes every override under .ham-pop-sheet, which tracker-merged.js:800 builds as a separate dialog — the widened .ham-merged-pop rule does not reach it.
  • static-src/css/tracker.css and the generated static/index.html carry identical edits, and changelog.d/fixed-recent-merges-popover-width.md is present.

No findings. Not approving — that is a human's call.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Checked the two things a CSS-only change like this can get wrong:

  • Containing block. max-width: calc(100% - 2 * var(--sp-2)) on an absolutely positioned box resolves against the nearest positioned ancestor. #activity-monitor-merged-pop is a sibling of the .ham-merged-count pill (static-src/html/tracker.html:57-58), not a child, so the position: relative on the pill (tracker.css:705) does not capture it; the containing block is .ham-sticky (tracker.css:684, position: sticky), which is the bar the body describes. So 100% really is the bar width.
  • Shared class. #activity-monitor-queue-pop carries ham-merged-pop ham-queue-pop (tracker.html:60). The new .ham-queue-pop { width: auto; min-width: 22rem; max-width: 34rem } has equal specificity and comes later in the sheet (tracker.css:751 vs :739), so the merge-queue popover keeps its previous sizing exactly.
  • Phone tier. tracker-merged.js:791-800 moves the content into a separate .hive-dialog.ham-pop-sheet overlay, so the .ham-merged-pop width never applies there.

Changelog fragment present; index.html regenerated in step with static-src.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit cfdff40 into v5 Nov 9, 2026
89 of 94 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/recent-merges-popover-width branch November 9, 2026 01:33
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant