Repository navigation
🐛 dashboard: widen the Recent merges popover so titles are readable - #17326
Conversation
The popover opened from the Merged pill was capped at 34rem, so every PR title ellipsised at ~40 characters. Set it to 52rem, capped to the viewport and to the sticky bar that clips it (it is right-anchored under the pill and grows leftward). The title column is the grid's only flexible track, so the width goes to titles; the by/lane/time meta column keeps its natural nowrap width. The merge-queue popover keeps its old 22–34rem sizing and the ≤720px phone sheet is a separate dialog and is unchanged. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Reviewed by Reviewer notesRead the stylesheet and the markup at this head; this looks correct to me.
No findings. Not approving — that is a human's call. |
There was a problem hiding this comment.
Looks correct to me. Checked the two things a CSS-only change like this can get wrong:
- Containing block.
max-width: calc(100% - 2 * var(--sp-2))on an absolutely positioned box resolves against the nearest positioned ancestor.#activity-monitor-merged-popis a sibling of the.ham-merged-countpill (static-src/html/tracker.html:57-58), not a child, so theposition: relativeon the pill (tracker.css:705) does not capture it; the containing block is.ham-sticky(tracker.css:684,position: sticky), which is the bar the body describes. So100%really is the bar width. - Shared class.
#activity-monitor-queue-popcarriesham-merged-pop ham-queue-pop(tracker.html:60). The new.ham-queue-pop { width: auto; min-width: 22rem; max-width: 34rem }has equal specificity and comes later in the sheet (tracker.css:751vs:739), so the merge-queue popover keeps its previous sizing exactly. - Phone tier.
tracker-merged.js:791-800moves the content into a separate.hive-dialog.ham-pop-sheetoverlay, so the.ham-merged-popwidth never applies there.
Changelog fragment present; index.html regenerated in step with static-src.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
What
The "Recent merges" popover (opened from the Merged N · x today · y this week pill in the Activity monitor's sticky bar) was capped at
max-width: 34rem, so every PR title ellipsised at ~40 characters ("[v6] contributor container: put the hive knowledge b…")..ham-merged-popis nowwidth: 52remwithmax-width: min(calc(100vw - 2rem), calc(100% - 2 * var(--sp-2)))— capped to the viewport and to the sticky bar it is absolutely positioned in (that bar clips overflow, so a plain100vwcap still cut the left edge off at 1440 with the sidebar open).auto minmax(0,1fr) auto, so all extra width goes to the title column (340px → 627px at 52rem); theby … · lane · timemeta column keeps its natural nowrap width. No font/size changes.22rem–34remsizing via a new.ham-queue-poprule..hive-dialog.ham-pop-sheetand is unchanged — same 390-wide sheet, same column widths, before/after.Screenshots
WebKit, 20-row fixture with long titles (harness: Playwright/WebKit serving the built bundle, same shape as
src/scripts/dashboard-mobile-shots.mjs).1440×900 — before / after
1280×900 — before / after
390×844 phone sheet — before / after (unchanged)