Repository navigation
π± Forward-merge v5 into v6 (2 commits) - #17282
github-actions[bot] wants to merge 3 commits into
Conversation
The Copilot usage sniff (crux/proxy/github_proxy_copilot.go) logs "copilot sniff: upstream dial failed" at ERROR when it cannot reach the *.githubcopilot.com host it is MITMing - e.g. a dial timeout to telemetry.enterprise.githubcopilot.com. No log-fed class recognised the line, so five in ten minutes opened an unclassified_error_repeated self-report (#17262). It is the same symptom as the opaque-tunnel "proxy: CONNECT dial failed" (spoke cannot reach an agent-requested host), so count it under proxy_connect_dial_failed (github-proxy, medium) with that class's remedy. The regression row in TestRecurringRuntimeMessagesAreClassified fails on the parent (LogFedClass returns ""). Fixes #17262 Hive-Run: #17262 Hive-Plan: selfreport-unclassified-error-classification Hive-Spec: fleet-report#log-fed-classes Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
The one document a new driver wires up from (RFC crux#114 order-of-work item 7): S1βS7 composed end to end with curl and crux CLI forms, server config keys and flags, control-token vs lane-principal auth, the failure drills from the acceptance sections, a symptom β saved-record map, and what hive uses today vs. after the 2026-11-16 cutover. Linked from the design record, the documentation map and the v5 integration guide. Part of hivecommons/crux#114 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
b7c45a1 to
0661c1b
Compare
|
Diagnosis (hive scanner, read-only β nothing pushed; this branch is owned by the v6-topup workflow): The only red check is the probot
A forward-merge carries Root cause sits upstream of this PR: squash merges on hive/awaiting-ci: all required checks green; merge is a maintainer/tide decision β sweep will merge when it is listed eligible. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Review follow-ups (below
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Hive filed review findings that do not block this PR as backlog items:
Cap: 3 backlog item(s) per PR. |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to set the DCO check to pass on this forward-merge (the two flagged commits are already on v5 with mismatched sign-off identities, as in previous top-ups) or let the next top-up supersede it.
The merge itself is sound; the only thing blocking it is DCO, and that cannot be fixed from this branch.
What I verified
- Re-ran
git merge --no-ff 155d51f12ontoa32447e2e(the two parents of head0661c1b): the result is byte-identical to the PR head β zero diff. No manual edits were made during the merge. - Merging
0661c1binto currentv6(a11e466c5) produces no conflicts; the carried changes aresrc/pkg/fleetreport/runtime.go+ test (#17263), the crux integration-guide docs (#17283) and their changelog fragment. - The merge commit carries its own
Signed-off-by(the workflow uses--signoff,.github/workflows/v6-topup.yml:85-88).
Why DCO is red
The probot flags the two carried v5 squash commits, not the merge:
155d51fβ authorAndy Anderson <andy@clubanderson.com>, sign-offAndrew Anderson <andy@clubanderson.com>(name differs)c05ba93β authorKaribhou <157208370+Karibhou@users.noreply.github.com>, sign-offKaribhou <Karibhou@users.noreply.github.com>(email differs)
Both are already merged on v5; rewriting them here would make the forward-merge diverge from v5. Previous forward-merges landed as real merge commits (134a8c279, 84b42eabe), so this has presumably been overridden before. Note that the c05ba93 mismatch will recur on every forward-merge of that author's squashes until their local user.email matches the GitHub noreply address with the numeric prefix.
I have not changed anything on this PR.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @0661c1b, 70/70 checks green, DCO yes, soak 0s of 10m0s. What to do: approve this head ( How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Fix-before-new check (hive scanner) β nothing to push on The only red check is probot Rewriting this branch into cherry-picks would break the top-up workflow's merge contract, so no force-push. What holds the PR is the π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Automated v5 β v6 top-up (#7563, Track 7).
Carries 2 commit(s) from v5 onto v6.
This runs on every push to v5 (v5 only moves when a v4βv5 top-up or a v5 PR merges), plus a daily safety net, so v6 feature work never ages against a stale base.
Opened by .github/workflows/v6-topup.yml. If this merge conflicts the workflow fails instead of opening it β a conflicting forward-merge is a human decision (see #7199).