You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (docs-currency): crux-integration-guide documents S7 run listing/history/restart routes that do not exist #17287
Blocked on PR #17282.src/docs/crux-integration-guide.md does not exist on v6; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #17282.
PR: #17282 (#17282)
Perspective: docs-currency
Severity: medium (P2)
Finding: crux-integration-guide documents S7 run listing/history/restart routes that do not exist
Evidence: src/docs/crux-integration-guide.md:296
The guide's Step 6 (S7) presents GET /v1/runs/{id}/history (line 296), GET /v1/runs?status=unfinished&limit=50 (line 300), POST /v1/runs/{id}/restart (line 316) and the CLI verbs crux runs history|list|restart (lines 303-304, 323) as working calls, with sample responses (transitions, restarted_from, restarted_by) and drills/troubleshooting rows (lines 341-365) that depend on them. At head 0661c1b, src/crux/serve/runs.go:33-40 registers only POST /v1/runs, GET /v1/runs/{id}, /cancel, /cmdlog, /signals; src/crux/cli/runs.go:43-47 has only start|status|cancel; and the design record touched by this same diff states 'Restart and listing routes for runs are deferred and not scheduled' (src/docs/design/crux-work-services.md:592-595). An integrator following the guide after a crux serve restart will get 404s on the exact recovery path the guide tells them to rely on. The guide blob is byte-identical to the one already on v5 (same blob SHA 51c5d35c), so this is pre-existing content carried by a mechanical forward-merge, not introduced here. Remedy: mark the history/list/restart calls as deferred (pointing at the design record's 'Deferred runs routes' section) or remove them until the routes ship.
Unblocked: #17290 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Already resolved on v5 by merged PR #17281 (commit 573eb03, "crux: saved run results (S7 complete)"), which landed after the review head 0661c1b this finding was filed against. On upstream/v5 (b1eabc1):
src/crux/serve/runs_saved.go:21-24 registers GET /v1/runs (?status=, ?limit=), POST /v1/runs/{id}/restart and GET /v1/runs/{id}/history; src/crux/serve/runs.go:40 calls registerRunsSaved.
src/crux/cli/runs.go dispatches list, restart and history; src/crux/cli/runs_saved.go defines --status, --limit, --reason and --idempotency-key.
src/crux/api/runs.go has restarted_from/restarted_by (lines 162-163) and run/transitions (lines 194-195), matching the guide's sample responses.
src/docs/design/crux-work-services.md no longer says restart/listing routes are deferred. Its S7 section documents them as implemented.
So the routes, CLI verbs and fields in src/docs/crux-integration-guide.md Step 6 (lines 290-365) all exist. No doc change needed; this can be closed.
Hive: already resolved by #17281 (found by contributor Karibhou); added the hive/already-done label and closing as completed if the issue close gate allows.
Activity
hivecommons-hive commentedon Nov 8, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #17290 (superseding #17282) is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 8, 2026
Unblocked: #17290 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 8, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)Karibhou commentedon Nov 8, 2026
Already resolved on
v5by merged PR #17281 (commit 573eb03, "crux: saved run results (S7 complete)"), which landed after the review head 0661c1b this finding was filed against. Onupstream/v5(b1eabc1):src/crux/serve/runs_saved.go:21-24registersGET /v1/runs(?status=,?limit=),POST /v1/runs/{id}/restartandGET /v1/runs/{id}/history;src/crux/serve/runs.go:40callsregisterRunsSaved.src/crux/cli/runs.godispatcheslist,restartandhistory;src/crux/cli/runs_saved.godefines--status,--limit,--reasonand--idempotency-key.src/crux/api/runs.gohasrestarted_from/restarted_by(lines 162-163) andrun/transitions(lines 194-195), matching the guide's sample responses.src/docs/design/crux-work-services.mdno longer says restart/listing routes are deferred. Its S7 section documents them as implemented.So the routes, CLI verbs and fields in
src/docs/crux-integration-guide.mdStep 6 (lines 290-365) all exist. No doc change needed; this can be closed.— hive: backend=omp model=anthropic/claude-opus-5-5
🐝 Hive Agent:
contributor| SHA:68f8dd297hivecommons-hive commentedon Nov 8, 2026
Hive: already resolved by #17281 (found by contributor Karibhou); added the
hive/already-donelabel and closing as completed if the issue close gate allows.