Skip to content

πŸ› dashboard: phone layout for merged banners and toasts; drop Overview tile font override - #17116

Merged
clubanderson merged 2 commits into
v5from
fix/mobile-dashboard-layout
Nov 7, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/mobile-dashboard-layout

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Two phone-only dashboard bugs reported by @clubanderson from the candidate channel.

Merged banners / toasts on a phone

.merge-banner was a fixed 26rem card bottom-right with a single-line ellipsised title (~30 chars), the lane/merger/time tail cut off, the repo chip blown up to a 33Γ—44 block by the ≀768px button { min-height: 44px } rule, and "Open on GitHub" (an <a>, exempt from that rule) sitting out of line with its button neighbours. Up to five stacked.

Now at ≀480px:

  • the stack spans the width above the home indicator (--safe-area-bottom);
  • title wraps to two clamped lines; the (lane, by, hh:mm) tail is its own small mono line (title/meta are now separate spans, full line still in the title attribute);
  • Show row Β· Open on GitHub Β· All merges sit in one row with normal tap padding; the Γ— is a 40px target;
  • a tap anywhere on the banner (outside its links) dismisses it;
  • only the newest STAGE_TRACKER_MERGE_BANNER_PHONE_MAX (3) banners are visible; older ones hide behind a "+N more" pill that opens the Merged list; the layout re-runs on add, dismiss and on crossing the breakpoint;
  • #toast-container toasts likewise span the width under the notch and wrap anywhere.

Desktop markup/geometry is unchanged (verified at 1280px: identical banner/toast rects before and after).

Overview KPI tiles "large font"

#16613 added a ≀720px override bumping .overview-kpi-label / .overview-kpi-subline to --fs-base / --fs-md, believing --fs-2xs was undefined outside .config-modal. tokens.css/base.css have defined --fs-2xs at :root since #13989, so the override only enlarged the tiles (13.1px/14.7px vs 9.6px on desktop) β€” the "bad" screenshot on the candidate channel (sha 8565377) vs the good edge build (3820712). The override is removed; the tiles keep --fs-2xs at every width.

Tests

stage_tracker_cues_test.go covers the title/meta split, the banner-body dismiss target, the link data-stop, and the phone cap / pill count tracking dismissals (and that a desktop hides nothing).

static/index.html regenerated via webstatic/gen (-check passes).

Screenshots (390px)

Merged banners + toasts β€” before after
merged banners before, 390px merged banners after, 390px
Overview tiles β€” before (large label/subline) after
overview before, 390px overview after, 390px

…w tile font override

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 7, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • runtime-tests

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the code at e591e65 rather than the diff alone; this looks correct to me.

What I checked:

  • Tap-anywhere dismiss vs. inner controls β€” the document click handler resolves e.target.closest('[data-action]') (static-src/js/tooltips-dialogs.js:227), so the close button, Show row, All merges and the repo chip (hamRepoChip, tracker-row-layout.js:389) each win over the banner's own hamBannerDismiss. "Open on GitHub" only receives stopPropagation; preventDefault requires data-prevent="1" (tooltips-dialogs.js:221-222), so the link still navigates.
  • hidden on the banners β€” .merge-banner is display: grid, which would otherwise beat the UA [hidden] rule; tracker.css:737 adds .merge-banner[hidden] { display: none; } (and :763 for the pill), matching the repo's existing idiom.
  • Re-layout β€” runs on add, on both dismiss paths (reduced-motion and animationend), and on the matchMedia change event; the module-load listener is guarded for environments without matchMedia, which is why the Node harness still loads it.
  • KPI override removal β€” --fs-2xs is defined at :root in base.css:29, so the πŸ› dashboard: keep Overview KPI tiles inside the phone viewport after a restartΒ #16613 override was only inflating the tiles as the body says.

CI was still running at review time; nothing above depends on it.

…tdown node test

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at e591e65, not just the diff. This looks correct to me.

What I verified:

  • Tap-to-dismiss vs. links. The document click dispatcher (static-src/js/tooltips-dialogs.js:208-211) resolves e.target.closest('[data-action]') and invokes only that one action, and it calls preventDefault only when data-prevent="1" is set. So a tap on Open on GitHub (data-action="hamBannerOpenLink" data-stop="1", tracker-merged.js:1223) navigates and does not reach the banner's hamBannerDismiss; a tap on the body does. The data-stop is belt-and-braces here (single document listener), which is fine.
  • The +N more pill is actually tappable. .merge-banners is pointer-events: none; the phone rule at static-src/css/tracker.css:762 sets pointer-events: auto on .merge-banner-more, so it is.
  • Tokens. --safe-area-top/bottom (static/tokens.css:157,159), --text-faint (:63), --r-pill (:48) and --fs-2xs (:22) are all defined under :root { (tokens.css:16), and index.html:14 links /tokens.css. That also confirms the Overview claim: .overview-kpi-label/-subline already use var(--fs-2xs) (overview.css:32-33), so dropping the ≀720px override leaves them at .6rem everywhere.
  • Layout bookkeeping. stageTrackerMergeBannerLayout is re-run on add, on both dismiss paths (reduced-motion and animated), and on the matchMedia change event; the eviction loop now counts only .merge-banner children so the pill never displaces a real banner. The node test covers the hidden set, the pill count after each dismissal, and the desktop no-hide case.

One note, not a defect: hidden banners keep their countdown running (toastCountdownBar starts before layout), so on a phone the fourth/fifth merge can expire without ever being seen. The +N more pill opens the Merged list, which covers that; just flagging the behaviour is intentional-by-construction rather than tested.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit 1c3e1e0 into v5 Nov 7, 2026
81 of 82 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/mobile-dashboard-layout branch November 7, 2026 22:23
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant