Repository navigation
π dashboard: phone layout for merged banners and toasts; drop Overview tile font override - #17116
Conversation
β¦w tile font override Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Read the code at e591e65 rather than the diff alone; this looks correct to me. What I checked:
CI was still running at review time; nothing above depends on it. |
β¦tdown node test Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Read the tree at e591e65, not just the diff. This looks correct to me.
What I verified:
- Tap-to-dismiss vs. links. The document click dispatcher (
static-src/js/tooltips-dialogs.js:208-211) resolvese.target.closest('[data-action]')and invokes only that one action, and it callspreventDefaultonly whendata-prevent="1"is set. So a tap onOpen on GitHub(data-action="hamBannerOpenLink" data-stop="1",tracker-merged.js:1223) navigates and does not reach the banner'shamBannerDismiss; a tap on the body does. Thedata-stopis belt-and-braces here (single document listener), which is fine. - The
+N morepill is actually tappable..merge-bannersispointer-events: none; the phone rule atstatic-src/css/tracker.css:762setspointer-events: autoon.merge-banner-more, so it is. - Tokens.
--safe-area-top/bottom(static/tokens.css:157,159),--text-faint(:63),--r-pill(:48) and--fs-2xs(:22) are all defined under:root {(tokens.css:16), andindex.html:14links/tokens.css. That also confirms the Overview claim:.overview-kpi-label/-sublinealready usevar(--fs-2xs)(overview.css:32-33), so dropping the β€720px override leaves them at.6remeverywhere. - Layout bookkeeping.
stageTrackerMergeBannerLayoutis re-run on add, on both dismiss paths (reduced-motion and animated), and on thematchMediachangeevent; the eviction loop now counts only.merge-bannerchildren so the pill never displaces a real banner. The node test covers the hidden set, the pill count after each dismissal, and the desktop no-hide case.
One note, not a defect: hidden banners keep their countdown running (toastCountdownBar starts before layout), so on a phone the fourth/fifth merge can expire without ever being seen. The +N more pill opens the Merged list, which covers that; just flagging the behaviour is intentional-by-construction rather than tested.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Two phone-only dashboard bugs reported by @clubanderson from the candidate channel.
Merged banners / toasts on a phone
.merge-bannerwas a fixed 26rem card bottom-right with a single-line ellipsised title (~30 chars), the lane/merger/time tail cut off, the repo chip blown up to a 33Γ44 block by the β€768pxbutton { min-height: 44px }rule, and "Open on GitHub" (an<a>, exempt from that rule) sitting out of line with its button neighbours. Up to five stacked.Now at β€480px:
--safe-area-bottom);(lane, by, hh:mm)tail is its own small mono line (title/meta are now separate spans, full line still in thetitleattribute);STAGE_TRACKER_MERGE_BANNER_PHONE_MAX(3) banners are visible; older ones hide behind a "+N more" pill that opens the Merged list; the layout re-runs on add, dismiss and on crossing the breakpoint;#toast-containertoasts likewise span the width under the notch and wrap anywhere.Desktop markup/geometry is unchanged (verified at 1280px: identical banner/toast rects before and after).
Overview KPI tiles "large font"
#16613 added a β€720px override bumping
.overview-kpi-label/.overview-kpi-sublineto--fs-base/--fs-md, believing--fs-2xswas undefined outside.config-modal.tokens.css/base.csshave defined--fs-2xsat:rootsince #13989, so the override only enlarged the tiles (13.1px/14.7px vs 9.6px on desktop) β the "bad" screenshot on the candidate channel (sha 8565377) vs the good edge build (3820712). The override is removed; the tiles keep--fs-2xsat every width.Tests
stage_tracker_cues_test.gocovers the title/meta split, the banner-body dismiss target, the linkdata-stop, and the phone cap / pill count tracking dismissals (and that a desktop hides nothing).static/index.htmlregenerated viawebstatic/gen(-checkpasses).Screenshots (390px)