Skip to content

πŸ“– proposal: Nous β†’ Spek β€” the winning experiment as a spek-new source - #17106

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
hive/adopt-17063
Nov 7, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
hive/adopt-17063

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Supersedes #17063 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

Refs #17020 β€” does not close it. The page is a straw man for the Nous conversation that issue asks for; #17020 stays open until the Nous team answers the "Open questions for the Nous team" section (winning-candidate definition / Findings Review gate, who assembles the artifact, patch-vs-intents, where the artifact is published, the campaign↔run join id, and who writes the Hive-shaped ledger keys). Once agreed, a follow-up PR will carry the Hive change and close the issue.

This branch is #17063's head edb20e47ddc1 as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: contributor-lane:changes-requested.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Design-only straw man for the Nous team conversation #17020 asks for.
Records what the external Nous framework leaves on disk for a winning
candidate (best_found.json, meta_findings.json deployment_recommendation,
findings, bundle code_changes), what Hive reads of it (ledger.json and
principles.json at boot, in a vocabulary the framework's own ledger rows
do not share), and what spek-new accepts (one sources[].uri). Proposes an
artifact shape, publishing it as a GitHub issue so spek-new can start from
the link with no Hive or Spek change, and lists the open questions.

Refs #17020

Hive-Run: #17020
Hive-Plan: #17020 proposal
Hive-Spec: nous-spek-source#straw-man
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 7, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17126 ✨ knowledge: review flow and never-prime for CLI auto-memory drafts, legacy drain same files src/docs/design/README.md
#17123 ✨ knowledge: finish CLI memory drain phase 1 β€” dedup tags, spool, draft create path same files src/docs/design/README.md

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 7, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether merging this design-only straw man should close #17020 (the PR body says Closes #17020, and v5 is the default branch so it will), or whether the body should carry only Refs #17020 as the original commit does, keeping the issue open for the Nous-team questions the document itself lists as unanswered.

The content is fine; the issue link is the one thing a person has to settle before this merges.

The mismatch

  • PR body: Closes #17020 and Refs #17020 on consecutive lines. Only the first one has an effect β€” v5 is the repository default branch, so GitHub will close #17020 when this merges.
  • Original commit edb20e4 (@Karibhou, preserved in this adoption) says Refs #17020 only, and its message calls the doc a "design-only straw man for the Nous team conversation #17020 asks for".
  • src/docs/design/nous-spek-source.md:3 β€” "Status: proposed β€” design only, no Hive change."; :129 β€” "## Open questions for the Nous team"; :147 β€” "## What Hive would change, once agreed".
  • #17020 itself: "Placeholder for a direction, not a spec yet … No Hive change is proposed yet; this issue exists so the direction has a home and can be linked from the Nous work."

So merging as-is closes the direction's "home" while the direction is still open. If that is intended (the straw man is the home now), fine β€” but then the stray Refs line should go. If not, drop Closes and keep Refs #17020 with a note on what remains (the Β§Open questions).

What I checked in the doc

  • bin/nous-install.sh exists at this head as the doc says, and the ledger.json / principles.json boot-read it describes (:60-63) matches what src/pkg/convergence references; I did not independently verify the Nous-side file shapes (best_found.json, meta_findings.json) against the pinned external commit.
  • src/docs/design/README.md:201-209 adds the index entry in the same form as its neighbours, with the status marker up front.

No executable change; nothing else blocking from me.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot changed the title πŸ“ proposal: Nous β†’ Spek β€” the winning experiment as a spek-new source πŸ“– proposal: Nous β†’ Spek β€” the winning experiment as a spek-new source Nov 7, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: retitled to πŸ“– proposal: (the pinned PR Type verifier rejects πŸ“, see #17105) and merged v5 in so the link check runs against the CHANGELOG fix from #17096. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Read the page against the tree at d71b851. Design-only, no behaviour change, and the "What exists today" section checks out against the code it cites:

  • loadNousStateFromPaths (src/cmd/hive/main.go) reads only ledger.json / principles.json under /var/run/nous/governor (main.go:6864); nothing reads best_found.json or meta_findings.json.
  • nousExperimentRow / nousExperimentProgress / nousOutputs live in src/pkg/dashboard/api_nous_progress.go and do look for the Hive-shaped keys the page lists (type at :221/:238, hypothesis at :244, pr_url at :502); nousRepoOnlyLedger is in src/pkg/dashboard/nous_self_guard.go.
  • pkg/nous campaigns.json (campaign.go:45), bin/nous-install.sh, bin/nous-sync.py, and the strategy-lab.md#the-experiment-loop / spektacular.md#publish-hand-off anchors all exist.

The README index entry matches the page's status line. Refs #17020 (not Closes) is right for a straw man whose open questions are addressed to the Nous team; the body says what remains and why. Nothing blocking from my side β€” CI is green apart from tide pending.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read at head d71b851. The two files are content-identical to #17063's edb20e4 (only the design/README.md hunk offset moved with the rebase), so the citation checks already done there stand; nothing new in the diff itself.

The one open ask from #17063 was carried over unresolved, and the adoption made it worse. This body now contains both

Closes #17020
Refs #17020

GitHub honours the Closes, and v5 is the default branch, so merging closes #17020. The page says that must not happen yet: src/docs/design/nous-spek-source.md:3-7 β€” "Status: proposed β€” design only … the questions the Nous team has to answer before anyone writes code" β€” and the whole ## Open questions for the Nous team section at :129 is addressed to an issue that is still open. The original author's body (#17063) stated the intent explicitly: "Refs #17020 β€” the issue stays open".

Fix is body-only, no push: delete the Closes #17020 line and keep Refs #17020 (the Nous team still has to answer the open-questions section; design only). Since this is a hive-owned branch the fix agent can do that edit directly.

Everything else looks correct to me as a proposal document: design-only, no Hive behaviour change, README index entry follows the existing β€” **status.** #issue: shape.

Evidence bundle `#17106d71b851` sha256:107d81dbeaa1c8a1b58c34f16cacf0753670c4298ea17b44311f06651c392240 β€” download from the dashboard or `hivectl review evidence #17106`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read both files. The design doc's code references check out on v5: loadNousStateFromPaths is at src/cmd/hive/main.go:6872, the id fallback chain id/experiment_id/experimentId/name is at src/pkg/dashboard/api_nous_progress.go:242, and src/pkg/nous exists. Its relative links resolve: src/docs/spektacular.md:84 (## Publish hand-off) and src/docs/strategy-lab.md:281 (### The experiment loop), plus the new index entry in src/docs/design/README.md. Content looks fine to me.

The red checks are not caused by the diff:

  • PR Type: this repo accepts only ⚠ ✨ πŸ› πŸ“– πŸš€ 🌱 as title prefixes; πŸ“ is not one of them. Retitle to πŸ“– docs: proposal β€” Nous β†’ Spek … (keeps the same meaning and passes the check).
  • Docs Link Check: the only failure is CHANGELOG.md: broken link 'url', pre-existing on v5 and fixed by #17096; it clears on rebase after that merges.

One body nit: it has both Closes #17020 and Refs #17020 β€” keep just Closes #17020 if this design doc is what #17020 asked for.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 7, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 7, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 9628191 into v5 Nov 7, 2026
99 of 103 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-17063 branch November 7, 2026 23:47
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant