Repository navigation
π docs: refresh Codex model snapshot provenance - #16965
Conversation
Hive-Run: #16961 Hive-Plan: codex model snapshot refresh Hive-Spec: issue-16961#model-catalog Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
static/index.html is generated by the byte-exact concatenation of static-src/ (pkg/dashboard/webstatic.TestIndexHTMLIsGenerated), so the provenance comment has to change in backends-tokens.js as well or the generated artifact drifts from its sources. Refs #16961 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Both blockers from #16962 are resolved on this head; looks correct to me.
- Generated bundle is consistent. Re-ran the generator (
go run ./pkg/dashboard/webstatic/gen -src pkg/dashboard/static-src -out β¦, persrc/pkg/dashboard/webstatic/indexgen.go:20) against6977fa2andcmpagainst the committedsrc/pkg/dashboard/static/index.htmlis byte-identical βTestIndexHTMLIsGeneratedshould pass now that the edit lives instatic-src/js/backends-tokens.js:107-108. - Changelog fragment
changelog.d/changed-16965.mduses the<category>-<pr>.mdshape the guard requires; the check is already green. src/scripts/check-cli-model-lists.sh:65reads the first version aftermatches codexonsrc/pkg/dashboard/cli_models.go:409β0.166.0, which equalssrc/Dockerfile:319(ARG CODEX_VERSION=0.166.0) on this base, so the script is quiet. The one::warning::it prints (claudePinnedCLIModelscomment) is pre-existing onv5, not from this diff.
One non-blocking note for whoever lands #16873 afterwards: once the pin moves to 0.167.0, line 409 still reads 0.166.0 first, so the script will warn again even though and 0.167.0 is on line 410. The script only exits non-zero under HIVE_MODEL_CHECK_STRICT=1, so it is a follow-up wording tweak, not a defect here. Not something I could verify: the claim that the 0.166.0 and 0.167.0 catalogs are identical rests on the live captures described in the comment; the id list itself is unchanged in this diff.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #16962 (adopted in place, re-homed because a hive commit on the contributor branch cannot carry a squash-safe sign-off; original commits by @Karibhou preserved).
Closes #16961
This branch is #16962's head
e235f2886b00as pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:reviewer-verdict:changes_requested.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Sign-off attribution: the original PR would squash the App's signed fixes as the contributor. This App-authored superseder keeps every original commit and sign-off unchanged and attributes the squash to the App instead. DCO and all merge gates still apply here.