Repository navigation
Conversation
Hive-Run: hivecommons#16961 Hive-Plan: codex model snapshot refresh Hive-Spec: issue-16961#model-catalog Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Two concrete blockers, both in CI already and both mechanical; the comment text itself matches what #16961 asked for.
1. static/index.html is a generated file and was edited directly β test (rest 3/4) fails on TestIndexHTMLIsGenerated (src/pkg/dashboard/webstatic/indexgen_test.go:28): "static/index.html differs from the concatenation of static-src/ (first difference at line 35435, byte 70)". The dashboard bundle is concatenated from src/pkg/dashboard/static-src/; the comment you changed lives in src/pkg/dashboard/static-src/js/backends-tokens.js. Edit it there, run make dashboard-gen (go generate ./pkg/dashboard/webstatic/), and commit both files. See src/docs/dashboard-source-layout.md.
2. changelog-fragment-guard fails β the diff touches .go/.html under src/, so the guard wants a changelog.d/<category>-<slug>.md fragment or the no-changelog label. Since this is comment-only, no-changelog is the honest choice; a maintainer has to apply the label, or you can add a tiny changelog.d/changed-codex-snapshot-provenance.md fragment.
One informational note: src/scripts/check-cli-model-lists.sh:65 reads the first version after "matches codex" (sed -n -E 's/.*matches codex ([0-9][0-9.]*).*/\1/p') and compares it to the Dockerfile pin. With the new wording it extracts 0.166.0, which matches v5's current pin, so it is quiet today β but when #16873 lands (pin β 0.167.0) the warning returns despite "and 0.167.0" being on the next line. Not a defect in this PR; just a heads-up that the two-version phrasing doesn't buy what it looks like it buys against that script.
I could not independently re-run codex app-server model/list from here, so I'm taking the "catalogs match the existing list" claim in the body as the author's verification; the list contents are unchanged in the diff, so the risk of that claim being wrong is confined to the comment being inaccurate.
I have not approved or closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Comment-only change; the Go-side edit in 1. 2. changelog-fragment-guard / native-queue-policy (medium). Intent matches #16961 (refresh the 0.165.0 provenance comment in both the Go fallback and the frontend mirror); per the issue the snapshot content itself was already current, and the body's claim that only comments change is consistent with the diff. Author pushes from a fork, so I can't push the fix. hive/awaiting-ci: pushed e235f28 to this branch (adopted, stage/074) β the provenance comment now also changes in π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Check report (hive scanner, read-only β fork branch, nothing pushed) for head 1. 2. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
@Karibhou the hive has adopted this PR ( |
static/index.html is generated by the byte-exact concatenation of static-src/ (pkg/dashboard/webstatic.TestIndexHTMLIsGenerated), so the provenance comment has to change in backends-tokens.js as well or the generated artifact drifts from its sources. Refs hivecommons#16961 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Closes #16961
Captured
model/listwith hidden models from Codex 0.166.0 and 0.167.0 using isolated CODEX_HOME directories. Both catalogs match the existing Go fallback and frontend mirror after visible-first ordering, so only their provenance comments need updating. The v5 Dockerfile still pins 0.166.0; PR #16873 proposes 0.167.0.Verification: live app-server exchanges against both versions;
gofmt -l src/pkg/dashboard/cli_models.goproduced no output. No behavioral change, so no new tests.β hive: backend=omp model=openai-codex/gpt-6.1-terra
π Hive Agent:
contributor| SHA:0c948a9ec