Repository navigation
π fix(dashboard): hold_reason names only what holds a PR; drafts land in the Draft band - #16824
Conversation
β¦ in the Draft band hold_reason told sentinel-only PRs (homebrew-tap#60, testsuite#1108) to wait for a hold label they do not carry and called a holdguard hold the ACMM gate; it now reads the PR's hold labels and hold_sources (Go and repo-card JS). Drafts are sidelined by the enumeration, so the Draft band was always 0; the bands and overview counts now include them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Read at head d8ffe1c against v6, with the enumeration in pkg/github/client.go and the band code around the diff. The two fixes do what the body says; one low-severity edge to decide on.
Verified correct
bands.go:695-713heldReason: the ACMM sentence is now gated onlen(held) > 0 && (len(sources)==0 || slices.Contains(sources, HoldSourceLevelGate)), andpr.HoldSourcesis populated for held PRs atclient.go:2423.HoldSourceLevelGateis"level_gate"(hold_sources.go:7), matching the JS literal atrepos.js:709-710.FrontendPRembedsgithub.PullRequest(status_builder.go:1824), whoseHoldSourcescarriesjson:"hold_sources,omitempty"(client.go:1230), soitem.hold_sourcesexists on the card payload.static/index.htmlcarries the same new string asrepos.js.- Drafts are only ever sidelined β
client.go:2389-2432keepspr.GetDraft()out ofheldPRs, andclient.go:2443-2445out of the actionable list β so walkingNonActionablePrsinfrontendRepoDraftPRs(overview_export.go:516-530) adds no double count againstOpenPrs/HeldPrs. go build ./pkg/dashboard/passes at this head.
Low: exempt-labelled drafts land in the Draft band, unlike breakdown.Draft
frontendRepoDraftPRs filters on w.Draft (overview_export.go:520), not on w.Bucket == "draft" as its own comment says. Client.repoWorkPR sets Draft: pr.GetDraft() for every sidelined PR (client.go:5068), including a draft sidelined for an exempt label at client.go:2437-2439 (bucket filtered, which runs before the draft branch and does not bump breakdown.Draft at client.go:2444). So a repo with a draft wearing e.g. do-not-merge/hold-style exempt labels gets a Draft band count one higher than the enumeration's own Draft breakdown. The test's excluded row (overview_draft_band_test.go, number 9) is excluded because Draft is false, not because of its bucket, so this path is uncovered; its bucket string "exempt" also does not match the real constant workBucketPRFiltered = "filtered" (client.go:5056). If the intent is "every open draft on GitHub", keep as is and fix the comment; if it is "what the enumeration bucketed as draft", filter on Bucket. Either way a one-line change.
Not blocking in my view; flagging so a maintainer can pick the intended semantics.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Executive summary
Two Overview PR-row errors on the projectbluefin hive:
hold_reasonnamed a hold that wasn't there. PRs held only by their sentinel alert (test: run the cask payload check in CI and gate unwired test scriptsΒ projectbluefin/homebrew-tap#60, testsuite#1108, utah#1109) read "agents will not act on this until the hold label is removed; β¦ a genericholdhere is usually the ACMM level gate", and wear noholdlabel. A holdguard hold (utah-packages#878) got the same ACMM sentence.What
holdfrom the holdguardholdβ¦; usually the ACMM level gate"holdβ¦" with no ACMM sentencehold, sources unknown orlevel_gate/api/overviewandoverview_bandsHow
dashboard/bands.goheldReasontakes the PR'sHoldSources. The repo-card JS copy (static-src/js/repos.jsheldReason) applies the same rule fromhold_sources.overview_export.gofrontendRepoDraftPRsturns the sidelinedRepoWorkPRdrafts into band entries foroverviewPRItems.overview_status.gocounts them inoverview_bands.prs.Tests
TestHeldReasonNamesOnlyWhatHoldsItTestRepoCardHeldNoteBehaviour(+5 checks)TestOverviewDraftsLandInDraftBandgo testdashboard/..., writeback, adminmcp;node --test(332);make dashboard-gen-checkNotes
π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1