Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-16761-prow-lgtm-comment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Corrected the `bindProwLgtm` comment to describe returned reporting errors and best-effort warnings; runtime behavior is unchanged (#16761).
5 changes: 3 additions & 2 deletions src/pkg/github/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -3356,8 +3356,9 @@ const (
)

// bindProwLgtm records the `prow/lgtm` success status on headSHA, the commit
// the queue review approved. The label and review are already in place, so a
// failure is logged and surfaced on the PR but never returned.
// the queue review approved. On failure it returns the error, logs it when a
// logger is available, and attempts to surface a warning on the PR. The caller
// records the reporting error without undoing the already-placed label and review.
func (c *Client) bindProwLgtm(ctx context.Context, owner, repoName string, number int, headSHA, queuedBy string) error {
sha7 := headSHA
if len(sha7) > 7 {
Expand Down
Loading