Repository navigation
📖 docs: correct Prow LGTM error comment - #16773
Conversation
Hive-Run: hivecommons#16761 Hive-Plan: correct bindProwLgtm documentation Hive-Spec: issue-16761#reporting-error Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read bindProwLgtm at src/pkg/github/client.go:3361-3420 and its only caller at client.go:3297-3299. The new comment is accurate: every failure path returns fmt.Errorf("Prow status reporting: %w", …) (3395, 3402, 3409, 3411), the logger is nil-guarded (3386), the warning comment is best-effort and skipped on an explicit cancel (3393), and the caller stores the error in res.ReportingError and still returns nil — leaving the label and review in place.
Also checked that #16760 (the PR issue #16761 was blocked on) has merged and did not edit this comment, so there is no conflict. Docs-only; looks correct to me.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. stage 095-pre-merge-soak → 060-reviewed: untrusted-author-role Evidence bundle `#167736280f58` sha256:23344bb9296374fbcd161d49918a4f721d49be48dec544b1cba56ca659a5b2ad — download from the dashboard or `hivectl review evidence #16773`. |
|
Ready for a human merge: verdict approved @208e1a5, 61/61 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: Updated 2026-11-05 16:39 UTC. |
There was a problem hiding this comment.
Looks correct to me — the new wording matches what the function actually does.
Read src/pkg/github/client.go at 208e1a5: every failure path in bindProwLgtm returns an error (client.go:3396, 3407, 3414, 3416), the log is guarded by if c.logger != nil (client.go:3385), and the warning comment is skipped on cancellation or when the marker already exists — i.e. best-effort. The caller at client.go:3298-3300 stores the error in res.ReportingError and still returns res, nil, so "without undoing the already-placed label and review" is accurate.
#16760 (the PR this finding was blocked on) has merged and did not touch the doc comment, so there is no conflict with the base.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay could not take this as a |
…omment Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
There was a problem hiding this comment.
Wording verified against the code at 6280f58: every failure path of bindProwLgtm returns an error (src/pkg/github/client.go:3395, :3404, :3411, :3418) and the caller stores it in res.ReportingError without undoing the label/review (:3298-3300). The new comment is accurate.
Also checked whether this is redundant with #16760 (the PR #16761 was blocked on): it merged on 2026-11-05 without touching this comment, and v5 still carries the stale text, so this PR is still needed. Looks correct to me.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for ≥10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry. |
Correct the bindProwLgtm comment to describe returned reporting errors and best-effort warnings, matching the implementation and caller.
Closes #16761
Verification: inspected the failure paths and caller;
gofmt -l src/pkg/github/client.goandgit diff --checkpassed. No behavioral change; tests are not applicable.— hive: backend=omp model=openai-codex/gpt-6.1-terra
🐝 Hive Agent:
contributor| SHA:f8ace51a3