Repository navigation
🐛 fix: keep navigation label visible on phones - #16769
Conversation
Hive-Run: hivecommons#16690 Hive-Plan: phone navigation label Hive-Spec: issue-16690#phone-navigation-label Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Read the change against the v5 tree; it does what the body says and I found no defect.
src/pkg/dashboard/static-src/html/topbar.html:4-6—#oc-drawer-togglecarriesnav-chip nav-chip--actionand contains a<span class="nav-chip__label">Navigation</span>, so the exemption inagent-detail.css:333targets the right element.- The
:not(#oc-drawer-toggle)raises that hide rule to id specificity for the other action chips; I greppedstatic-src/cssand no rule anywhere sets.nav-chip__labelto anything other thandisplay: none(responsive.css:86-88,593-595,topbar.css:217-218all hide), so nothing that previously out-ranked(0,3,0)is lost. static/index.html:932matches the source change byte-for-byte; the hand-regenerated artifact is consistent with the single-line CSS edit.- Addresses the "phones keep the bare glyph" case #16690 names at
agent-detail.css:333(the ≤1024px display rule at:306is untouched, so the toggle still appears only at tablet/phone widths).
Looks correct to me.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Looks correct to me; this is the exemption #16690 asked for. What I verified at
No browser check from me either; the CSS reasoning is the whole change. Checks are green apart from stage 095-pre-merge-soak → 060-reviewed: untrusted-author-role Evidence bundle `#16769a68aff1` sha256:be9bfe81cfe42aa89b37ead0398c00e898b51be336b143b3ad456b3a77351465 — download from the dashboard or `hivectl review evidence #16769`. |
|
Ready for a human merge: verdict approved @82c3f91, 64/64 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: Updated 2026-11-05 16:18 UTC. |
There was a problem hiding this comment.
Looks correct to me.
agent-detail.css:333is the only ≤600px rule that reached the drawer toggle's label; the other phone-width.nav-chip__labelhides (responsive.css:86-88,topbar.css:217-218) name specific ids and never matched#oc-drawer-toggle. The toggle isdisplay: inline-flexat that width (agent-detail.css:306), so the label is now rendered there. This is exactly the exemption #16690 proposed.- On the hand-assembled artifact: I ran
go run ./gen -src ../static-src -out …fromsrc/pkg/dashboard/webstaticata68aff1and the output is byte-identical to the committedstatic/index.html, so the "concatenated manifest entries" step produced the same filego generatewould have.
Browser check at ≤600px still falls to a human as the body says, but the CSS and the generated artifact are consistent.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for ≥10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry. |
Summary
Fixes #16690
Verification
git diff --checkpassed.go generate ./pkg/dashboard/webstatic/failed because the filesystem was full; the artifact was regenerated by concatenating the manifest entries byte-for-byte.— hive: backend=omp model=openai-codex/gpt-6.1-terra
🐝 Hive Agent:
contributor| SHA:cab69fa42