Repository navigation
π fix(github): stop un-park sweep re-offering decisions on a held issue - #16594
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from Read
One low note, not a blocker: an issue that was already held before this lands and already carries a "What to reply" notice keeps it β Body matches the diff; changelog fragment present; CI green at d858b18. Review findings from Looks correct to me. Read
One wording gap between the body and the diff, not a defect: the body says a held issue "is now treated as not parked", but Review findings from Correctness β delta re-review at 11a2915 (previous head 44a07b4) The delta is changelog-only (
Suggested fix: keep the held issue in sweep scope and instead gate the notice β e.g. skip Review findings from Correctness (delta re-review @ d858b18) β approve. The delta keeps a held issue (
Previous findings: |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Correctness review (read at head 44a07b4, merge-base 4af9ef2)
The logic change is sound: isHeldAfterDecision (src/pkg/github/issue_unpark_command.go:1293-1297) excludes every entry of issueParkingLabels other than needs-human (issue_unpark_command.go:27), so when it fires no other park label is present and hasIssueParkingLabel returning false (:790-793) is consistent. DecisionLiftsNeedsHuman always returns true (src/pkg/stageengine/facts_sink.go:93-96), so needs-human + approved-direction with no 045 only arises when a person/scanner re-applies needs-human after a decision β the held state #16591 describes. All three callers (issue_unpark_command.go:362, :460, :562; issue_unpark_operator.go:60) inherit the new semantics, so /hive approve, /hive decision and the dashboard decision are all refused on a held issue, matching #16590's "remove approved-direction to decide again". go build ./pkg/github/ passes at head.
Blocker (in-scope, CI): changelog.d/fixed-16591.md:1 starts with prose (The un-park sweep no longerβ¦) instead of a - bullet. src/scripts/check-changelog-fragment.sh:71-74 rejects this, and changelog-fragment-guard already failed on this head (job 126603293808: "a fragment must start with a '- ' entry bullet"). The autofix commit 44a07b4 added changelog.d/fixed-16594.md but left the bad fragment in place, so the re-run will fail again. Fix: prefix fixed-16591.md with - and drop the now-redundant fixed-16594.md (one fragment per PR, per changelog.d/README.md).
Advisory (out-of-scope, pre-existing): the "What to reply" notice (issue_unpark_command.go:1184-1205) is only edited/created, never retired, so a held issue keeps the stale notice comment; the sweep just stops refreshing it. Same behaviour as any normally un-parked issue today.
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦offer Review of #16594: dropping needs-human + approved-direction from hasIssueParkingLabel took the held issue out of the sweep entirely, so a /hive decision, /hive help or /fixed posted on it was no longer parsed or answered. #16591 only asked to stop re-offering the decision. Keep the issue in scope and gate the "What to reply" notice and the prose hint on !isHeldAfterDecision instead; commands are still answered. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Intent alignment (delta 44a07b4 β d858b18)
The delta changes approach: held issues (needs-human + approved-direction, no stage/045) now stay in the sweep (src/pkg/github/issue_unpark_command.go:794 no longer short-circuits; issue_unpark_command_test.go:1290 asserts hasIssueParkingLabel is true for them) and only the "What to reply" notice and the prose hint are suppressed (issue_unpark_command.go:451, :510). That does address #16591's complaint (the notice re-inviting /hive approve//hive decision) while keeping /hive decision, /hive help and /fixed answerable β a reasonable choice.
Finding (low, in-scope): the PR body still says "It is now treated as not parked", which is what the previous head did and the opposite of what this head does. Please reword the body to match the fragment (changelog.d/fixed-16591.md:1): notice/hint suppressed, issue still in the sweep.
Previous findings: changelog guard β fixed (bullet + issue link, stray fixed-16594.md removed). src/docs/maintainer-commands.md not updated β still present (no docs in the PR); note /hive help on a held issue still repeats the approve/decision options (renderUnparkHelpReply unchanged), so the docs-currency owner should judge whether that row needs a caveat.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read tryUnparkIssue and the label helpers at 92367ae. The held predicate and the two suppressions are correct, and the tests exercise the right matrix (/hive decision, /hive help, /fixed still answered on a held issue). One gap against #16591, though.
The notice the issue complains about is never retracted (src/pkg/github/issue_unpark_command.go:449-456, :1188-1206). In the motivating sequence an issue is parked first β so ensureUnparkNoticeComment has already posted the "What to reply" block offering /hive approve / /hive decision β and only then does a human decision turn it into needs-human + approved-direction. This PR makes the sweep skip ensureUnparkNoticeComment when held, so that existing comment is neither edited nor deleted; nothing else in the package touches unparkNoticeMarker (only :48, :1108, :1191). The result is that the stale invitation stays at the bottom of exactly the issues #16591 describes. The new test TestSweepIssueUnparkCommandsHeldIssueGetsNoNoticeOrProseHint only covers a held issue that never had a notice (heldIssue() builds on parkedIssue() with no notice comment), which is why it passes.
Suggested fix, same shape as the existing edit-in-place path: when held and a unparkNoticeMarker comment exists, edit it to a short "held after a human decision β nothing to decide; /fixed closes it" body (or delete it), and add the held-with-existing-notice case to the test. Low severity β nothing acts on the stale text β but it is the visible half of the issue.
Minor: the body says the held issue "is now treated as not parked", but hasIssueParkingLabel is unchanged (:794-804) and the issue deliberately stays in the sweep; the changelog fragment describes the actual behaviour accurately.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Why: an issue wearing
needs-human+approved-direction(no stage/045) is held after a human decision, yethasIssueParkingLabelstill counted it as parked, so the un-park sweep kept it in scope and kept offering /hive approve|decision with nothing to decide. It is now treated as not parked. Complements #16590 (which derives stage None for it).Closes #16591
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88