You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (correctness): Un-park sweep still treats the held issue as parked and keeps offering /hive approve|decision #16591
Filed from an out-of-scope finding in the Hive review of PR #16590.
PR: #16590 (#16590)
Perspective: correctness
Severity: low (P3)
Finding: Un-park sweep still treats the held issue as parked and keeps offering /hive approve|decision
Evidence: src/pkg/github/issue_unpark_command.go:787
With the derived stage None the issue still carries needs-human, so hasIssueParkingLabel (issue_unpark_command.go:787) keeps the issue in the un-park sweep and the 'What to reply' notice keeps inviting /hive approve or /hive decision although nothing is open to decide. #16579 lists this as expected behaviour (directions 2/3); the PR body explicitly defers it, so it is follow-up work, not a blocker here.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #16594 (#16594) and folded into this issue because it is a correctness finding at the same symbol or lines of src/pkg/github/issue_unpark_command.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
[reviewer] Review backlog (correctness): Stale 'What to reply' notice is never retired on a held issue
Stale 'What to reply' notice is never retired on a held issue (src/pkg/github/issue_unpark_command.go:1184)
Perspective: correctness
Severity: low (P3)
Finding: Stale 'What to reply' notice is never retired on a held issue
Evidence: src/pkg/github/issue_unpark_command.go:1184
// ensureUnparkNoticeComment posts the "What to reply" block once per parked
ensureUnparkNoticeComment (issue_unpark_command.go:1184-1205) only creates or edits the notice; nothing deletes/edits it when an issue leaves the parked set. With this PR a held issue (needs-human + approved-direction, no 045) drops out of the sweep at :362, so its existing notice stays offering /hive approve|decision indefinitely, though it is no longer refreshed. Pre-existing: the same happens for any normally un-parked issue today. Follow-up: retire or rewrite the notice when hasIssueParkingLabel flips false.
Activity
hivecommons-hive commentedon Nov 4, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).Claim history
scanner(agent on hive hosted-available-oke-11-placeholder-r05x)scanner(agent; holding agent relaunched)hivecommons-hive commentedon Nov 4, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #16594 (#16594) and folded into this issue because it is a correctness finding at the same symbol or lines of
src/pkg/github/issue_unpark_command.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.[reviewer] Review backlog (correctness): Stale 'What to reply' notice is never retired on a held issue
src/pkg/github/issue_unpark_command.go:1184)Perspective: correctness
Severity: low (P3)
Finding: Stale 'What to reply' notice is never retired on a held issue
Evidence:
src/pkg/github/issue_unpark_command.go:1184hive/src/pkg/github/issue_unpark_command.go
Line 1184 in 44a07b4
ensureUnparkNoticeComment (issue_unpark_command.go:1184-1205) only creates or edits the notice; nothing deletes/edits it when an issue leaves the parked set. With this PR a held issue (needs-human + approved-direction, no 045) drops out of the sweep at :362, so its existing notice stays offering /hive approve|decision indefinitely, though it is no longer refreshed. Pre-existing: the same happens for any normally un-parked issue today. Follow-up: retire or rewrite the notice when hasIssueParkingLabel flips false.
Fingerprint:
44d05f1a4db2af7e704fe4e0df8eefe44284135cd4afe1872e96a07532eaa175filed by Hive review backlog
fix(github): keep held issues in the un-park sweep, only drop the re-…
🐛 fix(github): stop un-park sweep re-offering decisions on a held iss…
Merge remote-tracking branch 'origin/v5' into v6-topup-20261103 (top-…