Skip to content

✨ Reviewer scope questions on hive-authored green PRs should auto-decide, not park at 085 #16597

Closed

Description

@clubanderson

Problem

docs#618 — a hive-authored ✨ feat(sync) PR with CI 4/4 passed, Review 5/5, no findings — sat at stage 085 "Needs human decision" because one review perspective ended with a question rather than a finding:

@clubanderson should decide whether to apply the hive-docs-refresh.yml opt-in from the PR body … and whether this PR should merge ahead of that workflow edit.

decision_needed.asked_by = "a reviewer". The word "workflow" in the ask alone tripped the self-authored decision risk class. Earlier, the same for hive#16456 ("Decision needed: @clubanderson should confirm the merge-request relay may lift the hold…").

Owner verdict: "this is a waste of my time — this is auto-merge material, not needs-human".

Design

  1. Classify reviewer "decision needed" asks (pure function, table-tested):
    • Policy sign-off — stays human: PR edits .github/workflows/* / .github/actions/* from a fork, touches OWNERS / CODEOWNERS / SECURITY / rulesets / secrets / key material, adds or removes auto_merge / human_merge_paths / self_authored_decision_policy config, or the ask names an owner-only guard (sentinel, GitHub/App permissions, unauthorized, tokens/secrets/credentials, branch protection).
    • Scope / follow-up question — "should we also…", "merge ahead of…", "apply X from the PR body", "confirm Y is acceptable" on a hive-authored (or hive-adopted) PR with CI green and no unresolved finding on the head.
  2. For a scope question: do not park at 085. Run the existing Let hive decide (decide-delegated) pipeline with the hive as requester. Approve → merge queue plus a follow-up: <question> issue linked to the PR; direction → fixer (070); owner-only / recommend-only → the 085 park stays, with the hive's recommendation on the row ("needs your sign-off", 🐛 Activity Monitor: say whose sign-off a parked review needs and lead with Approve #16578).
  3. At most one auto-decide per head (persisted marker; a new push asks again); one INFO line per run with the classification reason; review_questions_autodecided_1h on /api/status.
  4. Config governor.review.auto_decide_questions (default true); documented in the operator reference.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  2. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

  3. added a commit that references this issue on Nov 4, 2026
    b7cc0d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions