Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-activity-title-pills-overlap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Activity monitor: the pills on a row's title line (`train · joins behind #N`, `stage ↓`, the base-branch pill) no longer draw on top of the PR title. The chevron-strip grid rule added with the parallel CI/Review lanes (`.ham-strip:not(.ham-head-cols)`) also matched the title line, because `ham-head-cols` sits on the strip's row, not on the strip. That squeezed the issue, PR title and pills into the first three chevron-wide columns, and pills wider than one column spilled left over the title. The rule now excludes the title line by its row, so the issue spans Open..Claimed again, the PR starts at PR in progress, and the pills sit at the right.
8 changes: 7 additions & 1 deletion src/pkg/dashboard/static-src/css/tracker.css
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,13 @@
.ham-badge-reroute .ham-presence-dot { width: 0.5em; height: 0.5em; border-radius: var(--r-pill); background: var(--text-faint); flex: 0 0 auto; }
.ham-badge-reroute.ham-reroute-online .ham-presence-dot { background: var(--status-ok); }
.ham-strip { list-style: none; margin: 0; padding: 0; display: flex; gap: var(--sp-1); min-height: 18px; flex: 1 1 auto; min-width: 0; --ham-notch: 8px; --ham-visible-columns: 7; }
.ham-strip:not(.ham-head-cols) { display: grid; grid-template-columns: repeat(var(--ham-visible-columns), minmax(0, 1fr)) 4em; }
/* The chevron strips (and the column header) are a grid; the title
line's strip is not — its lead / PR / cap cells size by flex. The
ham-head-cols class sits on the strip's row, not on the strip, so
the exclusion is spelled on the row: on the strip itself it matched
every strip and put the title line's cap chips in one chevron-wide
column, where wide chips spilled left over the PR title. */
.ham-strip-row:not(.ham-head-cols) > .ham-strip { display: grid; grid-template-columns: repeat(var(--ham-visible-columns), minmax(0, 1fr)) 4em; }
.ham-seg { position: relative; flex: 1 1 0; min-width: 0; display: flex; align-items: center; justify-content: center; padding: 0 var(--sp-4) 0 var(--sp-5); font-size: var(--fs-xs); font-weight: var(--fw-medium); white-space: nowrap; overflow: hidden; clip-path: polygon(0 0, calc(100% - var(--ham-notch)) 0, 100% 50%, calc(100% - var(--ham-notch)) 100%, 0 100%, var(--ham-notch) 50%); }
.ham-activity-track { clip-path: none; border: var(--line-width) solid var(--line-subtle); border-radius: var(--r-sm); flex-direction: column; align-items: flex-start; padding: var(--sp-1) var(--sp-2); white-space: normal; }
.ham-track-name { font-weight: var(--fw-semibold); }
Expand Down
8 changes: 7 additions & 1 deletion src/pkg/dashboard/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -1668,7 +1668,13 @@
.ham-badge-reroute .ham-presence-dot { width: 0.5em; height: 0.5em; border-radius: var(--r-pill); background: var(--text-faint); flex: 0 0 auto; }
.ham-badge-reroute.ham-reroute-online .ham-presence-dot { background: var(--status-ok); }
.ham-strip { list-style: none; margin: 0; padding: 0; display: flex; gap: var(--sp-1); min-height: 18px; flex: 1 1 auto; min-width: 0; --ham-notch: 8px; --ham-visible-columns: 7; }
.ham-strip:not(.ham-head-cols) { display: grid; grid-template-columns: repeat(var(--ham-visible-columns), minmax(0, 1fr)) 4em; }
/* The chevron strips (and the column header) are a grid; the title
line's strip is not — its lead / PR / cap cells size by flex. The
ham-head-cols class sits on the strip's row, not on the strip, so
the exclusion is spelled on the row: on the strip itself it matched
every strip and put the title line's cap chips in one chevron-wide
column, where wide chips spilled left over the PR title. */
.ham-strip-row:not(.ham-head-cols) > .ham-strip { display: grid; grid-template-columns: repeat(var(--ham-visible-columns), minmax(0, 1fr)) 4em; }
.ham-seg { position: relative; flex: 1 1 0; min-width: 0; display: flex; align-items: center; justify-content: center; padding: 0 var(--sp-4) 0 var(--sp-5); font-size: var(--fs-xs); font-weight: var(--fw-medium); white-space: nowrap; overflow: hidden; clip-path: polygon(0 0, calc(100% - var(--ham-notch)) 0, 100% 50%, calc(100% - var(--ham-notch)) 100%, 0 100%, var(--ham-notch) 50%); }
.ham-activity-track { clip-path: none; border: var(--line-width) solid var(--line-subtle); border-radius: var(--r-sm); flex-direction: column; align-items: flex-start; padding: var(--sp-1) var(--sp-2); white-space: normal; }
.ham-track-name { font-weight: var(--fw-semibold); }
Expand Down
Loading