Skip to content

πŸ› Drop cross-row chevron height assertion from geometry probe - #16471

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/activity-geometry-row-height-20261103
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/activity-geometry-row-height-20261103

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Harness-only follow-up to #16464. The browser geometry probe still asserted that each physical lane keeps the same height across rows β€” the old fixed two-line-box contract. Rows are now content-driven (one or two caption lines), so this failed all 24 viewport/theme cases in the reporting-only screenshot workflow on 6a6d1d35 (run 41714012283). Within-row uniformity (all physical chevrons have uniform height) and the content-driven height assertion are unchanged. No runtime assets touched.

Rows are now only as tall as their longest caption (#16464), so the
browser geometry probe's requirement that each lane keep the same height
across rows contradicted the shipped contract and failed every viewport
in the reporting-only screenshot workflow. Within-row uniformity and the
content-driven height check remain.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson clubanderson added the no-changelog No changelog fragment required label Nov 3, 2026
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive
hivecommons-hive Bot merged commit 9a39087 into v5 Nov 3, 2026
82 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/activity-geometry-row-height-20261103 branch November 3, 2026 23:05
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1647137e2a79` sha256:94229c8e50c39934678671050ab2410f52327cd6d267fbc562040138e08ff5c7 β€” download from the dashboard or `hivectl review evidence #16471`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 37e2a79.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. no-changelog No changelog fragment required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant