Repository navigation
π Drop cross-row chevron height assertion from geometry probe - #16471
Conversation
Rows are now only as tall as their longest caption (#16464), so the browser geometry probe's requirement that each lane keep the same height across rows contradicted the shipped contract and failed every viewport in the reporting-only screenshot workflow. Within-row uniformity and the content-driven height check remain. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 37e2a79. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Harness-only follow-up to #16464. The browser geometry probe still asserted that each physical lane keeps the same height across rows β the old fixed two-line-box contract. Rows are now content-driven (one or two caption lines), so this failed all 24 viewport/theme cases in the reporting-only screenshot workflow on
6a6d1d35(run 41714012283). Within-row uniformity (all physical chevrons have uniform height) and the content-driven height assertion are unchanged. No runtime assets touched.