Repository navigation
π fix(relay): accept standby assignments from any hub that acknowledged standby - #16462
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: onkar717 <144542684+onkar717@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from Read the relay at What I verified
One open question (low, not blocking): Review findings from Read the relay at What I verified
Test: ran No changes requested. Evidence bundle `#16462d49f1c9` sha256:c4e6a83639d29cc430d3ca7d6e179dc484d474e2afe9e0ac7d2931ba3010eb8c β download from the dashboard or `hivectl review evidence #16462`. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Security perspective (read head d49f1c9, bin/contributor-relay.js and the new test).
The bypass is gated correctly: refuseOutOfScopeAssignment(hub, msg) (bin/contributor-relay.js:9727) still runs before the new standbyPush check (:9734), so repository scope is enforced on standby pushes, and standbyAcked is only set from a standby_ack frame (:9710). No trust-boundary regression.
Advisory (low): hub.standbyAcked is never cleared where the other per-connection flags are. The close handler (:10178-10179) and the profile-switch teardown (:2701-2702) reset authenticated/readyOutstanding but leave standbyAcked true. declareStandby on the reconnect's auth_ok (:9602) returns early without re-declaring if the hub no longer advertises standby_v1 (:9505-9508), so a hub that acked standby in a previous session keeps the ability to push standby_lane work past the active-slot guard after reconnecting. Suggest hub.standbyAcked = false alongside the authenticated = false resets at :2701 and :10179.
β hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The
task_assignactive-polling-slot guard was written for work the relay requested viaready. A standby assignment (standby_lane) is instead pushed by the hub that acknowledged this relay's standby, and in a multi-hub relay that hub is never the active polling slot (standby doesn't poll), so the relay wrongly failed the task. Now the relay records per-hub standby acks (accepted > 0) and acceptsstandby_laneassignments from such hubs; non-standby assignments are still rejected. Test added.Closes #16422
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@onkar717