You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (correctness): hub.standbyAcked is not cleared when the socket closes #16463
Blocked on PR #16462. This finding came from reviewing PR #16462 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16462.
PR: #16462 (#16462)
Perspective: correctness
Severity: low (P3)
Finding: hub.standbyAcked is not cleared when the socket closes
Evidence: bin/contributor-relay.js:10177
The ws 'close' handler (bin/contributor-relay.js:10177-10180) resets readyOutstanding/authenticated/scopeAckVersion but not the new hub.standbyAcked, so a hub that acknowledged standby once stays trusted for standby_lane pushes across a reconnect even if it stops advertising standby_v1 or rejects all lanes on the re-declare without replying. Benign today: declareStandby re-runs on every auth_ok (9602) and a fresh standby_ack overwrites the flag, and a hub without standby only ever pushes ordinary work (no standby_lane), which the active-slot guard still rejects. Clearing it alongside the other per-connection fields would keep the state honest.
Same file as #16422: both cite bin/contributor-relay.js, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
Unblocked: #16462 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Claim history
2026-11-03 20:39 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Activity
hivecommons-hive commentedon Nov 3, 2026
Same file as #16422: both cite
bin/contributor-relay.js, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Nov 3, 2026
Unblocked: #16462 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 3, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16462 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 3, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.Claim history
scanner(agent on hive hosted-available-oke-11-placeholder-r05x)fix(relay): forget standby ack on every hub teardown path; add regres…
🐛 fix(relay): clear hub.standbyAcked when the hub socket closes (#16465)
hivecommons-hive commentedon Nov 3, 2026
Fixed by #16465 (merged 0ed03ff). Closing. Reply /reopen if the problem persists.