Skip to content

[reviewer] Review backlog (correctness): hub.standbyAcked is not cleared when the socket closes #16463

Closed

Description

@hivecommons-hive

Blocked on PR #16462. This finding came from reviewing PR #16462 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16462.

PR: #16462 (#16462)
Perspective: correctness
Severity: low (P3)
Finding: hub.standbyAcked is not cleared when the socket closes
Evidence: bin/contributor-relay.js:10177

// the reconnect asks afresh.

The ws 'close' handler (bin/contributor-relay.js:10177-10180) resets readyOutstanding/authenticated/scopeAckVersion but not the new hub.standbyAcked, so a hub that acknowledged standby once stays trusted for standby_lane pushes across a reconnect even if it stops advertising standby_v1 or rejects all lanes on the re-declare without replying. Benign today: declareStandby re-runs on every auth_ok (9602) and a fresh standby_ack overwrites the flag, and a hub without standby only ever pushes ordinary work (no standby_lane), which the active-slot guard still rejects. Clearing it alongside the other per-connection fields would keep the state honest.

Fingerprint: f5cabc62e4a1e639829cf6b24414d806d9ae6becc8c20c1557e946811be47bd2

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  2. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #16422: both cite bin/contributor-relay.js, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  5. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16462 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16462 is no longer open. This issue is actionable again.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  8. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-03 20:39 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
  9. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16465 (merged 0ed03ff). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions