Repository navigation
π fix: align standby qualification with dispatch queue - #16450
Conversation
Use the dispatchable admission queue and exact lane assignment when computing standby qualification counts. Hive-Run: #16420 Hive-Plan: standby-contributors Hive-Spec: standby-contributors#S7 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Document that qualified standby counts use the dispatchable queue and exact lane assignment. Hive-Run: #16420 Hive-Plan: standby-contributors Hive-Spec: standby-contributors#S7 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Looks correct to me (read at head 7511fe1, byte-identical to #16436's head I reviewed earlier today).
standbyLaneItems(src/pkg/dashboard/contribute_ws.go:3141-3155) applies the sameHeldskip andstrings.EqualFold(strings.TrimSpace(item.Lane), lane)test thatstandbyDispatchItemuses (contribute_standby_dispatch.go:198-209), so "M qualify" can only name a contributor for an item that lane can actually dispatch β the #16420 scenario (scanneritem routed to another lane, or held) now yields 0.- No lock hazard:
UpdateStatusIfFreshcallsadmissionQueueSnapshotatserver.go:2429and does not takestatusMuuntil ~:2481; the snapshot onlyRLocks it (contribute_sse.go:304-306). - Advisory, not blocking:
admissionQueueSnapshotreadsh.server.status, the previously published payload (contribute_sse.go:305), soqualified_standbyslags one refresh and is0on the first publish. Dispatch reads the same source, so tile and dispatch agree.lane_queue_depthsis unchanged, so "N waiting" and "M qualify" are now computed from different splits; the issue accepted that trade-off and the S7 doc edit says so.
Nothing here that I would ask the fix agent to change before merge.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Looks correct to me; the only red check is not this diff's fault. Read at
On the failing |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #16436 (adopted after CI went red and the contributor was unavailable; original commits by @mrbobbytables preserved).
Fixes #16420
This branch is #16436's head
7511fe18d47bas pushed by @mrbobbytables (forkmrbobbytables/hive), unchanged. Last lane reason on the original:contributor-lane:changes-requested.Hive fix agent: rebase this branch on
v6, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Open review finding carried over from #16436: the review swarm's latest verdict on
7511fe18d47brequested changes (changes_requested); read the swarm's review on #16436, address it here, and let the swarm re-review this PR. Green CI alone is not done.